linux-toradex.git/drivers/target/tcm_fc, branch v3.16.6

tcm_fc: Generate TASK_SET_FULL status for response failures

2014-06-06T21:20:51+00:00

This patch changes ft_queue_status() to set SAM_STAT_TASK_SET_FULL
status upon lport->tt.seq_send( failure, and return -EAGAIN to notify
target-core to attempt to requeue the response.

It also does the same for a fc_frame_alloc() failures, in order to
signal the initiator that it should try to reduce it's current
queue_depth, to lower the number of outstanding I/Os on the wire.

Reported-by: Vasu Dev 
Reviewed-by: Vasu Dev 
Cc: Jun Wu 
Signed-off-by: Nicholas Bellinger

tcm_fc: Generate TASK_SET_FULL status for DataIN failures

2014-06-06T21:20:23+00:00

This patch changes ft_queue_data_in() to set SAM_STAT_TASK_SET_FULL
status upon a lport->tt.seq_send() failure, where it will now stop
sending subsequent DataIN, and immediately attempt to send the
response with exception status.

Sending a response with SAM_STAT_TASK_SET_FULL status is useful in
order to signal the initiator that it should try to reduce it's
current queue_depth, to lower the number of outstanding I/Os on
the wire.

Also, add a check to skip sending DataIN if TASK_SET_FULL status
has already been set due to a response lport->tt.seq_send()
failure, that has asked target-core to requeue a response.

Reported-by: Vasu Dev 
Reviewed-by: Vasu Dev 
Cc: Jun Wu 
Signed-off-by: Nicholas Bellinger

tcm_fc: Fix free-after-use regression in ft_free_cmd

2014-05-16T00:09:12+00:00

This patch fixes a free-after-use regression in ft_free_cmd(), where
ft_sess_put() is called with cmd->sess after percpu_ida_free() has
already released the tag.

Fix this bug by saving the ft_sess pointer ahead of percpu_ida_free(),
and pass it directly to ft_sess_put().

The regression was originally introduced in v3.13-rc1 commit:

  commit 5f544cfac956971099e906f94568bc3fd1a7108a
  Author: Nicholas Bellinger 
  Date:   Mon Sep 23 12:12:42 2013 -0700

      tcm_fc: Convert to per-cpu command map pre-allocation of ft_cmd

Reported-by: Jun Wu 
Cc: Mark Rustad 
Cc: Robert Love 
Cc:  #3.13+
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Rename ft_tport_create to ft_tport_get

2014-04-11T22:30:52+00:00

Because it doesn't always create, if there's an existing one it just
returns it.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Rename ft_{add,del}_lport to {add,del}_wwn

2014-04-11T22:30:51+00:00

These functions are not adding or deleting an lport. They are adding a
wwn that may match with an lport that is present on the system.

Renaming ft_del_lport also means we won't have functions named
both ft_del_lport and ft_lport_del any more.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Rename structs and list members for clarity

2014-04-11T22:30:51+00:00

Rename struct ft_lport_acl to ft_lport_wwn. "acl" is associated with
something different in LIO terms. Really, ft_lport_wwn is the
fabric-specific wrapper for the struct se_wwn.

Rename "lacl" local variables to "ft_wwn" as well.

Rename list_heads used as list members to make it clear they're nodes, not
heads.

Rename lport_node to ft_wwn_node.

Rename ft_lport_list to ft_wwn_list

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Limit to 1 TPG per wwn

2014-04-11T22:30:50+00:00

tcm_fc doesn't support multiple TPGs per wwn. For proof, see
ft_lport_find_tpg. Enforce this in the code.

Replace ft_lport_wwn.tpg_list with a single pointer. We can't fold ft_tpg
into ft_lport_wwn because they can have different lifetimes.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Don't export ft_lport_list

2014-04-11T22:30:50+00:00

Nobody outside tfc_conf.c uses it.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Fix use-after-free of ft_tpg

2014-04-11T22:27:23+00:00

ft_del_tpg checks tpg->tport is set before unlinking the tpg from the
tport when the tpg is being removed. Set this pointer in ft_tport_create,
or the unlinking won't happen in ft_del_tpg and tport->tpg will reference
a deleted object.

This patch sets tpg->tport in ft_tport_create, because that's what
ft_del_tpg checks, and is the only way to get back to the tport to
clear tport->tpg.

The bug was occuring when:

- lport created, tport (our per-lport, per-provider context) is
  allocated.
  tport->tpg = NULL
- tpg created
- a PRLI is received. ft_tport_create is called, tpg is found and
  tport->tpg is set
- tpg removed. ft_tpg is freed in ft_del_tpg. Since tpg->tport was not
  set, tport->tpg is not cleared and points at freed memory
- Future calls to ft_tport_create return tport via first conditional,
  instead of searching for new tpg by calling ft_lport_find_tpg.
  tport->tpg is still invalid, and will access freed memory.

see https://bugzilla.redhat.com/show_bug.cgi?id=1071340

Cc: stable@vger.kernel.org # 3.0+
Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Pass in transport supported PI at session initialization

2014-04-07T08:48:54+00:00

In order to support local WRITE_INSERT + READ_STRIP operations for
non PI enabled fabrics, the fabric driver needs to be able signal
what protection offload operations are supported.

This is done at session initialization time so the modes can be
signaled by individual se_wwn + se_portal_group endpoints, as well
as optionally across different transports on the same endpoint.

For iser-target, set TARGET_PROT_ALL if the underlying ib_device
has already signaled PI offload support, and allow this to be
exposed via a new iscsit_transport->iscsit_get_sup_prot_ops()
callback.

For loopback, set TARGET_PROT_ALL to signal SCSI initiator mode
operation.

For all other drivers, set TARGET_PROT_NORMAL to disable fabric
level PI.

Cc: Martin K. Petersen 
Cc: Sagi Grimberg 
Cc: Or Gerlitz 
Cc: Quinn Tran 
Cc: Giridhar Malavali 
Signed-off-by: Nicholas Bellinger