linux-toradex.git/drivers/target/tcm_fc, branch v4.0.2

tcm_fc: missing curly braces in ft_invl_hw_context()

2015-03-20T06:26:41+00:00

This patch adds a missing set of conditional check braces in
ft_invl_hw_context() originally introduced by commit dcd998ccd
when handling DDP failures in ft_recv_write_data() code.

 commit dcd998ccdbf74a7d8fe0f0a44e85da1ed5975946
 Author: Kiran Patil 
 Date:   Wed Aug 3 09:20:01 2011 +0000

    tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data

Signed-off-by: Dan Carpenter 
Cc: Kiran Patil 
Cc:  # 3.1+
Signed-off-by: Nicholas Bellinger

scsi: remove MSG_*_TAG defines

2014-12-04T08:58:33+00:00

For SPI drivers use the message definitions from scsi.h, and for target
drivers introduce a new TCM_*_TAG namespace.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen

tcm_fc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2014-09-15T21:27:33+00:00

The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Signed-off-by: Andreea-Cristina Bernat 
Signed-off-by: Nicholas Bellinger

tcm_fc: Generate TASK_SET_FULL status for response failures

2014-06-06T21:20:51+00:00

This patch changes ft_queue_status() to set SAM_STAT_TASK_SET_FULL
status upon lport->tt.seq_send( failure, and return -EAGAIN to notify
target-core to attempt to requeue the response.

It also does the same for a fc_frame_alloc() failures, in order to
signal the initiator that it should try to reduce it's current
queue_depth, to lower the number of outstanding I/Os on the wire.

Reported-by: Vasu Dev 
Reviewed-by: Vasu Dev 
Cc: Jun Wu 
Signed-off-by: Nicholas Bellinger

tcm_fc: Generate TASK_SET_FULL status for DataIN failures

2014-06-06T21:20:23+00:00

This patch changes ft_queue_data_in() to set SAM_STAT_TASK_SET_FULL
status upon a lport->tt.seq_send() failure, where it will now stop
sending subsequent DataIN, and immediately attempt to send the
response with exception status.

Sending a response with SAM_STAT_TASK_SET_FULL status is useful in
order to signal the initiator that it should try to reduce it's
current queue_depth, to lower the number of outstanding I/Os on
the wire.

Also, add a check to skip sending DataIN if TASK_SET_FULL status
has already been set due to a response lport->tt.seq_send()
failure, that has asked target-core to requeue a response.

Reported-by: Vasu Dev 
Reviewed-by: Vasu Dev 
Cc: Jun Wu 
Signed-off-by: Nicholas Bellinger

tcm_fc: Fix free-after-use regression in ft_free_cmd

2014-05-16T00:09:12+00:00

This patch fixes a free-after-use regression in ft_free_cmd(), where
ft_sess_put() is called with cmd->sess after percpu_ida_free() has
already released the tag.

Fix this bug by saving the ft_sess pointer ahead of percpu_ida_free(),
and pass it directly to ft_sess_put().

The regression was originally introduced in v3.13-rc1 commit:

  commit 5f544cfac956971099e906f94568bc3fd1a7108a
  Author: Nicholas Bellinger 
  Date:   Mon Sep 23 12:12:42 2013 -0700

      tcm_fc: Convert to per-cpu command map pre-allocation of ft_cmd

Reported-by: Jun Wu 
Cc: Mark Rustad 
Cc: Robert Love 
Cc:  #3.13+
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Rename ft_tport_create to ft_tport_get

2014-04-11T22:30:52+00:00

Because it doesn't always create, if there's an existing one it just
returns it.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Rename ft_{add,del}_lport to {add,del}_wwn

2014-04-11T22:30:51+00:00

These functions are not adding or deleting an lport. They are adding a
wwn that may match with an lport that is present on the system.

Renaming ft_del_lport also means we won't have functions named
both ft_del_lport and ft_lport_del any more.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Rename structs and list members for clarity

2014-04-11T22:30:51+00:00

Rename struct ft_lport_acl to ft_lport_wwn. "acl" is associated with
something different in LIO terms. Really, ft_lport_wwn is the
fabric-specific wrapper for the struct se_wwn.

Rename "lacl" local variables to "ft_wwn" as well.

Rename list_heads used as list members to make it clear they're nodes, not
heads.

Rename lport_node to ft_wwn_node.

Rename ft_lport_list to ft_wwn_list

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/tcm_fc: Limit to 1 TPG per wwn

2014-04-11T22:30:50+00:00

tcm_fc doesn't support multiple TPGs per wwn. For proof, see
ft_lport_find_tpg. Enforce this in the code.

Replace ft_lport_wwn.tpg_list with a single pointer. We can't fold ft_tpg
into ft_lport_wwn because they can have different lifetimes.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger