linux-toradex.git/drivers/target, branch v3.0.79

target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs

2013-04-17T04:02:31+00:00

commit 30f359a6f9da65a66de8cadf959f0f4a0d498bba upstream.

This patch fixes a bug where a handful of informational / control CDBs
that should be allowed during ALUA access state Standby/Offline/Transition
where incorrectly returning CHECK_CONDITION + ASCQ_04H_ALUA_TG_PT_*.

This includes INQUIRY + REPORT_LUNS, which would end up preventing LUN
registration when LUN scanning occured during these ALUA access states.

Signed-off-by: Nicholas Bellinger 
Cc: Hannes Reinecke 
Signed-off-by: Greg Kroah-Hartman

target/pscsi: Fix page increment

2013-03-14T18:32:04+00:00

commit 472b72f2db7831d7dbe22ffdff4adee3bd49b05d upstream.

The page++ is wrong. It makes bio_add_pc_page() pointing to a wrong page
address if the 'while (len > 0 && data_len > 0) { ... }' loop is
executed more than one once.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: Add missing mapped_lun bounds checking during make_mappedlun setup

2013-03-03T22:09:04+00:00

commit fbbf8555a986ed31e54f006b6cc637ea4ff1425b upstream.

This patch adds missing bounds checking for the configfs provided
mapped_lun value during target_fabric_make_mappedlun() setup ahead
of se_lun_acl initialization.

This addresses a potential OOPs when using a mapped_lun value that
exceeds the hardcoded TRANSPORT_MAX_LUNS_PER_TPG-1 value within
se_node_acl->device_list[].

Reported-by: Jan Engelhardt 
Cc: Jan Engelhardt 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

tcm_fc: Do not report target role when target is not defined

2013-01-21T19:44:58+00:00

commit edec8dfefa1f372b2dd8197da555352e76a10c03 upstream.

Clear the target role when no target is provided for
the node performing a PRLI.

Signed-off-by: Mark Rustad 
Reviewed-by: Bhanu Prakash Gollapudi 
Acked by Robert Love 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

tcm_fc: Do not indicate retry capability to initiators

2013-01-21T19:44:58+00:00

commit f2eeba214bcd0215b7f558cab6420e5fd153042b upstream.

When generating a PRLI response to an initiator, clear the
FCP_SPPF_RETRY bit in the response.

Signed-off-by: Mark Rustad 
Reviewed-by: Bhanu Prakash Gollapudi 
Acked by Robert Love 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target/tcm_fc: fix the lockdep warning due to inconsistent lock state

2013-01-17T16:43:54+00:00

commit 9f4ad44b264f8bb61ffdd607148215566568430d upstream.

The lockdep warning below is in theory correct but it will be in really weird
rare situation that ends up that deadlock since the tcm fc session is hashed
based the rport id. Nonetheless, the complaining below is about rcu callback
that does the transport_deregister_session() is happening in softirq, where
transport_register_session() that happens earlier is not. This triggers the
lockdep warning below. So, just fix this to make lockdep happy by disabling
the soft irq before calling transport_register_session() in ft_prli.

BTW, this was found in FCoE VN2VN over two VMs, couple of create and destroy
would get this triggered.

v1: was enforcing register to be in softirq context which was not righ. See,
http://www.spinics.net/lists/target-devel/msg03614.html

v2: following comments from Roland&Nick (thanks), it seems we don't have to
do transport_deregister_session() in rcu callback, so move it into ft_sess_free()
but still do kfree() of the corresponding ft_sess struct in rcu callback to
make sure the ft_sess is not freed till the rcu callback.

...
[ 1328.370592] scsi2 : FCoE Driver
[ 1328.383429] fcoe: No FDMI support.
[ 1328.384509] host2: libfc: Link up on port (000000)
[ 1328.934229] host2: Assigned Port ID 00a292
[ 1357.232132] host2: rport 00a393: Remove port
[ 1357.232568] host2: rport 00a393: Port sending LOGO from Ready state
[ 1357.233692] host2: rport 00a393: Delete port
[ 1357.234472] host2: rport 00a393: work event 3
[ 1357.234969] host2: rport 00a393: callback ev 3
[ 1357.235979] host2: rport 00a393: Received a LOGO response closed
[ 1357.236706] host2: rport 00a393: work delete
[ 1357.237481]
[ 1357.237631] =================================
[ 1357.238064] [ INFO: inconsistent lock state ]
[ 1357.238450] 3.7.0-rc7-yikvm+ #3 Tainted: G           O
[ 1357.238450] ---------------------------------
[ 1357.238450] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
[ 1357.238450] ksoftirqd/0/3 [HC0[0]:SC1[1]:HE0:SE0] takes:
[ 1357.238450]  (&(&se_tpg->session_lock)->rlock){+.?...}, at: [] transport_deregister_session+0x41/0x148 [target_core_mod]
[ 1357.238450] {SOFTIRQ-ON-W} state was registered at:
[ 1357.238450]   [] mark_held_locks+0x6d/0x95
[ 1357.238450]   [] trace_hardirqs_on_caller+0x12d/0x197
[ 1357.238450]   [] trace_hardirqs_on+0xd/0xf
[ 1357.238450]   [] _raw_spin_unlock_irq+0x2d/0x45
[ 1357.238450]   [] __transport_register_session+0xb8/0x122 [target_core_mod]
[ 1357.238450]   [] transport_register_session+0x44/0x5a [target_core_mod]
[ 1357.238450]   [] ft_prli+0x1e3/0x275 [tcm_fc]
[ 1357.238450]   [] fc_rport_recv_req+0x95e/0xdc5 [libfc]
[ 1357.238450]   [] fc_lport_recv_els_req+0xc4/0xd5 [libfc]
[ 1357.238450]   [] fc_lport_recv_req+0x12f/0x18f [libfc]
[ 1357.238450]   [] fc_exch_recv+0x8ba/0x981 [libfc]
[ 1357.238450]   [] fcoe_percpu_receive_thread+0x47a/0x4e2 [fcoe]
[ 1357.238450]   [] kthread+0xb1/0xb9
[ 1357.238450]   [] ret_from_fork+0x7c/0xb0
[ 1357.238450] irq event stamp: 275411
[ 1357.238450] hardirqs last  enabled at (275410): [] rcu_process_callbacks+0x229/0x42a
[ 1357.238450] hardirqs last disabled at (275411): [] _raw_spin_lock_irqsave+0x22/0x8e
[ 1357.238450] softirqs last  enabled at (275394): [] __do_softirq+0x246/0x26f
[ 1357.238450] softirqs last disabled at (275399): [] run_ksoftirqd+0x29/0x62
[ 1357.238450]
[ 1357.238450] other info that might help us debug this:
[ 1357.238450]  Possible unsafe locking scenario:
[ 1357.238450]
[ 1357.238450]        CPU0
[ 1357.238450]        ----
[ 1357.238450]   lock(&(&se_tpg->session_lock)->rlock);
[ 1357.238450]   
[ 1357.238450]     lock(&(&se_tpg->session_lock)->rlock);
[ 1357.238450]
[ 1357.238450]  *** DEADLOCK ***
[ 1357.238450]
[ 1357.238450] no locks held by ksoftirqd/0/3.
[ 1357.238450]
[ 1357.238450] stack backtrace:
[ 1357.238450] Pid: 3, comm: ksoftirqd/0 Tainted: G           O 3.7.0-rc7-yikvm+ #3
[ 1357.238450] Call Trace:
[ 1357.238450]  [] print_usage_bug+0x1f5/0x206
[ 1357.238450]  [] ? save_stack_trace+0x2c/0x49
[ 1357.238450]  [] ? print_irq_inversion_bug.part.14+0x1ae/0x1ae
[ 1357.238450]  [] mark_lock+0x106/0x258
[ 1357.238450]  [] __lock_acquire+0x2e7/0xe53
[ 1357.238450]  [] ? pvclock_clocksource_read+0x48/0xb4
[ 1357.238450]  [] ? rcu_process_gp_end+0xc0/0xc9
[ 1357.238450]  [] ? transport_deregister_session+0x41/0x148 [target_core_mod]
[ 1357.238450]  [] lock_acquire+0x119/0x143
[ 1357.238450]  [] ? transport_deregister_session+0x41/0x148 [target_core_mod]
[ 1357.238450]  [] _raw_spin_lock_irqsave+0x54/0x8e
[ 1357.238450]  [] ? transport_deregister_session+0x41/0x148 [target_core_mod]
[ 1357.238450]  [] transport_deregister_session+0x41/0x148 [target_core_mod]
[ 1357.238450]  [] ? rcu_process_callbacks+0x229/0x42a
[ 1357.238450]  [] ft_sess_rcu_free+0x17/0x24 [tcm_fc]
[ 1357.238450]  [] ? ft_sess_free+0x1b/0x1b [tcm_fc]
[ 1357.238450]  [] rcu_process_callbacks+0x260/0x42a
[ 1357.238450]  [] __do_softirq+0x13a/0x26f
[ 1357.238450]  [] ? __schedule+0x65f/0x68e
[ 1357.238450]  [] run_ksoftirqd+0x29/0x62
[ 1357.238450]  [] smpboot_thread_fn+0x1a5/0x1aa
[ 1357.238450]  [] ? smpboot_unregister_percpu_thread+0x47/0x47
[ 1357.238450]  [] kthread+0xb1/0xb9
[ 1357.238450]  [] ? wait_for_common+0xbb/0x10a
[ 1357.238450]  [] ? __init_kthread_worker+0x59/0x59
[ 1357.238450]  [] ret_from_fork+0x7c/0xb0
[ 1357.238450]  [] ? __init_kthread_worker+0x59/0x59
[ 1417.440099]  rport-2:0-0: blocked FC remote port time out: removing rport

Signed-off-by: Yi Zou 
Cc: Open-FCoE 
Cc: Nicholas A. Bellinger 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: Don't return success from module_init() if setup fails

2012-11-17T21:14:20+00:00

commit 0d0f9dfb31e0a6c92063e235417b42df185b3275 upstream.

If the call to core_dev_release_virtual_lun0() fails, then nothing
sets ret to anything other than 0, so even though everything is
torn down and freed, target_core_init_configfs() will seem to succeed
and the module will be loaded.  Fix this by passing the return value
on up the chain.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: Fix ->data_length re-assignment bug with SCSI overflow

2012-10-02T16:47:23+00:00

commit 4c054ba63ad47ef244cfcfa1cea38134620a5bae upstream.

This patch fixes a long-standing bug with SCSI overflow handling
where se_cmd->data_length was incorrectly being re-assigned to
the larger CDB extracted allocation length, resulting in a number
of fabric level errors that would end up causing a session reset
in most cases.  So instead now:

 - Only re-assign se_cmd->data_length durining UNDERFLOW (to use the
   smaller value)
 - Use existing se_cmd->data_length for OVERFLOW (to use the smaller
   value)

This fix has been tested with the following CDB to generate an
SCSI overflow:

  sg_raw -r512 /dev/sdc 28 0 0 0 0 0 0 0 9 0

Tested using iscsi-target, tcm_qla2xxx, loopback and tcm_vhost fabric
ports.  Here is a bit more detail on each case:

 - iscsi-target: Bug with open-iscsi with overflow, sg_raw returns
                 -3584 bytes of data.
 - tcm_qla2xxx: Working as expected, returnins 512 bytes of data
 - loopback: sg_raw returns CHECK_CONDITION, from overflow rejection
             in transport_generic_map_mem_to_cmd()
 - tcm_vhost: Same as loopback

Reported-by: Roland Dreier 
Cc: Roland Dreier 
Cc: Christoph Hellwig 
Cc: Boaz Harrosh 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

tcm_fc: Resolve suspicious RCU usage warnings

2012-07-16T15:47:49+00:00

commit 863555be0c81558b1af277addcf68acb8f778860 upstream.

Use rcu_dereference_protected to tell rcu that the ft_lport_lock
is held during ft_lport_create. This resolved "suspicious RCU usage"
warnings when debugging options are turned on.

Signed-off-by: Mark Rustad 
Tested-by: Ross Brattain 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: Fix 16-bit target ports for SET TARGET PORT GROUPS emulation

2012-04-02T16:27:12+00:00

commit 33395fb8a13731c7ef7b175dbf5a4d8a6738fe6c upstream.

The old code did (MSB << 8) & 0xff, which always evaluates to 0.  Just use
get_unaligned_be16() so we don't have to worry about whether our open-coded
version is correct or not.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman