linux-toradex.git/drivers/thermal/cpu_cooling.c, branch v3.11 Linux kernel for Apalis and Colibri modules thermal: cpu_cooling: fix 'descend' check in get_property() 2013-05-28T06:49:31+00:00 Shawn Guo shawn.guo@linaro.org 2013-05-28T06:22:32+00:00 24c7a381720843f17efb42de81f7e85aefd6f616 The variable 'descend' is initialized as -1 in function get_property(), and will never get any chance to be updated by the following code. if (freq != CPUFREQ_ENTRY_INVALID && descend != -1) descend = !!(freq > table[i].frequency); This makes function get_property() return the wrong frequency for given cooling level if the frequency table is sorted in ascending. Fix it by correcting the 'descend' check in if-condition to 'descend == -1'. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
The variable 'descend' is initialized as -1 in function get_property(),
and will never get any chance to be updated by the following code.

	if (freq != CPUFREQ_ENTRY_INVALID && descend != -1)
		descend = !!(freq > table[i].frequency);

This makes function get_property() return the wrong frequency for given
cooling level if the frequency table is sorted in ascending.  Fix it
by correcting the 'descend' check in if-condition to 'descend == -1'.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: alignment improvements 2013-04-27T01:25:55+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:11+00:00 5fda7f680a44c65ce44fbe37f254b8a82f49d241 Improve code readiness by changing alignments so that they match open parenthesis, like checkpatch.pl --strict suggests. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Improve code readiness by changing alignments so that
they match open parenthesis, like checkpatch.pl --strict
suggests.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: remove checkpatch.pl warning 2013-04-27T01:25:51+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:06+00:00 ef5e2124ec3d54182bd826411d864e0e28fc00d4 Simple code style fix. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Simple code style fix.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: remove trailing blank line 2013-04-27T01:25:47+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:04+00:00 e45a6430025811c9ffc8932389adf5912f8ba4fd Remove unnecessary blank line. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Remove unnecessary blank line.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: align on open parenthesis 2013-04-27T01:25:43+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:03+00:00 d8892a01b13c8ea3ad74fb0c56beb96e92a2c65e Improve code readiness by remove checkpatch.pl warnings on get_property function. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Improve code readiness by remove checkpatch.pl warnings
on get_property function.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: standardize comment style 2013-04-27T01:25:38+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:02+00:00 1b9e35265903c2e0e484dc224e8f7de506e3353f There are at least three patterns for oneline comments in this file. This patch changes them to one single pattern Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
There are at least three patterns for oneline comments in this
file. This patch changes them to one single pattern

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: standardize end of function 2013-04-27T01:25:32+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:11:59+00:00 79491e53dcd73175473e3293a574f5e006b468be Just for code readiness, this patch makes all functions on this file to have a blank line before their returns. Now, some functions follow this pattern, and others will not have a blank line. So, this patch makes it a single pattern. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Just for code readiness, this patch makes all functions
on this file to have a blank line before their returns.
Now, some functions follow this pattern, and others will
not have a blank line. So, this patch makes it a single
pattern.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: remove trailing white spaces 2013-04-27T01:25:24+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:11:55+00:00 79d264016ac011b74497b553022d2fc45bf9d9f2 Remove unnecessary white spaces. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Remove unnecessary white spaces.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: remove unused symbols 2013-04-24T16:34:44+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:19+00:00 67d0b2a8267caa4e653714bec79013fa6b7dd508 The list is not needed so far. Thus removing it. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
The list is not needed so far. Thus removing it.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
thermal: cpu_cooling: remove not needed curl brackets 2013-04-24T16:34:43+00:00 Eduardo Valentin eduardo.valentin@ti.com 2013-04-17T17:12:18+00:00 2d9bf71c12be9caadd9a8276a78f3a3df8e9e852 Just for style purposes, remove extra curl brackets. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com> Signed-off-by: Zhang Rui <rui.zhang@intel.com> 
Just for style purposes, remove extra curl brackets.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>