linux-toradex.git/drivers/thermal/gov_step_wise.c, branch v6.7

thermal: core: Pass trip pointer to governor throttle callback

2023-10-20T17:26:37+00:00

Modify the governor .throttle() callback definition so that it takes a
trip pointer instead of a trip index as its second argument, adjust the
governors accordingly and update the core code invoking .throttle().

This causes the governors to become independent of the representation
of the list of trips in the thermal zone structure.

This change is not expected to alter the general functionality.

Signed-off-by: Rafael J. Wysocki 
Reviewed-by: Daniel Lezcano

thermal: gov_step_wise: Fold update_passive_instance() into its caller

2023-10-20T17:26:37+00:00

Fold update_passive_instance() into thermal_zone_trip_update() that is
its only caller so as to make the code in question easier to follow.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki 
Acked-by: Daniel Lezcano 
Reviewed-by: Lukasz Luba

thermal: core: Store trip pointer in struct thermal_instance

2023-09-28T10:55:29+00:00

Replace the integer trip number stored in struct thermal_instance with
a pointer to the relevant trip and adjust the code using the structure
in question accordingly.

The main reason for making this change is to allow the trip point to
cooling device binding code more straightforward, as illustrated by
subsequent modifications of the ACPI thermal driver, but it also helps
to clarify the overall design and allows the governor code overhead to
be reduced (through subsequent modifications).

The only case in which it adds complexity is trip_point_show() that
needs to walk the trips[] table to find the index of the given trip
point, but this is not a critical path and the interface that
trip_point_show() belongs to is problematic anyway (for instance, it
doesn't cover the case when the same cooling devices is associated
with multiple trip points).

This is a preliminary change and the affected code will be refined by
a series of subsequent modifications of thermal governors, the core and
the ACPI thermal driver.

The general functionality is not expected to be affected by this change.

Signed-off-by: Rafael J. Wysocki 
Reviewed-by: Daniel Lezcano

thermal: gov_step_wise: Adjust code logic to match comment

2023-04-27T17:17:11+00:00

For the algorithm of choosing the next target state in step_wise
governor, the code does the right thing but is implemented in a
way different from what the comment describes. And this hurts the code
readability.

As the logic in the comment is simpler, adjust the code logic to align
with the comment.

No functional change.

Signed-off-by: Zhang Rui 
[ rjw: Subject edit ]
Signed-off-by: Rafael J. Wysocki

thermal: gov_step_wise: Delete obsolete comment

2023-04-27T17:17:11+00:00

Commit 4102c4042a33 ("thermal/core: Remove DROP_FULL and RAISE_FULL")
removes support for THERMAL_TREND_RAISE_FULL/DROP_FULL but leaves the
comment unchanged.

Delete the obsolte comment about THERMAL_TREND_RAISE_FULL/DROP_FULL.

Fixes: 4102c4042a33 ("thermal/core: Remove DROP_FULL and RAISE_FULL")
Signed-off-by: Zhang Rui 
Signed-off-by: Rafael J. Wysocki

thermal/core: Relocate the traces definition in thermal directory

2023-04-01T18:51:45+00:00

The traces are exported but only local to the thermal core code. On
the other side, the traces take the thermal zone device structure as
argument, thus they have to rely on the exported thermal.h header
file. As we want to move the structure to the private thermal core
header, first we have to relocate those traces to the same place as
many drivers do.

Cc: Steven Rostedt 
Suggested-by: Steven Rostedt 
Signed-off-by: Daniel Lezcano 
Reviewed-by: Steven Rostedt (Google) 
Link: https://lore.kernel.org/r/20230307133735.90772-2-daniel.lezcano@linaro.org

thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions

2023-01-06T13:14:47+00:00

The governors are using the ops->get_trip_* functions, Replace these
calls with thermal_zone_get_trip().

Signed-off-by: Daniel Lezcano 
Reviewed-by: Zhang Rui 
Reviewed-by: Lukasz Luba  # IPA
Acked-by: Rafael J. Wysocki 
Link: https://lore.kernel.org/r/20221003092602.1323944-5-daniel.lezcano@linaro.org

thermal/core: Move the thermal zone lock out of the governors

2022-08-17T12:09:39+00:00

All the governors throttling ops are taking/releasing the lock at the
beginning and the end of the function.

We can move the mutex to the throttling call site instead.

Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20220805153834.2510142-4-daniel.lezcano@linaro.org

thermal/governors: Group the thermal zone lock inside the throttle function

2022-08-17T12:09:39+00:00

The thermal zone lock is taken in the different places in the
throttling path.

At the first glance it does not hurt to move them at the beginning and
the end of the 'throttle' function. That will allow a consolidation of
the lock in the next following changes.

Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20220805153834.2510142-3-daniel.lezcano@linaro.org

thermal/core: Remove DROP_FULL and RAISE_FULL

2022-07-28T15:29:47+00:00

The trends DROP_FULL and RAISE_FULL are not used and were never used
in the past AFAICT. Remove these conditions as they seems to not be
handled anywhere.

Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20220629151012.3115773-2-daniel.lezcano@linaro.org
Signed-off-by: Daniel Lezcano