linux-toradex.git/drivers/tty/moxa.c, branch v5.5

moxa: switch to ->[sg]et_serial()

2018-10-13T04:50:32+00:00

Pointless dead assignments in moxa_set_serial_info() killed off;
they would've been a bug, if not for the fact that user-settable
flags had never been used in that driver.  Bogus from day 1,
though...

Signed-off-by: Al Viro

tty: moxa: Add support for CMSPAR

2017-11-28T14:32:33+00:00

The mode constants are taken from the GPL-2.0+ driver available
in the driver section of the Moxa homepage.

It is tested on a C320Turbo PCI card per logic analyzer and
per a device which requires 9 bit character communication.

The vendors driver supports CMSPAR unconditionally, so that all
other available firmware versions seems to support mark/space
parity modes as well.

Signed-off-by: Lars Kanis 
Signed-off-by: Greg Kroah-Hartman

treewide: Switch DEFINE_TIMER callbacks to struct timer_list *

2017-11-21T23:57:05+00:00

This changes all DEFINE_TIMER() callbacks to use a struct timer_list
pointer instead of unsigned long. Since the data argument has already been
removed, none of these callbacks are using their argument currently, so
this renames the argument to "unused".

Done using the following semantic patch:

@match_define_timer@
declarer name DEFINE_TIMER;
identifier _timer, _callback;
@@

 DEFINE_TIMER(_timer, _callback);

@change_callback depends on match_define_timer@
identifier match_define_timer._callback;
type _origtype;
identifier _origarg;
@@

 void
-_callback(_origtype _origarg)
+_callback(struct timer_list *unused)
 { ... }

Signed-off-by: Kees Cook

Merge tag 'tty-4.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2017-11-14T05:05:31+00:00

Pull tty/serial updates from Greg KH:
 "Here is the big tty/serial driver pull request for 4.15-rc1.

  Lots of serial driver updates in here, some small vt cleanups, and a
  raft of SPDX and license boilerplate cleanups, messing up the diffstat
  a bit.

  Nothing major, with no realy functional changes except better hardware
  support for some platforms.

  All of these have been in linux-next for a while with no reported
  issues"

* tag 'tty-4.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: (110 commits)
  tty: ehv_bytechan: fix spelling mistake
  tty: serial: meson: allow baud-rates lower than 9600
  serial: 8250_fintek: Fix crash with baud rate B0
  serial: 8250_fintek: Disable delays for ports != 0
  serial: 8250_fintek: Return -EINVAL on invalid configuration
  tty: Remove redundant license text
  tty: serdev: Remove redundant license text
  tty: hvc: Remove redundant license text
  tty: serial: Remove redundant license text
  tty: add SPDX identifiers to all remaining files in drivers/tty/
  tty: serial: jsm: remove redundant pointer ts
  tty: serial: jsm: add space before the open parenthesis '('
  tty: serial: jsm: fix coding style
  tty: serial: jsm: delete space between function name and '('
  tty: serial: jsm: add blank line after declarations
  tty: serial: jsm: change the type of local variable
  tty: serial: imx: remove dead code imx_dma_rxint
  tty: serial: imx: disable ageing timer interrupt if dma in use
  serial: 8250: fix potential deadlock in rs485-mode
  serial: m32r_sio: Drop redundant .data assignment
  ...

tty: Remove redundant license text

2017-11-08T12:08:12+00:00

Now that the SPDX tag is in all tty files, that identifies the license
in a specific and legally-defined manner.  So the extra GPL text wording
can be removed as it is no longer needed at all.

This is done on a quest to remove the 700+ different ways that files in
the kernel describe the GPL license text.  And there's unneeded stuff
like the address (sometimes incorrect) for the FSF which is never
needed.

No copyright headers or other non-license-description text was removed.

Cc: Jiri Slaby 
Cc: James Hogan 
Signed-off-by: Greg Kroah-Hartman

tty: add SPDX identifiers to all remaining files in drivers/tty/

2017-11-08T12:08:12+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Update the drivers/tty files files with the correct SPDX license
identifier based on the license text in the file itself.  The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Jiri Slaby 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Chris Metcalf 
Cc: Jiri Kosina 
Cc: David Sterba 
Cc: James Hogan 
Cc: Rob Herring 
Cc: Eric Anholt 
Cc: Stefan Wahren 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: "James E.J. Bottomley" 
Cc: Helge Deller 
Cc: Joachim Eastwood 
Cc: Matthias Brugger 
Cc: Masahiro Yamada 
Cc: Tobias Klauser 
Cc: Russell King 
Cc: Vineet Gupta 
Cc: Richard Genoud 
Cc: Alexander Shiyan 
Cc: Baruch Siach 
Cc: "Maciej W. Rozycki" 
Cc: "Uwe Kleine-König" 
Cc: Pat Gefre 
Cc: "Guilherme G. Piccoli" 
Cc: Jason Wessel 
Cc: Vladimir Zapolskiy 
Cc: Sylvain Lemieux 
Cc: Carlo Caione 
Cc: Kevin Hilman 
Cc: Liviu Dudau 
Cc: Sudeep Holla 
Cc: Lorenzo Pieralisi 
Cc: Andy Gross 
Cc: David Brown 
Cc: "Andreas Färber" 
Cc: Kevin Cernekee 
Cc: Laxman Dewangan 
Cc: Thierry Reding 
Cc: Jonathan Hunter 
Cc: Barry Song 
Cc: Patrice Chotard 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Timur Tabi 
Cc: Tony Prisk 
Cc: Michal Simek 
Cc: "Sören Brinkmann" 
Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-05T13:01:20+00:00

Drop the arguments from the macro and adjust all callers with the
following script:

  perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \
    $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h)

Signed-off-by: Kees Cook 
Acked-by: Geert Uytterhoeven  # for m68k parts
Acked-by: Guenter Roeck  # for watchdog parts
Acked-by: David S. Miller  # for networking parts
Acked-by: Greg Kroah-Hartman 
Acked-by: Kalle Valo  # for wireless parts
Acked-by: Arnd Bergmann 
Cc: linux-mips@linux-mips.org
Cc: Petr Mladek 
Cc: Benjamin Herrenschmidt 
Cc: Lai Jiangshan 
Cc: Sebastian Reichel 
Cc: Kalle Valo 
Cc: Paul Mackerras 
Cc: Pavel Machek 
Cc: linux1394-devel@lists.sourceforge.net
Cc: Chris Metcalf 
Cc: linux-s390@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: "James E.J. Bottomley" 
Cc: Wim Van Sebroeck 
Cc: Michael Ellerman 
Cc: Ursula Braun 
Cc: Viresh Kumar 
Cc: Harish Patil 
Cc: Stephen Boyd 
Cc: Michael Reed 
Cc: Manish Chopra 
Cc: Len Brown 
Cc: Arnd Bergmann 
Cc: linux-pm@vger.kernel.org
Cc: Heiko Carstens 
Cc: Tejun Heo 
Cc: Julian Wiedmann 
Cc: John Stultz 
Cc: Mark Gross 
Cc: linux-watchdog@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: "Martin K. Petersen" 
Cc: Greg Kroah-Hartman 
Cc: "Rafael J. Wysocki" 
Cc: Oleg Nesterov 
Cc: Ralf Baechle 
Cc: Stefan Richter 
Cc: Guenter Roeck 
Cc: netdev@vger.kernel.org
Cc: Martin Schwidefsky 
Cc: Andrew Morton 
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Sudip Mukherjee 
Link: https://lkml.kernel.org/r/1507159627-127660-11-git-send-email-keescook@chromium.org
Signed-off-by: Thomas Gleixner

tty: moxa: constify pci_device_id.

2017-07-30T14:35:28+00:00

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by  work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  14201	    656	   1760	  16617	   40e9	drivers/tty/moxa.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  14329	    528	   1760	  16617	   40e9	drivers/tty/moxa.o

Signed-off-by: Arvind Yadav 
Signed-off-by: Greg Kroah-Hartman

Annotate hardware config module parameters in drivers/tty/

2017-04-20T11:02:32+00:00

When the kernel is running in secure boot mode, we lock down the kernel to
prevent userspace from modifying the running kernel image.  Whilst this
includes prohibiting access to things like /dev/mem, it must also prevent
access by means of configuring driver modules in such a way as to cause a
device to access or modify the kernel image.

To this end, annotate module_param* statements that refer to hardware
configuration and indicate for future reference what type of parameter they
specify.  The parameter parser in the core sees this information and can
skip such parameters with an error message if the kernel is locked down.
The module initialisation then runs as normal, but just sees whatever the
default values for those parameters is.

Note that we do still need to do the module initialisation because some
drivers have viable defaults set in case parameters aren't specified and
some drivers support automatic configuration (e.g. PNP or PCI) in addition
to manually coded parameters.

This patch annotates drivers in drivers/tty/.

Suggested-by: Alan Cox 
Signed-off-by: David Howells 
Acked-by: Greg Kroah-Hartman 
cc: Jiri Slaby 
cc: linux-serial@vger.kernel.org

Replace with globally

2016-12-24T19:46:01+00:00

This was entirely automated, using the script by Al:

  PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*'
  sed -i -e "s!$PATT!#include !" \
        $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h)

to do the replacement at the end of the merge window.

Requested-by: Al Viro 
Signed-off-by: Linus Torvalds