linux-toradex.git/drivers/tty/n_gsm.c, branch v5.8-rc2

tty: n_gsm: Fix bogus i++ in gsm_data_kick

2020-05-19T14:19:54+00:00

When submitting the previous fix "tty: n_gsm: Fix waking up upper tty
layer when room available". It was suggested to switch from a while to
a for loop, but when doing it, there was a remaining bogus i++.

This patch removes this i++ and also reorganizes the code making it more
compact.

Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Signed-off-by: Gregory CLEMENT 
Link: https://lore.kernel.org/r/20200518084517.2173242-3-gregory.clement@bootlin.com
Signed-off-by: Greg Kroah-Hartman

tty: n_gsm: Remove unnecessary test in gsm_print_packet()

2020-05-19T14:19:54+00:00

If the length is zero then the print_hex_dump_bytes won't output
anything, so testing the length before the call is unnecessary.

Signed-off-by: Gregory CLEMENT 
Link: https://lore.kernel.org/r/20200518084517.2173242-2-gregory.clement@bootlin.com
Signed-off-by: Greg Kroah-Hartman

tty: n_gsm: Fix waking up upper tty layer when room available

2020-05-15T11:37:32+00:00

Warn the upper layer when n_gms is ready to receive data
again. Without this the associated virtual tty remains blocked
indefinitely.

Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Signed-off-by: Gregory CLEMENT 
Link: https://lore.kernel.org/r/20200512115323.1447922-4-gregory.clement@bootlin.com
Signed-off-by: Greg Kroah-Hartman

tty: n_gsm: Fix SOF skipping

2020-05-15T11:37:32+00:00

For at least some modems like the TELIT LE910, skipping SOF makes
transfers blocking indefinitely after a short amount of data
transferred.

Given the small improvement provided by skipping the SOF (just one
byte on about 100 bytes), it seems better to completely remove this
"feature" than make it optional.

Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Signed-off-by: Gregory CLEMENT 
Link: https://lore.kernel.org/r/20200512115323.1447922-3-gregory.clement@bootlin.com
Signed-off-by: Greg Kroah-Hartman

tty: n_gsm: Improve debug output

2020-05-15T11:37:32+00:00

Use appropriate print helpers for debug messages.

Signed-off-by: Gregory CLEMENT 
Link: https://lore.kernel.org/r/20200512115323.1447922-2-gregory.clement@bootlin.com
Signed-off-by: Greg Kroah-Hartman

n_gsm: switch escape to bool

2020-02-19T11:46:48+00:00

gsm_mux->escape is used as a bool, so treat it as such.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20200219084949.28074-10-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

n_gsm: switch constipated to bool

2020-02-19T11:46:48+00:00

Both gsm_dlci->constipated and gsm_mux->constipated are used as bools,
so treat them as such.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20200219084949.28074-9-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

n_gsm: switch throttled to bool

2020-02-19T11:46:48+00:00

gsm_dlci->throttled is used as a bool, so treat it as such.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20200219084949.28074-8-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

n_gsm: switch dead to bool

2020-02-19T11:46:48+00:00

Both gsm_dlci->dead and gsm_mux->dead are used as bools, so treat them
as such.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20200219084949.28074-7-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

n_gsm: add missing \n to prints

2020-02-19T11:46:48+00:00

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20200219084949.28074-6-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman