linux-toradex.git/drivers/tty/serial/apbuart.c, branch v5.4

tty: add SPDX identifiers to all remaining files in drivers/tty/

2017-11-08T12:08:12+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Update the drivers/tty files files with the correct SPDX license
identifier based on the license text in the file itself.  The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Jiri Slaby 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Chris Metcalf 
Cc: Jiri Kosina 
Cc: David Sterba 
Cc: James Hogan 
Cc: Rob Herring 
Cc: Eric Anholt 
Cc: Stefan Wahren 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: "James E.J. Bottomley" 
Cc: Helge Deller 
Cc: Joachim Eastwood 
Cc: Matthias Brugger 
Cc: Masahiro Yamada 
Cc: Tobias Klauser 
Cc: Russell King 
Cc: Vineet Gupta 
Cc: Richard Genoud 
Cc: Alexander Shiyan 
Cc: Baruch Siach 
Cc: "Maciej W. Rozycki" 
Cc: "Uwe Kleine-König" 
Cc: Pat Gefre 
Cc: "Guilherme G. Piccoli" 
Cc: Jason Wessel 
Cc: Vladimir Zapolskiy 
Cc: Sylvain Lemieux 
Cc: Carlo Caione 
Cc: Kevin Hilman 
Cc: Liviu Dudau 
Cc: Sudeep Holla 
Cc: Lorenzo Pieralisi 
Cc: Andy Gross 
Cc: David Brown 
Cc: "Andreas Färber" 
Cc: Kevin Cernekee 
Cc: Laxman Dewangan 
Cc: Thierry Reding 
Cc: Jonathan Hunter 
Cc: Barry Song 
Cc: Patrice Chotard 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Timur Tabi 
Cc: Tony Prisk 
Cc: Michal Simek 
Cc: "Sören Brinkmann" 
Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

serial: apbuart: constify uart_ops structures

2017-08-28T18:51:21+00:00

These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

tty: serial: apbuart: Fix module autoload for OF platform driver

2015-10-04T18:09:21+00:00

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt 
Signed-off-by: Greg Kroah-Hartman

tty: constify of_device_id array

2015-03-26T21:49:10+00:00

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick 
Acked-by: Peter Korsgaard 
Acked-by: Timur Tabi 
Acked-by: Patrice Chotard 
Signed-off-by: Greg Kroah-Hartman

tty: serial: drop owner assignment from platform_drivers

2014-10-20T14:21:45+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

serial: treewide: Remove empty implementations of enable_ms()

2014-07-10T00:29:38+00:00

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

tty: serial: apbuart: drop uart_port->lock before calling tty_flip_buffer_push()

2013-08-27T23:17:33+00:00

The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.

Crash looks like this (produced with samsung.c driver):

-----
[] (unwind_backtrace+0x0/0xf8) from [] (show_stack+0x10/0x14)
[] (show_stack+0x10/0x14) from [] (dump_stack+0x6c/0xac)
[] (dump_stack+0x6c/0xac) from [] (do_raw_spin_unlock+0xc4/0xd8)
[] (do_raw_spin_unlock+0xc4/0xd8) from [] (_raw_spin_unlock_irqrestore+0xc/0)
[] (_raw_spin_unlock_irqrestore+0xc/0x38) from [] (s3c24xx_serial_rx_chars+0)
[] (s3c24xx_serial_rx_chars+0x12c/0x260) from [] (s3c64xx_serial_handle_irq+)
[] (s3c64xx_serial_handle_irq+0x48/0x60) from [] (handle_irq_event_percpu+0x)
[] (handle_irq_event_percpu+0x50/0x194) from [] (handle_irq_event+0x3c/0x5c)
[] (handle_irq_event+0x3c/0x5c) from [] (handle_fasteoi_irq+0x80/0x13c)
[] (handle_fasteoi_irq+0x80/0x13c) from [] (generic_handle_irq+0x20/0x30)
[] (generic_handle_irq+0x20/0x30) from [] (handle_IRQ+0x38/0x94)
[] (handle_IRQ+0x38/0x94) from [] (gic_handle_irq+0x34/0x68)
[] (gic_handle_irq+0x34/0x68) from [] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:                                     00000000 00000000 0000166e 00000000
df80: c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0: 00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[] (__irq_svc+0x40/0x70) from [] (arch_cpu_idle+0x28/0x30)
[] (arch_cpu_idle+0x28/0x30) from [] (cpu_startup_entry+0x5c/0x148)
[] (cpu_startup_entry+0x5c/0x148) from [] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
 lock: s3c24xx_serial_ports+0x1d8/0x370, .magic: dead4ead, .owner: /-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted 3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[] (unwind_backtrace+0x0/0xf8) from [] (show_stack+0x10/0x14)
[] (show_stack+0x10/0x14) from [] (dump_stack+0x6c/0xac)
[] (dump_stack+0x6c/0xac) from [] (do_raw_spin_lock+0x100/0x17c)
[] (do_raw_spin_lock+0x100/0x17c) from [] (_raw_spin_lock_irqsave+0x20/0x28)
[] (_raw_spin_lock_irqsave+0x20/0x28) from [] (uart_start+0x18/0x34)
[] (uart_start+0x18/0x34) from [] (__receive_buf+0x4b4/0x738)
[] (__receive_buf+0x4b4/0x738) from [] (n_tty_receive_buf2+0x30/0x98)
[] (n_tty_receive_buf2+0x30/0x98) from [] (flush_to_ldisc+0xec/0x138)
[] (flush_to_ldisc+0xec/0x138) from [] (process_one_work+0xfc/0x348)
[] (process_one_work+0xfc/0x348) from [] (worker_thread+0x138/0x37c)
[] (worker_thread+0x138/0x37c) from [] (kthread+0xa4/0xb0)
[] (kthread+0xa4/0xb0) from [] (ret_from_fork+0x14/0x3c)
-----

Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.

Similar stuff was already done for few other drivers in the past, like:

commit 2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner 
Date:   Tue May 29 21:53:50 2007 +0100

    [ARM] 4417/1: Serial: Fix AMBA drivers locking

Signed-off-by: Viresh Kumar 
Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_flip_buffer_push

2013-01-16T06:30:15+00:00

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

Now, the one where most of tty_port_tty_get gets removed:
tty_flip_buffer_push.

IOW we also closed all the races in drivers not using tty_port_tty_get
at all yet.

Also we move tty_flip_buffer_push declaration from include/linux/tty.h
to include/linux/tty_flip.h to all others while we are changing it
anyway.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: remove use of __devinit

2012-11-21T23:22:52+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Jiri Slaby 
Cc: Alan Cox 
Cc: Lucas Tavares 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Tony Prisk 
Acked-by: Tobias Klauser 
Acked-by: Nicolas Ferre 
Signed-off-by: Greg Kroah-Hartman

apbuart: fix section mismatch warning

2011-12-27T21:33:13+00:00

Fix following warnings:

WARNING: drivers/tty/serial/built-in.o(.text+0x7370): Section mismatch in reference from the function grlib_apbuart_configure() to the variable .init.data:apbuart_match
The function grlib_apbuart_configure() references
the variable __initdata apbuart_match.
This is often because grlib_apbuart_configure lacks a __initdata
annotation or the annotation of apbuart_match is wrong.

+ 3 more warnings like this.

There is no guarantee that grlib_apbuart_of_driver.of_match_table
is only used at __init time - so drop the __initdata annotation.

grlib_apbuart_configure() is only used during __init so add __init
to this method too.

Signed-off-by: Sam Ravnborg 
Cc: Daniel Hellstrom 
Cc: Greg Kroah-Hartman 
Signed-off-by: David S. Miller