linux-toradex.git/drivers/tty/serial/max310x.c, branch v4.2-rc5

drivers/max310: Use the rs485 functions on serial_core

2014-11-06T23:00:15+00:00

In order to unify all the rs485 ioctl handling
Use the implementation of TIOC[GS]RS485 ioctl handling on serial_core.

Reviewed-by: Alan Cox 
Cc: Jiri Slaby 
Signed-off-by: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

serial/max310x: Remove obsolete #ifset TIOC[SG]RS485

2014-11-06T03:29:05+00:00

Commit e676253b19b2 ("serial/8250: Add support for RS485 IOCTLs") added
references to TIOC[SG]RS48 on 8250_core.c. This change triggered the
need to define them in all the arches that uses tty/serial.

This made #ifdef TIOC[SG]RS48 obsolete.

Cc: Greg Kroah-Hartman 
Cc: Jiri Slaby 
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

max310x: max3109_detect should use indirect addressing in SPI mode for REVID register

2014-11-06T03:24:07+00:00

This patch allows to read the REV_ID register in SPI mode and consequently
to properly detect the max3109. Indeed in SPI mode, this register is only
accessible by using indirect addressing.

Signed-off-by: Gregory Hermant 
Signed-off-by: Greg Kroah-Hartman

driver:gpio remove all usage of gpio_remove retval in driver

2014-09-18T18:03:10+00:00

this remove all reference to gpio_remove retval in all driver
except pinctrl and gpio. the same thing is done for gpio and
pinctrl in two different patches.

Signed-off-by: Abdoulaye Berthe 
Acked-by: Michael Büsch 
Acked-by: Dmitry Torokhov 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Tomi Valkeinen 
Signed-off-by: Linus Walleij

serial: treewide: Remove empty implementations of enable_ms()

2014-07-10T00:29:38+00:00

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

serial: Fix IGNBRK handling

2014-06-19T20:04:52+00:00

If IGNBRK is set without either BRKINT or PARMRK set, some uart
drivers send a 0x00 byte for BREAK without the TTYBREAK flag to the
line discipline, when it should send either nothing or the TTYBREAK flag
set. This happens because the read_status_mask masks out the BI
condition, which uart_insert_char() then interprets as a normal 0x00 byte.

SUS v3 is clear regarding the meaning of IGNBRK; Section 11.2.2, General
Terminal Interface - Input Modes, states:
  "If IGNBRK is set, a break condition detected on input shall be ignored;
   that is, not put on the input queue and therefore not read by any
   process."

Fix read_status_mask to include the BI bit if IGNBRK is set; the
lsr status retains the BI bit if a BREAK is recv'd, which is
subsequently ignored in uart_insert_char() when masked with the
ignore_status_mask.

Affected drivers:
8250 - all
serial_txx9
mfd
amba-pl010
amba-pl011
atmel_serial
bfin_uart
dz
ip22zilog
max310x
mxs-auart
netx-serial
pnx8xxx_uart
pxa
sb1250-duart
sccnxp
serial_ks8695
sirfsoc_uart
st-asc
vr41xx_siu
zs
sunzilog
fsl_lpuart
sunsab
ucc_uart
bcm63xx_uart
sunsu
efm32-uart
pmac_zilog
mpsc
msm_serial
m32r_sio

Unaffected drivers:
omap-serial
rp2
sa1100
imx
icom

Annotated for fixes:
altera_uart
mcf

Drivers without break detection:
21285
xilinx-uartps
altera_jtaguart
apbuart
arc-uart
clps711x
max3100
uartlite
msm_serial_hs
nwpserial
lantiq
vt8500_serial

Unknown:
samsung
mpc52xx_uart
bfin_sport_uart
cpm_uart/core

Fixes: Bugzilla #71651, '8250_core.c incorrectly handles IGNBRK flag'
Reported-by: Ivan 
Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

serial: max310x: Add missing #include

2014-03-17T23:13:23+00:00

cris allmodconfig:

drivers/tty/serial/max310x.c: In function 'max310x_ioctl':
drivers/tty/serial/max310x.c:885:3: error: implicit declaration of function 'copy_from_user' [-Werror=implicit-function-declaration]
drivers/tty/serial/max310x.c:916:3: error: implicit declaration of function 'copy_to_user' [-Werror=implicit-function-declaration]

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Greg Kroah-Hartman

serial: max310x: Fix sparse warnings

2014-02-15T20:16:21+00:00

sparse warnings: (new ones prefixed by >>)

>> drivers/tty/serial/max310x.c:906:45: sparse: incorrect type in argument 2 (different address spaces)
 drivers/tty/serial/max310x.c:906:45: expected void const [noderef] *from
 drivers/tty/serial/max310x.c:906:45: got struct serial_rs485 *
>> drivers/tty/serial/max310x.c:938:35: sparse: incorrect type in argument 1 (different address spaces)
 drivers/tty/serial/max310x.c:938:35: expected void [noderef] *to
 drivers/tty/serial/max310x.c:938:35: got struct serial_rs485 *

Reported-by: kbuild test robot 
Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

serial: max310x: Fix build error

2014-02-13T23:20:13+00:00

This is a temporary solution to fix following issue:
config: make ARCH=alpha allyesconfig

All error/warnings:

 drivers/tty/serial/max310x.c: In function 'max310x_ioctl':
>> drivers/tty/serial/max310x.c:905:7: error: 'TIOCSRS485' undeclared (first use in this function)
 drivers/tty/serial/max310x.c:905:7: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/tty/serial/max310x.c:906:3: error: implicit declaration of function 'copy_from_user' [-Werror=implicit-function-declaration]
>> drivers/tty/serial/max310x.c:929:7: error: 'TIOCGRS485' undeclared (first use in this function)
>> drivers/tty/serial/max310x.c:938:3: error: implicit declaration of function 'copy_to_user' [-Werror=implicit-function-declaration]
 cc1: some warnings being treated as errors

Reported-by: kbuild test robot 
Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

Revert "serial: max310x: Fix build error"

2014-02-13T23:18:57+00:00

This reverts commit e3c6ea9b1b81b87de96c01d5d37764009d546636 as it
didn't help anything, and caused more problems than expected.

Reported-by: kbuild test robot 
Cc: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman