linux-toradex.git/drivers/tty/serial/mpc52xx_uart.c, branch v3.15-rc1

serial: mpc512x: setup the PSC FIFO clock as well

2014-01-12T17:53:05+00:00

prepare and enable the FIFO clock upon PSC FIFO initialization,
check for and propagage errors when enabling the PSC FIFO clock,
disable and unprepare the FIFO clock upon PSC FIFO uninitialization

devm_{get,put}_clk() doesn't apply here, as the SoC provides a
single FIFO component which is shared among several PSC components,
thus the FIFO isn't associated with a device (while the PSCs are)

provide a fallback clock lookup approach in case the OF based clock
lookup for the PSC FIFO fails, this allows for successful operation in
the presence of an outdated device tree which lacks clock specs

Cc: Greg Kroah-Hartman 
Cc: Jiri Slaby 
Cc: linux-serial@vger.kernel.org
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Gerhard Sittig 
Signed-off-by: Anatolij Gustschin

serial: mpc512x: adjust for OF based clock lookup

2014-01-12T17:53:04+00:00

after device tree based clock lookup became available, the peripheral
driver need no longer construct clock names which include the PSC index,
remove the "psc%d_mclk" template and unconditionally use 'mclk'

acquire and release the "ipg" clock item for register access as well

Cc: Greg Kroah-Hartman 
Cc: Jiri Slaby 
Cc: linux-serial@vger.kernel.org
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Gerhard Sittig 
Signed-off-by: Anatolij Gustschin

serial: mpc52xx: remove reference to .set_wake()

2013-10-16T20:16:19+00:00

This callback is gone and not coming back, so will not be
supported later.

Cc: Gerhard Sittig 
Cc: Anatolij Gustschin 
Signed-off-by: Linus Walleij 
Signed-off-by: Greg Kroah-Hartman

serial: mpc512x: Remove casting the return value which is a void pointer

2013-09-26T21:29:59+00:00

Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.

Signed-off-by: Jingoo Han 
Acked-by: Vineet Gupta 
Signed-off-by: Greg Kroah-Hartman

serial: mpc512x: cleanup clock API use

2013-08-21T19:37:38+00:00

cleanup the clock API use of the UART driver which is shared among the
MPC512x and the MPC5200 platforms
- get, prepare, and enable the MCLK during port allocation; disable,
  unprepare and put the MCLK upon port release; hold a reference to the
  clock over the period of use; check for and propagate enable errors
- fix a buffer overflow for clock names with two digit PSC index numbers
- stick with the PPC_CLOCK 'psc%d_mclk' name for clock lookup, only
  switch to a fixed string later after device tree based clock lookup
  will have become available

to achieve support for MPC512x which is neutral to MPC5200, the
modification was done as follows
- introduce "clock alloc" and "clock release" routines in addition to
  the previous "clock enable/disable" routine in the psc_ops struct
- make the clock allocation a part of the port request (resource
  allocation), and make clock release a part of the port release, such
  that essential resources get allocated early
- just enable/disable the clock from within the .clock() callback
  without any allocation or preparation as the former implementation
  did, since this routine is called from within the startup and shutdown
  callbacks
- all of the above remains a NOP for the MPC5200 platform (no callbacks
  are provided on that platform)
- implementation note: the clock gets enabled upon allocation already
  just in case the clock is not only required for bitrate generation but
  for register access as well

Signed-off-by: Gerhard Sittig 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Anatolij Gustschin

serial/mpc52xx_uart: fix kernel panic when system reboot

2013-06-17T19:49:43+00:00

This bug appear when a second PSC based driver appends an interrupt
routine to the FIFO controller shared interrupt (like spi-mpc512x-psc).
When reboot, uart_shutdown() remove the serial console interrupt handler
while spi-mpc512x-psc isr is still activate and cause the following kernel
panic:

The system is going down for reboot NOW!rpc (ttyPSC0) (Mon Jun 10 12:26:07 20
INIT: Sending processirq 40: nobody cared (try booting with the "irqpoll" option)
CPU: 0 PID: 0 Comm: swapper Not tainted 3.10.0-rc4-next-20130607-00001-ga0bceb3-dirty #5
Call Trace:
[cfff9f00] [c0007910] show_stack+0x48/0x150 (unreliable)
[cfff9f40] [c005ae60] __report_bad_irq.isra.6+0x34/0xe0
[cfff9f60] [c005b194] note_interrupt+0x214/0x26c
[cfff9f90] [c00590fc] handle_irq_event_percpu+0xd0/0x1bc
[cfff9fd0] [c005921c] handle_irq_event+0x34/0x54
[cfff9fe0] [c005b8f4] handle_level_irq+0x90/0xf4
[cfff9ff0] [c000cb98] call_handle_irq+0x18/0x28
[c050dd60] [c000575c] do_IRQ+0xcc/0x124
[c050dd90] [c000eb04] ret_from_except+0x0/0x14

Signed-off-by: Greg Kroah-Hartman

serial/mpc52xx_uart: add MPC5125 PSC support

2013-06-03T17:22:35+00:00

Add MPC5125 PSC register layout structure, MPC5125 specific
psc_ops function set and the compatible string.

Signed-off-by: Vladimir Ermakov 
Signed-off-by: Matteo Facchinetti 
Signed-off-by: Anatolij Gustschin 
Signed-off-by: Greg Kroah-Hartman

serial/mpc52xx_uart: prepare for adding MPC5125 PSC UART support

2013-06-03T17:22:35+00:00

MPC5125 PSC controller has different register layout than MPC5121.
To support MPC5125 PSC in this driver we have to provide further
psc_ops functions for SoC specific register accesses.

Add new register access functions to the psc_ops structure and
provide MPC52xx and MPC512x specific implementation for them.
Then replace remaining direct register accesses in the driver by
appropriate psc_ops function calls. The subsequent patch can now
add MPC5125 specific set of psc_ops functions.

Signed-off-by: Vladimir Ermakov 
Signed-off-by: Matteo Facchinetti 
Signed-off-by: Anatolij Gustschin 
Signed-off-by: Greg Kroah-Hartman

serial: use platform_{get,set}_drvdata()

2013-06-03T17:21:33+00:00

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Jingoo Han 
Signed-off-by: Greg Kroah-Hartman

Merge 3.10-rc3 into tty-next

2013-05-27T01:57:53+00:00

We want these fixes.

Signed-off-by: Greg Kroah-Hartman