linux-toradex.git/drivers/tty/serial/sccnxp.c, branch v6.0-rc4

serial: make uart_console_write->putchar()'s character an unsigned char

2022-03-03T14:06:31+00:00

Currently, uart_console_write->putchar's second parameter (the
character) is of type int. It makes little sense, provided uart_console_write()
accepts the input string as "const char *s" and passes its content -- the
characters -- to putchar(). So switch the character's type to unsigned
char.

We don't use char as that is signed on some platforms. That would cause
troubles for drivers which (implicitly) cast the char to u16 when
writing to the device. Sign extension would happen in that case and the
value written would be completely different to the provided char. DZ is
an example of such a driver -- on MIPS, it uses u16 for dz_out in
dz_console_putchar().

Note we do the char -> uchar conversion implicitly in
uart_console_write(). Provided we do not change size of the data type,
sign extension does not happen there, so the problem is void.

This makes the types consistent and unified with the rest of the uart
layer, which uses unsigned char in most places already. One exception is
xmit_buf, but that is going to be converted later.

Cc: Paul Cercueil 
Cc: Tobias Klauser 
Cc: Russell King 
Cc: Vineet Gupta 
Cc: Nicolas Ferre 
Cc: Alexandre Belloni 
Cc: Ludovic Desroches 
Cc: Florian Fainelli 
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: Alexander Shiyan 
Cc: Baruch Siach 
Cc: "Maciej W. Rozycki" 
Cc: Paul Walmsley 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Pengutronix Kernel Team 
Cc: Fabio Estevam 
Cc: NXP Linux Team 
Cc: Karol Gugala 
Cc: Mateusz Holenko 
Cc: Vladimir Zapolskiy 
Cc: Neil Armstrong 
Cc: Kevin Hilman 
Cc: Jerome Brunet 
Cc: Martin Blumenstingl 
Cc: Taichi Sugaya 
Cc: Takao Orito 
Cc: Liviu Dudau 
Cc: Sudeep Holla 
Cc: Lorenzo Pieralisi 
Cc: "Andreas Färber" 
Cc: Manivannan Sadhasivam 
Cc: Michael Ellerman 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Andy Gross 
Cc: Bjorn Andersson 
Cc: Krzysztof Kozlowski 
Cc: Orson Zhai 
Cc: Baolin Wang 
Cc: Chunyan Zhang 
Cc: Patrice Chotard 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Michal Simek 
Acked-by: Richard Genoud  [atmel_serial]
Acked-by: Uwe Kleine-König 
Acked-by: Paul Cercueil 
Acked-by: Neil Armstrong  # meson_serial
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20220303080831.21783-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty/serial: Migrate sccnxp to use has_sysrq

2019-12-18T14:05:00+00:00

The SUPPORT_SYSRQ ifdeffery is not nice as:
- May create misunderstanding about sizeof(struct uart_port) between
  different objects
- Prevents moving functions from serial_core.h
- Reduces readability (well, it's ifdeffery - it's hard to follow)

In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added.
Initialise it in driver's probe and remove ifdeffery.

Signed-off-by: Dmitry Safonov 
Link: https://lore.kernel.org/r/20191213000657.931618-40-dima@arista.com
Signed-off-by: Greg Kroah-Hartman

tty: Remove dev_err() usage after platform_get_irq()

2019-09-04T10:43:49+00:00

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// 
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// 

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Greg Kroah-Hartman 
Cc: Jiri Slaby 
Cc: Greg Kroah-Hartman 
Signed-off-by: Stephen Boyd 
Link: https://lore.kernel.org/r/20190730181557.90391-45-swboyd@chromium.org
Signed-off-by: Greg Kroah-Hartman

serial: sccnxp: Allow to use non-standard baud rates

2018-12-20T15:26:59+00:00

This patch adds support for the use of non-standard baud rates.
For these purposes, we use the built-in timer/counter.

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

serial: sccnxp: Adds a delay between sequential read/write cycles

2018-12-20T15:26:59+00:00

This patch adds a delay between sequential read/write cycles,
to ensure the required minimum inactive time (tRWD). A time value
from the datasheet has been added for each type of supported chips.
The “inline” compiler attribute has been removed from the
read/write functions, simply allow the compiler to control this.

Signed-off-by: Alexander Shiyan 
Signed-off-by: Greg Kroah-Hartman

headers: separate linux/mod_devicetable.h from linux/platform_device.h

2018-07-07T15:52:26+00:00

At over 4000 #includes,  is the 9th most
#included header file in the Linux kernel.  It does not need
, so drop that header and explicitly add
 to source files that need it.

   4146 #include 

After this patch, there are 225 files that use ,
for a reduction of around 3900 times that 
does not have to be read & parsed.

    225 #include 

This patch was build-tested on 20 different arch-es.

It also makes these drivers SubmitChecklist#1 compliant.

Signed-off-by: Randy Dunlap 
Reported-by: kbuild test robot  # drivers/media/platform/vimc/
Reported-by: kbuild test robot  # drivers/pinctrl/pinctrl-u300.c
Signed-off-by: Greg Kroah-Hartman

tty: serial: Remove redundant license text

2017-11-08T12:08:12+00:00

Now that the SPDX tag is in all tty files, that identifies the license
in a specific and legally-defined manner.  So the extra GPL text wording
can be removed as it is no longer needed at all.

This is done on a quest to remove the 700+ different ways that files in
the kernel describe the GPL license text.  And there's unneeded stuff
like the address (sometimes incorrect) for the FSF which is never
needed.

No copyright headers or other non-license-description text was removed.

Cc: Jiri Slaby 
Cc: Eric Anholt 
Cc: Stefan Wahren 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: "James E.J. Bottomley" 
Cc: Helge Deller 
Cc: Joachim Eastwood 
Cc: Matthias Brugger 
Cc: Masahiro Yamada 
Cc: Tobias Klauser 
Cc: Russell King 
Cc: Vineet Gupta 
Cc: Richard Genoud 
Cc: Alexander Shiyan 
Cc: Baruch Siach 
Cc: Pat Gefre 
Cc: "Guilherme G. Piccoli" 
Cc: Jason Wessel 
Cc: Vladimir Zapolskiy 
Cc: Sylvain Lemieux 
Cc: Carlo Caione 
Cc: Kevin Hilman 
Cc: Liviu Dudau 
Cc: Sudeep Holla 
Cc: Lorenzo Pieralisi 
Cc: Andy Gross 
Cc: David Brown 
Cc: "Andreas Färber" 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Kevin Cernekee 
Cc: Laxman Dewangan 
Cc: Thierry Reding 
Cc: Jonathan Hunter 
Cc: Barry Song 
Cc: Patrice Chotard 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: Chris Metcalf 
Cc: Peter Korsgaard 
Cc: Timur Tabi 
Cc: Tony Prisk 
Cc: Michal Simek 
Cc: "Sören Brinkmann" 
Signed-off-by: Greg Kroah-Hartman

tty: add SPDX identifiers to all remaining files in drivers/tty/

2017-11-08T12:08:12+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Update the drivers/tty files files with the correct SPDX license
identifier based on the license text in the file itself.  The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Jiri Slaby 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Chris Metcalf 
Cc: Jiri Kosina 
Cc: David Sterba 
Cc: James Hogan 
Cc: Rob Herring 
Cc: Eric Anholt 
Cc: Stefan Wahren 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: "James E.J. Bottomley" 
Cc: Helge Deller 
Cc: Joachim Eastwood 
Cc: Matthias Brugger 
Cc: Masahiro Yamada 
Cc: Tobias Klauser 
Cc: Russell King 
Cc: Vineet Gupta 
Cc: Richard Genoud 
Cc: Alexander Shiyan 
Cc: Baruch Siach 
Cc: "Maciej W. Rozycki" 
Cc: "Uwe Kleine-König" 
Cc: Pat Gefre 
Cc: "Guilherme G. Piccoli" 
Cc: Jason Wessel 
Cc: Vladimir Zapolskiy 
Cc: Sylvain Lemieux 
Cc: Carlo Caione 
Cc: Kevin Hilman 
Cc: Liviu Dudau 
Cc: Sudeep Holla 
Cc: Lorenzo Pieralisi 
Cc: Andy Gross 
Cc: David Brown 
Cc: "Andreas Färber" 
Cc: Kevin Cernekee 
Cc: Laxman Dewangan 
Cc: Thierry Reding 
Cc: Jonathan Hunter 
Cc: Barry Song 
Cc: Patrice Chotard 
Cc: Maxime Coquelin 
Cc: Alexandre Torgue 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Timur Tabi 
Cc: Tony Prisk 
Cc: Michal Simek 
Cc: "Sören Brinkmann" 
Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

serial: sccnxp: Convert timers to use timer_setup()

2017-11-04T11:01:54+00:00

In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.

Cc: Jiri Slaby 
Cc: linux-serial@vger.kernel.org
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

serial: sccnxp: Fix error handling in sccnxp_probe()

2017-09-18T16:19:21+00:00

sccnxp_probe() returns result of regulator_disable() that may lead
to returning zero, while device is not properly initialized.
Also the driver enables clocks, but it does not disable it.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Greg Kroah-Hartman