linux-toradex.git/drivers/tty/serial/sunsu.c, branch v3.18.7

serial: Fix IGNBRK handling

2014-06-19T20:04:52+00:00

If IGNBRK is set without either BRKINT or PARMRK set, some uart
drivers send a 0x00 byte for BREAK without the TTYBREAK flag to the
line discipline, when it should send either nothing or the TTYBREAK flag
set. This happens because the read_status_mask masks out the BI
condition, which uart_insert_char() then interprets as a normal 0x00 byte.

SUS v3 is clear regarding the meaning of IGNBRK; Section 11.2.2, General
Terminal Interface - Input Modes, states:
  "If IGNBRK is set, a break condition detected on input shall be ignored;
   that is, not put on the input queue and therefore not read by any
   process."

Fix read_status_mask to include the BI bit if IGNBRK is set; the
lsr status retains the BI bit if a BREAK is recv'd, which is
subsequently ignored in uart_insert_char() when masked with the
ignore_status_mask.

Affected drivers:
8250 - all
serial_txx9
mfd
amba-pl010
amba-pl011
atmel_serial
bfin_uart
dz
ip22zilog
max310x
mxs-auart
netx-serial
pnx8xxx_uart
pxa
sb1250-duart
sccnxp
serial_ks8695
sirfsoc_uart
st-asc
vr41xx_siu
zs
sunzilog
fsl_lpuart
sunsab
ucc_uart
bcm63xx_uart
sunsu
efm32-uart
pmac_zilog
mpsc
msm_serial
m32r_sio

Unaffected drivers:
omap-serial
rp2
sa1100
imx
icom

Annotated for fixes:
altera_uart
mcf

Drivers without break detection:
21285
xilinx-uartps
altera_jtaguart
apbuart
arc-uart
clps711x
max3100
uartlite
msm_serial_hs
nwpserial
lantiq
vt8500_serial

Unknown:
samsung
mpc52xx_uart
bfin_sport_uart
cpm_uart/core

Fixes: Bugzilla #71651, '8250_core.c incorrectly handles IGNBRK flag'
Reported-by: Ivan 
Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

sparc: serial: Clean up the locking for -rt

2014-03-06T21:32:25+00:00

Signed-off-by: David S. Miller 
Tested-by: Allen Pais

tty: Remove unnecessary semicolons

2013-10-16T20:08:16+00:00

These aren't necessary after switch and while blocks.

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

serial: use platform_{get,set}_drvdata()

2013-06-03T17:21:33+00:00

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Jingoo Han 
Signed-off-by: Greg Kroah-Hartman

serial: sunsu: add missing platform_driver_unregister() when module exit

2013-05-05T00:39:48+00:00

We have registered platform driver when module init, and
need unregister it when module exit.

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller

sunsu: Fix panic in case of nonexistent port at "console=ttySY" cmdline option

2013-03-01T21:31:36+00:00

If a machine has X (X < 4) sunsu ports and cmdline
option "console=ttySY" is passed, where X < Y <= 4,
than the following panic happens:

Unable to handle kernel NULL pointer dereference
TPC: 
RPC: 
I7: 
Call Trace:
 [0000000000453a38] register_console+0x378/0x3e0
 [0000000000576fa0] uart_add_one_port+0x2e0/0x340
 [000000000057af40] su_probe+0x160/0x2e0
 [00000000005b8a4c] platform_drv_probe+0xc/0x20
 [00000000005b6c2c] driver_probe_device+0x12c/0x220
 [00000000005b6da8] __driver_attach+0x88/0xa0
 [00000000005b4df4] bus_for_each_dev+0x54/0xa0
 [00000000005b5a54] bus_add_driver+0x154/0x260
 [00000000005b7190] driver_register+0x50/0x180
 [00000000006d250c] sunsu_init+0x18c/0x1e0
 [00000000006c2668] do_one_initcall+0xe8/0x160
 [00000000006c282c] kernel_init_freeable+0x12c/0x1e0
 [0000000000603764] kernel_init+0x4/0x100
 [0000000000405f64] ret_from_syscall+0x1c/0x2c
 [0000000000000000]           (null)

1)Fix the panic;
2)Increment registered port number every successful
probe.

Signed-off-by: Kirill Tkhai 
CC: David Miller 
Signed-off-by: David S. Miller

TTY: switch tty_flip_buffer_push

2013-01-16T06:30:15+00:00

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

Now, the one where most of tty_port_tty_get gets removed:
tty_flip_buffer_push.

IOW we also closed all the races in drivers not using tty_port_tty_get
at all yet.

Also we move tty_flip_buffer_push declaration from include/linux/tty.h
to include/linux/tty_flip.h to all others while we are changing it
anyway.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_insert_flip_char

2013-01-16T06:21:36+00:00

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

tty_insert_flip_char is the next one to proceed. This one is used all
over the code, so the patch is huge.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: remove use of __devexit

2012-11-21T23:27:46+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Jiri Slaby 
Cc: Alan Cox 
Acked-by: Tobias Klauser 
Cc: Lucas Tavares 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Tony Prisk 
Acked-by: David Brown 
Signed-off-by: Greg Kroah-Hartman

tty: remove use of __devinit

2012-11-21T23:22:52+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Jiri Slaby 
Cc: Alan Cox 
Cc: Lucas Tavares 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Tony Prisk 
Acked-by: Tobias Klauser 
Acked-by: Nicolas Ferre 
Signed-off-by: Greg Kroah-Hartman