<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux-toradex.git/drivers/tty/serial, branch v3.0.25</title>
<subtitle>Linux kernel for Apalis and Colibri modules</subtitle>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/'/>
<entry>
<title>jsm: Fixed EEH recovery error</title>
<updated>2012-02-03T17:19:00+00:00</updated>
<author>
<name>Lucas Kannebley Tavares</name>
<email>lucaskt@linux.vnet.ibm.com</email>
</author>
<published>2012-01-09T12:58:06+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=d5f0416d678ccf6e903002637c3bd9ce82ddb30f'/>
<id>d5f0416d678ccf6e903002637c3bd9ce82ddb30f</id>
<content type='text'>
commit 26aa38cafae0dbef3b2fe75ea487c83313c36d45 upstream.

There was an error on the jsm driver that would cause it to be unable to
recover after a second error is detected.

At the first error, the device recovers properly:

[72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
[72521.485695] EEH: This PCI device has failed 1 times in the last hour:
...
[72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
[72532.105689] jsm: Port 3 added

However, at the second error, it cascades until EEH disables the device:

[72631.229549] Call Trace:
...
[72641.725687] jsm: Port 3 added
[72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
[72641.725698] EEH: This PCI device has failed 3 times in the last hour:

It was caused because the PCI state was not being saved after the first
restore. Therefore, at the second recovery the PCI state would not be
restored.

Signed-off-by: Lucas Kannebley Tavares &lt;lucaskt@linux.vnet.ibm.com&gt;
Signed-off-by: Breno Leitao &lt;brenohl@br.ibm.com&gt;
Acked-by: Thadeu Lima de Souza Cascardo &lt;cascardo@linux.vnet.ibm.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 26aa38cafae0dbef3b2fe75ea487c83313c36d45 upstream.

There was an error on the jsm driver that would cause it to be unable to
recover after a second error is detected.

At the first error, the device recovers properly:

[72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
[72521.485695] EEH: This PCI device has failed 1 times in the last hour:
...
[72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
[72532.105689] jsm: Port 3 added

However, at the second error, it cascades until EEH disables the device:

[72631.229549] Call Trace:
...
[72641.725687] jsm: Port 3 added
[72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
[72641.725698] EEH: This PCI device has failed 3 times in the last hour:

It was caused because the PCI state was not being saved after the first
restore. Therefore, at the second recovery the PCI state would not be
restored.

Signed-off-by: Lucas Kannebley Tavares &lt;lucaskt@linux.vnet.ibm.com&gt;
Signed-off-by: Breno Leitao &lt;brenohl@br.ibm.com&gt;
Acked-by: Thadeu Lima de Souza Cascardo &lt;cascardo@linux.vnet.ibm.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>serial: amba-pl011: lock console writes against interrupts</title>
<updated>2012-02-03T17:19:00+00:00</updated>
<author>
<name>Rabin Vincent</name>
<email>rabin.vincent@stericsson.com</email>
</author>
<published>2012-01-17T10:52:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=f0661faa597be0c7fb7612e8968c2f508e168adf'/>
<id>f0661faa597be0c7fb7612e8968c2f508e168adf</id>
<content type='text'>
commit ef605fdb33883d687cff5ba75095a91b313b4966 upstream.

Protect against pl011_console_write() and the interrupt for
the console UART running concurrently on different CPUs.

Otherwise the console_write could spin for a long time
waiting for the UART to become not busy, while the other
CPU continuously services UART interrupts and keeps the
UART busy.

The checks for sysrq and oops_in_progress are taken
from 8250.c.

Signed-off-by: Rabin Vincent &lt;rabin.vincent@stericsson.com&gt;
Reviewed-by: Srinidhi Kasagar &lt;srinidhi.kasagar@stericsson.com&gt;
Reviewed-by: Bibek Basu &lt;bibek.basu@stericsson.com&gt;
Reviewed-by: Shreshtha Kumar Sahu &lt;shreshthakumar.sahu@stericsson.com&gt;
Signed-off-by: Linus Walleij &lt;linus.walleij@linaro.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit ef605fdb33883d687cff5ba75095a91b313b4966 upstream.

Protect against pl011_console_write() and the interrupt for
the console UART running concurrently on different CPUs.

Otherwise the console_write could spin for a long time
waiting for the UART to become not busy, while the other
CPU continuously services UART interrupts and keeps the
UART busy.

The checks for sysrq and oops_in_progress are taken
from 8250.c.

Signed-off-by: Rabin Vincent &lt;rabin.vincent@stericsson.com&gt;
Reviewed-by: Srinidhi Kasagar &lt;srinidhi.kasagar@stericsson.com&gt;
Reviewed-by: Bibek Basu &lt;bibek.basu@stericsson.com&gt;
Reviewed-by: Shreshtha Kumar Sahu &lt;shreshthakumar.sahu@stericsson.com&gt;
Signed-off-by: Linus Walleij &lt;linus.walleij@linaro.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>atmel_serial: fix spinlock lockup in RS485 code</title>
<updated>2012-01-12T19:35:07+00:00</updated>
<author>
<name>Claudio Scordino</name>
<email>claudio@evidence.eu.com</email>
</author>
<published>2011-12-16T14:08:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=630fe244a944ebb950e8b2076177547266d255cf'/>
<id>630fe244a944ebb950e8b2076177547266d255cf</id>
<content type='text'>
commit dbf1115d3f8c7052788aa4e6e46abd27f3b3eeba upstream.

Patch to fix a spinlock lockup in the driver that sometimes happens when the
tasklet starts.

Signed-off-by: Claudio Scordino &lt;claudio@evidence.eu.com&gt;
Signed-off-by: Dave Bender &lt;codehero@gmail.com&gt;
Tested-by: Dave Bender &lt;codehero@gmail.com&gt;
Acked-by: Nicolas Ferre &lt;nicolas.ferre@atmel.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit dbf1115d3f8c7052788aa4e6e46abd27f3b3eeba upstream.

Patch to fix a spinlock lockup in the driver that sometimes happens when the
tasklet starts.

Signed-off-by: Claudio Scordino &lt;claudio@evidence.eu.com&gt;
Signed-off-by: Dave Bender &lt;codehero@gmail.com&gt;
Tested-by: Dave Bender &lt;codehero@gmail.com&gt;
Acked-by: Nicolas Ferre &lt;nicolas.ferre@atmel.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>pch_uart: Support new device LAPIS Semiconductor ML7831 IOH</title>
<updated>2011-11-26T17:09:57+00:00</updated>
<author>
<name>Tomoya MORINAGA</name>
<email>tomoya-linux@dsn.lapis-semi.com</email>
</author>
<published>2011-10-28T00:38:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=6e6d3ebc5179779d72837ff38749843506fd6f7f'/>
<id>6e6d3ebc5179779d72837ff38749843506fd6f7f</id>
<content type='text'>
commit 8249f743f732ccbc3056428945ab1d9bd36d46bf upstream.

ML7831 is companion chip for Intel Atom E6xx series.

Signed-off-by: Tomoya MORINAGA &lt;tomoya-linux@dsn.lapis-semi.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 8249f743f732ccbc3056428945ab1d9bd36d46bf upstream.

ML7831 is companion chip for Intel Atom E6xx series.

Signed-off-by: Tomoya MORINAGA &lt;tomoya-linux@dsn.lapis-semi.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>pch_uart: Fix DMA resource leak issue</title>
<updated>2011-11-26T17:09:57+00:00</updated>
<author>
<name>Tomoya MORINAGA</name>
<email>tomoya.rohm@gmail.com</email>
</author>
<published>2011-11-11T01:55:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=b74d0a317e75a602085cf73428bfe7ad456aee85'/>
<id>b74d0a317e75a602085cf73428bfe7ad456aee85</id>
<content type='text'>
commit 90f04c2926cfb5bf74533b0a7766bc896f6a0c0e upstream.

Changing UART mode PIO-&gt;DMA-&gt;PIO-&gt;DMA like below, pch_uart driver can't get
DMA channel resource.

setserial /dev/ttyPCH0 ^low_latency
setserial /dev/ttyPCH0 low_latency

CAUSE:
Changing mode using setserial command, ".startup" function which gets DMA
channel is called before ".verify_port" function which sets
dma-flag(use_dma/use_dma_flag) as 1.

PIO-&gt;DMA
  .startup: Since dma-flag is 0, DMA channel is not requested.
  .verify_port: dma-flag is set as 1.
  .shutdown: N/A

DMA-&gt;PIO
  .startup: Since dma-flag is 1, DMA channel is requested.
  .verify_port: dma-flag is set as 0.
  .shutdown: Since dma-flag is 0, DMA channel is not released.

This means DMA channel resource leak occurs.
Next time, this driver can't get DMA channel resource forever.

MODIFICATION:
  Currently, when release DMA channel resource, this driver checks dma-flag.
  However, this specification occurs the above issue.
  This driver must check whether dma_request_channel is executed or not.
  The values are saved in private data variable "chan_tx/chan_tx".
  These variables mean if the value is NULL, DMA channel is not requested,
  if not NULL, DMA channel is requested.

This patch fixes the issue.

Signed-off-by: Tomoya MORINAGA &lt;tomoya.rohm@gmail.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 90f04c2926cfb5bf74533b0a7766bc896f6a0c0e upstream.

Changing UART mode PIO-&gt;DMA-&gt;PIO-&gt;DMA like below, pch_uart driver can't get
DMA channel resource.

setserial /dev/ttyPCH0 ^low_latency
setserial /dev/ttyPCH0 low_latency

CAUSE:
Changing mode using setserial command, ".startup" function which gets DMA
channel is called before ".verify_port" function which sets
dma-flag(use_dma/use_dma_flag) as 1.

PIO-&gt;DMA
  .startup: Since dma-flag is 0, DMA channel is not requested.
  .verify_port: dma-flag is set as 1.
  .shutdown: N/A

DMA-&gt;PIO
  .startup: Since dma-flag is 1, DMA channel is requested.
  .verify_port: dma-flag is set as 0.
  .shutdown: Since dma-flag is 0, DMA channel is not released.

This means DMA channel resource leak occurs.
Next time, this driver can't get DMA channel resource forever.

MODIFICATION:
  Currently, when release DMA channel resource, this driver checks dma-flag.
  However, this specification occurs the above issue.
  This driver must check whether dma_request_channel is executed or not.
  The values are saved in private data variable "chan_tx/chan_tx".
  These variables mean if the value is NULL, DMA channel is not requested,
  if not NULL, DMA channel is requested.

This patch fixes the issue.

Signed-off-by: Tomoya MORINAGA &lt;tomoya.rohm@gmail.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>pch_uart: Fix hw-flow control issue</title>
<updated>2011-11-26T17:09:57+00:00</updated>
<author>
<name>Tomoya MORINAGA</name>
<email>tomoya-linux@dsn.lapis-semi.com</email>
</author>
<published>2011-10-27T06:45:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=3f04930ad551f504006e35ba5b6d6f717406638c'/>
<id>3f04930ad551f504006e35ba5b6d6f717406638c</id>
<content type='text'>
commit a1d7cfe29f13cf45f8094929864b9c66bf0cd91b upstream.

Using hardware flow control,
currently, register of the control-bit(AFE) is not set.
This patch fixes the issue.

Signed-off-by: Tomoya MORINAGA &lt;tomoya-linux@dsn.lapis-semi.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit a1d7cfe29f13cf45f8094929864b9c66bf0cd91b upstream.

Using hardware flow control,
currently, register of the control-bit(AFE) is not set.
This patch fixes the issue.

Signed-off-by: Tomoya MORINAGA &lt;tomoya-linux@dsn.lapis-semi.com&gt;
Acked-by: Alan Cox &lt;alan@linux.intel.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>jsm: remove buggy write queue</title>
<updated>2011-11-11T17:36:24+00:00</updated>
<author>
<name>Thadeu Lima de Souza Cascardo</name>
<email>cascardo@linux.vnet.ibm.com</email>
</author>
<published>2011-08-24T16:14:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=6c3ad7aee6e6d62169948d09f2b4a1279d253cbe'/>
<id>6c3ad7aee6e6d62169948d09f2b4a1279d253cbe</id>
<content type='text'>
commit 9d898966c4a07e4a5092215b5a2829d0ef02baa2 upstream.

jsm uses a write queue that copies from uart_core circular buffer. This
copying however has some bugs, like not wrapping the head counter. Since
this write queue is also a circular buffer, the consumer function is
ready to use the uart_core circular buffer directly.

This buggy copying function was making some bytes be dropped when
transmitting to a raw tty, doing something like this.

[root@hostname ~]$ cat /dev/ttyn1 &gt; cascardo/dump &amp;
[1] 2658
[root@hostname ~]$ cat /proc/tty/drivers &gt; /dev/ttyn0
[root@hostname ~]$ cat /proc/tty/drivers
/dev/tty             /dev/tty        5       0 system:/dev/tty
/dev/console         /dev/console    5       1 system:console
/dev/ptmx            /dev/ptmx       5       2 system
/dev/vc/0            /dev/vc/0       4       0 system:vtmaster
jsm                  /dev/ttyn     250 0-31 serial
serial               /dev/ttyS       4 64-95 serial
hvc                  /dev/hvc      229 0-7 system
pty_slave            /dev/pts      136 0-1048575 pty:slave
pty_master           /dev/ptm      128 0-1048575 pty:master
unknown              /dev/tty        4 1-63 console
[root@hostname ~]$ cat cascardo/dump
/dev/tty             /dev/tty        5       0 system:/dev/tty
/dev/console         /dev/console    5       1 system:console
/dev/ptmx            /dev/ptmx       5       2 system
/dev/vc/0            /dev/vc/0       4       0 system:vtmaste[root@hostname ~]$

This patch drops the driver write queue entirely, using the circular
buffer from uart_core only.

Signed-off-by: Thadeu Lima de Souza Cascardo &lt;cascardo@linux.vnet.ibm.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 9d898966c4a07e4a5092215b5a2829d0ef02baa2 upstream.

jsm uses a write queue that copies from uart_core circular buffer. This
copying however has some bugs, like not wrapping the head counter. Since
this write queue is also a circular buffer, the consumer function is
ready to use the uart_core circular buffer directly.

This buggy copying function was making some bytes be dropped when
transmitting to a raw tty, doing something like this.

[root@hostname ~]$ cat /dev/ttyn1 &gt; cascardo/dump &amp;
[1] 2658
[root@hostname ~]$ cat /proc/tty/drivers &gt; /dev/ttyn0
[root@hostname ~]$ cat /proc/tty/drivers
/dev/tty             /dev/tty        5       0 system:/dev/tty
/dev/console         /dev/console    5       1 system:console
/dev/ptmx            /dev/ptmx       5       2 system
/dev/vc/0            /dev/vc/0       4       0 system:vtmaster
jsm                  /dev/ttyn     250 0-31 serial
serial               /dev/ttyS       4 64-95 serial
hvc                  /dev/hvc      229 0-7 system
pty_slave            /dev/pts      136 0-1048575 pty:slave
pty_master           /dev/ptm      128 0-1048575 pty:master
unknown              /dev/tty        4 1-63 console
[root@hostname ~]$ cat cascardo/dump
/dev/tty             /dev/tty        5       0 system:/dev/tty
/dev/console         /dev/console    5       1 system:console
/dev/ptmx            /dev/ptmx       5       2 system
/dev/vc/0            /dev/vc/0       4       0 system:vtmaste[root@hostname ~]$

This patch drops the driver write queue entirely, using the circular
buffer from uart_core only.

Signed-off-by: Thadeu Lima de Souza Cascardo &lt;cascardo@linux.vnet.ibm.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>serial-core: power up uart port early before we do set_termios when resuming</title>
<updated>2011-11-11T17:35:15+00:00</updated>
<author>
<name>Ning Jiang</name>
<email>ning.jiang@marvell.com</email>
</author>
<published>2011-09-05T08:28:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=3e9efdd45f78e0ad859b60906c6556e8efe2579b'/>
<id>3e9efdd45f78e0ad859b60906c6556e8efe2579b</id>
<content type='text'>
commit 94abc56f4d90f289ea32a0a11d3577fcd8cb28fb upstream.

The following patch removed uart_change_pm() in uart_resume_port():

commit 5933a161abcb8d83a2c145177f48027c3c0a8995
Author: Yin Kangkai &lt;kangkai.yin@linux.intel.com&gt;
    serial-core: reset the console speed on resume

It will break the pxa serial driver when the system resumes from suspend mode
as it will try to set baud rate divider register in set_termios but with
clock off. The register value can not be set correctly on some platform if
the clock is disabled. The pxa driver will check the value and report the
following warning:

------------[ cut here ]------------
WARNING: at drivers/tty/serial/pxa.c:545 serial_pxa_set_termios+0x1dc/0x250()
Modules linked in:
[&lt;c0281f30&gt;] (unwind_backtrace+0x0/0xf0) from [&lt;c029341c&gt;] (warn_slowpath_common+0x4c/0x64)
[&lt;c029341c&gt;] (warn_slowpath_common+0x4c/0x64) from [&lt;c029344c&gt;] (warn_slowpath_null+0x18/0x1c)
[&lt;c029344c&gt;] (warn_slowpath_null+0x18/0x1c) from [&lt;c044b1e4&gt;] (serial_pxa_set_termios+0x1dc/0x250)
[&lt;c044b1e4&gt;] (serial_pxa_set_termios+0x1dc/0x250) from [&lt;c044a840&gt;] (uart_resume_port+0x128/0x2dc)
[&lt;c044a840&gt;] (uart_resume_port+0x128/0x2dc) from [&lt;c044bbe0&gt;] (serial_pxa_resume+0x18/0x24)
[&lt;c044bbe0&gt;] (serial_pxa_resume+0x18/0x24) from [&lt;c0454d34&gt;] (platform_pm_resume+0x40/0x4c)
[&lt;c0454d34&gt;] (platform_pm_resume+0x40/0x4c) from [&lt;c0457ebc&gt;] (pm_op+0x68/0xb4)
[&lt;c0457ebc&gt;] (pm_op+0x68/0xb4) from [&lt;c0458368&gt;] (device_resume+0xb0/0xec)
[&lt;c0458368&gt;] (device_resume+0xb0/0xec) from [&lt;c04584c8&gt;] (dpm_resume+0xe0/0x194)
[&lt;c04584c8&gt;] (dpm_resume+0xe0/0x194) from [&lt;c0458588&gt;] (dpm_resume_end+0xc/0x18)
[&lt;c0458588&gt;] (dpm_resume_end+0xc/0x18) from [&lt;c02c518c&gt;] (suspend_devices_and_enter+0x16c/0x1ac)
[&lt;c02c518c&gt;] (suspend_devices_and_enter+0x16c/0x1ac) from [&lt;c02c5278&gt;] (enter_state+0xac/0xdc)
[&lt;c02c5278&gt;] (enter_state+0xac/0xdc) from [&lt;c02c48ec&gt;] (state_store+0xa0/0xbc)
[&lt;c02c48ec&gt;] (state_store+0xa0/0xbc) from [&lt;c0408f7c&gt;] (kobj_attr_store+0x18/0x1c)
[&lt;c0408f7c&gt;] (kobj_attr_store+0x18/0x1c) from [&lt;c034a6a4&gt;] (sysfs_write_file+0x108/0x140)
[&lt;c034a6a4&gt;] (sysfs_write_file+0x108/0x140) from [&lt;c02fb798&gt;] (vfs_write+0xac/0x134)
[&lt;c02fb798&gt;] (vfs_write+0xac/0x134) from [&lt;c02fb8cc&gt;] (sys_write+0x3c/0x68)
[&lt;c02fb8cc&gt;] (sys_write+0x3c/0x68) from [&lt;c027c700&gt;] (ret_fast_syscall+0x0/0x2c)
---[ end trace 88289eceb4675b04 ]---

This patch fix the problem by adding the power on opertion back for uart
console when console_suspend_enabled is true.

Signed-off-by: Ning Jiang &lt;ning.jiang@marvell.com&gt;
Tested-by: Mayank Rana &lt;mrana@codeaurora.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 94abc56f4d90f289ea32a0a11d3577fcd8cb28fb upstream.

The following patch removed uart_change_pm() in uart_resume_port():

commit 5933a161abcb8d83a2c145177f48027c3c0a8995
Author: Yin Kangkai &lt;kangkai.yin@linux.intel.com&gt;
    serial-core: reset the console speed on resume

It will break the pxa serial driver when the system resumes from suspend mode
as it will try to set baud rate divider register in set_termios but with
clock off. The register value can not be set correctly on some platform if
the clock is disabled. The pxa driver will check the value and report the
following warning:

------------[ cut here ]------------
WARNING: at drivers/tty/serial/pxa.c:545 serial_pxa_set_termios+0x1dc/0x250()
Modules linked in:
[&lt;c0281f30&gt;] (unwind_backtrace+0x0/0xf0) from [&lt;c029341c&gt;] (warn_slowpath_common+0x4c/0x64)
[&lt;c029341c&gt;] (warn_slowpath_common+0x4c/0x64) from [&lt;c029344c&gt;] (warn_slowpath_null+0x18/0x1c)
[&lt;c029344c&gt;] (warn_slowpath_null+0x18/0x1c) from [&lt;c044b1e4&gt;] (serial_pxa_set_termios+0x1dc/0x250)
[&lt;c044b1e4&gt;] (serial_pxa_set_termios+0x1dc/0x250) from [&lt;c044a840&gt;] (uart_resume_port+0x128/0x2dc)
[&lt;c044a840&gt;] (uart_resume_port+0x128/0x2dc) from [&lt;c044bbe0&gt;] (serial_pxa_resume+0x18/0x24)
[&lt;c044bbe0&gt;] (serial_pxa_resume+0x18/0x24) from [&lt;c0454d34&gt;] (platform_pm_resume+0x40/0x4c)
[&lt;c0454d34&gt;] (platform_pm_resume+0x40/0x4c) from [&lt;c0457ebc&gt;] (pm_op+0x68/0xb4)
[&lt;c0457ebc&gt;] (pm_op+0x68/0xb4) from [&lt;c0458368&gt;] (device_resume+0xb0/0xec)
[&lt;c0458368&gt;] (device_resume+0xb0/0xec) from [&lt;c04584c8&gt;] (dpm_resume+0xe0/0x194)
[&lt;c04584c8&gt;] (dpm_resume+0xe0/0x194) from [&lt;c0458588&gt;] (dpm_resume_end+0xc/0x18)
[&lt;c0458588&gt;] (dpm_resume_end+0xc/0x18) from [&lt;c02c518c&gt;] (suspend_devices_and_enter+0x16c/0x1ac)
[&lt;c02c518c&gt;] (suspend_devices_and_enter+0x16c/0x1ac) from [&lt;c02c5278&gt;] (enter_state+0xac/0xdc)
[&lt;c02c5278&gt;] (enter_state+0xac/0xdc) from [&lt;c02c48ec&gt;] (state_store+0xa0/0xbc)
[&lt;c02c48ec&gt;] (state_store+0xa0/0xbc) from [&lt;c0408f7c&gt;] (kobj_attr_store+0x18/0x1c)
[&lt;c0408f7c&gt;] (kobj_attr_store+0x18/0x1c) from [&lt;c034a6a4&gt;] (sysfs_write_file+0x108/0x140)
[&lt;c034a6a4&gt;] (sysfs_write_file+0x108/0x140) from [&lt;c02fb798&gt;] (vfs_write+0xac/0x134)
[&lt;c02fb798&gt;] (vfs_write+0xac/0x134) from [&lt;c02fb8cc&gt;] (sys_write+0x3c/0x68)
[&lt;c02fb8cc&gt;] (sys_write+0x3c/0x68) from [&lt;c027c700&gt;] (ret_fast_syscall+0x0/0x2c)
---[ end trace 88289eceb4675b04 ]---

This patch fix the problem by adding the power on opertion back for uart
console when console_suspend_enabled is true.

Signed-off-by: Ning Jiang &lt;ning.jiang@marvell.com&gt;
Tested-by: Mayank Rana &lt;mrana@codeaurora.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>serial: pxa: work around for errata #20</title>
<updated>2011-11-11T17:35:15+00:00</updated>
<author>
<name>Marcus Folkesson</name>
<email>marcus.folkesson@gmail.com</email>
</author>
<published>2011-08-30T11:53:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=d5fe5d1648b88aa16b5d97d088d9b743bc9ce0a8'/>
<id>d5fe5d1648b88aa16b5d97d088d9b743bc9ce0a8</id>
<content type='text'>
commit e44aabd649c80e8be16ede3ed3cbff6fb2561ca9 upstream.

Errata E20: UART: Character Timeout interrupt remains set under certain
software conditions.

Implication: The software servicing the UART can be trapped in an infinite loop.

Signed-off-by: Marcus Folkesson &lt;marcus.folkesson@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit e44aabd649c80e8be16ede3ed3cbff6fb2561ca9 upstream.

Errata E20: UART: Character Timeout interrupt remains set under certain
software conditions.

Implication: The software servicing the UART can be trapped in an infinite loop.

Signed-off-by: Marcus Folkesson &lt;marcus.folkesson@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>cris: fix a build error in drivers/tty/serial/crisv10.c</title>
<updated>2011-11-11T17:35:11+00:00</updated>
<author>
<name>WANG Cong</name>
<email>xiyou.wangcong@gmail.com</email>
</author>
<published>2011-09-01T05:58:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=47bbdafa8ab90e3d4b7a4c6dd9bf54f7bc6df66d'/>
<id>47bbdafa8ab90e3d4b7a4c6dd9bf54f7bc6df66d</id>
<content type='text'>
commit 2f7861de111bb8e33e6ab9f9607583c6fbc00132 upstream.

This patch fixes the following build error:

drivers/tty/serial/crisv10.c:4453: error: 'if_ser0' undeclared (first use in this function): 2 errors in 2 logs
        v3.1-rc4/cris/cris-allmodconfig v3.1-rc4/cris/cris-allyesconfig
drivers/tty/serial/crisv10.c:4453: error: (Each undeclared identifier is reported only once: 2 errors in 2 logs
        v3.1-rc4/cris/cris-allmodconfig v3.1-rc4/cris/cris-allyesconfig
drivers/tty/serial/crisv10.c:4453: error: for each function it appears in.): 2 errors in 2 logs
        v3.1-rc4/cris/cris-allmodconfig v3.1-rc4/cris/cris-allyesconfig

"if_ser0" is a typo, it should be "if_serial_0".

Cc: Mikael Starvik &lt;starvik@axis.com&gt;
Cc: Jesper Nilsson &lt;jesper.nilsson@axis.com&gt;
Signed-off-by: WANG Cong &lt;xiyou.wangcong@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit 2f7861de111bb8e33e6ab9f9607583c6fbc00132 upstream.

This patch fixes the following build error:

drivers/tty/serial/crisv10.c:4453: error: 'if_ser0' undeclared (first use in this function): 2 errors in 2 logs
        v3.1-rc4/cris/cris-allmodconfig v3.1-rc4/cris/cris-allyesconfig
drivers/tty/serial/crisv10.c:4453: error: (Each undeclared identifier is reported only once: 2 errors in 2 logs
        v3.1-rc4/cris/cris-allmodconfig v3.1-rc4/cris/cris-allyesconfig
drivers/tty/serial/crisv10.c:4453: error: for each function it appears in.): 2 errors in 2 logs
        v3.1-rc4/cris/cris-allmodconfig v3.1-rc4/cris/cris-allyesconfig

"if_ser0" is a typo, it should be "if_serial_0".

Cc: Mikael Starvik &lt;starvik@axis.com&gt;
Cc: Jesper Nilsson &lt;jesper.nilsson@axis.com&gt;
Signed-off-by: WANG Cong &lt;xiyou.wangcong@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;

</pre>
</div>
</content>
</entry>
</feed>
