linux-toradex.git/drivers/tty/tty_io.c, branch v3.0.3

TTY: tty_io, annotate locking functions

2011-04-25T21:19:12+00:00

tty_write_lock and tty_write_unlock contain imbalanced locking. But
this is intentional, so mark them appropriately by
__acquires/__releases.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: remove invalid location line in file header

2011-04-19T23:33:36+00:00

remove invalid location line in each file header after location
moved from driver/char to driver/tty

Signed-off-by: Jovi Zhang 
Signed-off-by: Greg Kroah-Hartman

TTY: fix fail path in tty_open

2011-04-19T21:43:01+00:00

When tty_add_file fails we omit to clean up. Fix that by calling
tty_release appropriatelly.

Signed-off-by: Jiri Slaby 
Cc: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: plug in deinitialize_tty_struct

2011-04-19T21:43:01+00:00

Used the newly introduced deinitialize_tty_struct to properly shut
down ldisc.

It is intended to fix the Julian's reported problem. He reports that
kmemleak checker warns about memory leak:
unreferenced object 0xc0e19860 (size 8):
comm cat, pid 1226, jiffies 4294919464 (age 287.476s)
hex dump (first 8 bytes):
44 de 2d c1 01 00 00 00 D.-.....
backtrace:
[] create_object+0x109/0x1ad
[] kmem_cache_alloc+0x60/0x68
[] tty_ldisc_get+0x54/0x76
[] tty_ldisc_init+0xa/0x20
[] initialize_tty_struct+0x2d/0x1ac
[] tty_init_dev+0x59/0x10d
[] tty_open+0x24a/0x3a2
...

Signed-off-by: Jiri Slaby 
Cc: Alan Cox 
Reported-by: Julian Anastasov 
Signed-off-by: Greg Kroah-Hartman

TTY: introduce deinit helpers for proper ldisc shutdown

2011-04-19T21:43:01+00:00

Introduce deinitialize_tty_struct which should be called after
initialize_tty_struct and before successfull tty_ldisc_setup.

It calls tty_ldisc_deinit which is opposite of tty_ldisc_init. It only
puts a reference to ldisc and assigns NULL to tty->ldisc.

It will be used to shut down ldisc when tty_release cannot be called
yet.

Signed-off-by: Jiri Slaby 
Cc: Alan Cox 
Cc: Julian Anastasov 
Signed-off-by: Greg Kroah-Hartman

TTY: unify tty_init_dev fail path handling

2011-04-19T21:42:59+00:00

Change it so that we call the deinit functions at one place at the end
of the function (by gotos). And while at it use some sane label names.

This is a preparation for the deinitialization of tty in the next
patch.

Signed-off-by: Jiri Slaby 
Cc: Alan Cox 
Cc: Julian Anastasov 
Signed-off-by: Greg Kroah-Hartman

vt: remove uneeded retval check before tty->ops->open inside tty_open

2011-04-19T21:39:28+00:00

The current check is uneeded, since !retval will always returns true,
as retval returned from tty_add_file is checked earlier and tty_open
exits if it's not zero.

Acked-by: Alan Cox 
Signed-off-by: Herton Ronaldo Krzesinski 
Signed-off-by: Greg Kroah-Hartman

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

Merge branch 'config' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl

2011-03-17T00:21:00+00:00

* 'config' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl:
  BKL: That's all, folks
  fs/locks.c: Remove stale FIXME left over from BKL conversion
  ipx: remove the BKL
  appletalk: remove the BKL
  x25: remove the BKL
  ufs: remove the BKL
  hpfs: remove the BKL
  drivers: remove extraneous includes of smp_lock.h
  tracing: don't trace the BKL
  adfs: remove the big kernel lock

drivers: remove extraneous includes of smp_lock.h

2011-03-01T23:02:40+00:00

These were missed the last time I cleaned this up
globally, because of code moving around or new code
getting merged.

Signed-off-by: Arnd Bergmann