linux-toradex.git/drivers/tty/vt, branch v4.7-rc4

tty: vt, finish looping on duplicate

2016-05-03T22:59:15+00:00

When the console is already registered, stop crawling the
registered_con_driver array and return an error immediatelly.

This makes the code more obvious. And we do not need to initialize
retval anymore.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, return error when con_startup fails

2016-05-03T22:59:15+00:00

When csw->con_startup() fails in do_register_con_driver, we return no
error (i.e. 0). This was changed back in 2006 by commit 3e795de763.
Before that we used to return -ENODEV.

So fix the return value to be -ENODEV in that case again.

Fixes: 3e795de763 ("VT binding: Add binding/unbinding support for the VT console")
Signed-off-by: Jiri Slaby 
Reported-by: "Dan Carpenter" 
Signed-off-by: Greg Kroah-Hartman

tty: vt, use proper type for default colors

2016-04-30T16:26:55+00:00

Every user of default_red, default_grn, and default_blu treats them as
unsigned char. So make it really unsigned char.

And indent the initializers and module_param properly.

This saves ~ 100 bytes of data.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, make color_table const

2016-04-30T16:26:55+00:00

This means all ->con_set_palette have to have the second parameter
const too now.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, get rid of weird source code flow

2016-04-30T16:26:55+00:00

Some code in vc_allocate is indented by 4 spaces. It is inside a
condition. Invert the condition and move the code to the first
indentation level (using \tab). And insert some empty lines to have
logical code blocks separated.

Then, instead of freeing in an 'if' false branch, use goto-error
label as fail path.

Maybe better to look at this patch with diff -w -b.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: vt, remove reduntant check

2016-04-30T16:26:55+00:00

MAX_NR_CONSOLES and MAX_NR_USER_CONSOLES are both 63 since they were
introduced in 1.1.54. And since vc_allocate does:

if (currcons >= MAX_NR_CONSOLES)
	return -ENXIO;

if (!vc_cons[currcons].d) {
	if (currcons >= MAX_NR_USER_CONSOLES && !capable(CAP_SYS_RESOURCE))
		return -EPERM;
}

the second check is pointless. Remove both the check and the macro
MAX_NR_USER_CONSOLES.

Signed-off-by: Jiri Slaby 
Reported-by: Fugang Duan 
Signed-off-by: Greg Kroah-Hartman

tty: Replace TTY_THROTTLED bit tests with tty_throttled()

2016-04-30T16:26:55+00:00

Abstract TTY_THROTTLED bit tests with tty_throttled().

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: vt: initialize softcursor_original correctly

2016-02-07T07:42:25+00:00

add_softcursor() stores the contents of the text buffer position in this
variable before drawing the softcursor, whereas hide_softcursor() writes
the value back. A value of -1 means that no cursor has been drawn and
therefore no character is to be restored. softcursor_original, however,
is only implicitly initialized with 0. Therefore, when hide_softcursor
is called for the first time (console_init -> con_init -> redraw_screen
-> hide_cursor), it wrongly writes 0x0000 in the top left corner of
the text buffer. Normally, this is just as black as the rest of the
screen (vc_video_erase_char) and can't be seen, but it appears as a
black cursor rectangle on non-black backgrounds e.g. with boot option
"vt.global_cursor_default=0 vt.color=0xf0". softcursor_original needs
to be initialized with -1.

Signed-off-by: Melchior FRANZ 
Signed-off-by: Greg Kroah-Hartman

tty/vt/keyboard: use memdup_user to simplify code

2016-02-07T07:27:46+00:00

use memdup_user rather than duplicating implementation.
found by coccinelle

Signed-off-by: Saurabh Sengar 
Signed-off-by: Greg Kroah-Hartman

Merge 4.5-rc2 into tty-next

2016-02-01T20:53:14+00:00

We want the tty/serial fixes in here as well to make merges easier.

Signed-off-by: Greg Kroah-Hartman