linux-toradex.git/drivers/tty, branch v5.1-rc3

tty: fix NULL pointer issue when tty_port ops is not set

2019-03-27T16:21:21+00:00

Unlike 'client_ops' which is initialized to 'default_client_ops', the
port operations 'ops' may be left to NULL.
Check the 'ops' value before checking the 'ops->x' value.

Signed-off-by: Fabien Dessenne 
Signed-off-by: Greg Kroah-Hartman

Disable kgdboc failed by echo space to /sys/module/kgdboc/parameters/kgdboc

2019-03-27T15:27:48+00:00

Echo "" to /sys/module/kgdboc/parameters/kgdboc will fail with "No such
device” error.

This is caused by function "configure_kgdboc" who init err to ENODEV
when the config is empty (legal input) the code go out with ENODEV
returned.

Fixes: 2dd453168643 ("kgdboc: Fix restrict error")
Signed-off-by: Wentao Wang 
Cc: stable 
Acked-by: Daniel Thompson 
Signed-off-by: Greg Kroah-Hartman

tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

2019-03-27T15:27:48+00:00

In half-duplex operation, RX should be started after TX completes.

If DMA is used, there is a case when the DMA transfer completes but the
TX FIFO is not emptied, so the RX cannot be restarted just yet.

Use a boolean variable to store this state and rearm TX interrupt mask
to be signaled again that the transfer finished. In interrupt transmit
handler this variable is used to start RX. A warning message is generated
if RX is activated before TX fifo is cleared.

Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable
RX after TX is done")
Signed-off-by: Razvan Stefanescu 
Acked-by: Richard Genoud 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty/serial: atmel: Add is_half_duplex helper

2019-03-27T15:27:48+00:00

Use a helper function to check that a port needs to use half duplex
communication, replacing several occurrences of multi-line bit checking.

Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable RX after TX is done")
Cc: stable 
Signed-off-by: Razvan Stefanescu 
Acked-by: Richard Genoud 
Signed-off-by: Greg Kroah-Hartman

serial: sh-sci: Fix setting SCSCR_TIE while transferring data

2019-03-19T14:37:44+00:00

We disable transmission interrupt (clear SCSCR_TIE) after all data has been transmitted
(if uart_circ_empty(xmit)). While transmitting, if the data is still in the tty buffer,
re-enable the SCSCR_TIE bit, which was done at sci_start_tx().
This is unnecessary processing, wasting CPU operation if the data transmission length is large.
And further, transmit end, FIFO empty bits disabling have also been performed in the step above.

Signed-off-by: Hoan Nguyen An 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

serial: ar933x_uart: Fix build failure with disabled console

2019-03-19T14:37:44+00:00

Andrey has reported on OpenWrt's bug tracking system[1], that he
currently can't use ar93xx_uart as pure serial UART without console
(CONFIG_SERIAL_8250_CONSOLE and CONFIG_SERIAL_AR933X_CONSOLE undefined),
because compilation ends with following error:

 ar933x_uart.c: In function 'ar933x_uart_console_write':
 ar933x_uart.c:550:14: error: 'struct uart_port' has no
                               member named 'sysrq'

So this patch moves all the code related to console handling behind
series of CONFIG_SERIAL_AR933X_CONSOLE ifdefs.

1. https://bugs.openwrt.org/index.php?do=details&task_id=2152

Cc: Greg Kroah-Hartman 
Cc: Jiri Slaby 
Cc: Andrey Batyiev 
Reported-by: Andrey Batyiev 
Tested-by: Andrey Batyiev 
Signed-off-by: Petr Štetiar 
Signed-off-by: Greg Kroah-Hartman

tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup

2019-03-19T14:37:44+00:00

When building with -Wsometimes-uninitialized, Clang warns:

drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud'
is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]

It's not wrong; when options is NULL, baud has no default value. Use
9600 as that is a sane default.

Link: https://github.com/ClangBuiltLinux/linux/issues/395
Suggested-by: Greg Kroah-Hartman 
Signed-off-by: Nathan Chancellor 
Reviewed-by: Nick Desaulniers 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

2019-03-19T14:37:44+00:00

Add the missing uart_unregister_driver() and i2c_del_driver() before return
from sc16is7xx_init() in the error handling case.

Signed-off-by: Mao Wenan 
Reviewed-by: Vladimir Zapolskiy 
Signed-off-by: Greg Kroah-Hartman

tty: mxs-auart: fix a potential NULL pointer dereference

2019-03-19T14:37:43+00:00

In case ioremap fails, the fix returns -ENOMEM to avoid NULL
pointer dereferences.
Multiple places use port.membase.

Signed-off-by: Kangjie Lu 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty: atmel_serial: fix a potential NULL pointer dereference

2019-03-19T14:37:43+00:00

In case dmaengine_prep_dma_cyclic fails, the fix returns a proper
error code to avoid NULL pointer dereference.

Signed-off-by: Kangjie Lu 
Fixes: 34df42f59a60 ("serial: at91: add rx dma support")
Acked-by: Richard Genoud 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman