linux-toradex.git/drivers/usb/chipidea/ci_hdrc_usb2.c, branch v6.14-rc2

usb: Switch back to struct platform_driver::remove()

2024-10-04T13:13:03+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/usb to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20240924084329.53094-2-u.kleine-koenig@baylibre.com
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: Fix unused ci_hdrc_usb2_of_match warning for !CONFIG_OF

2023-10-21T10:46:35+00:00

Commit 14485de431b0 ("usb: Use device_get_match_data()") dropped the
unconditional use of ci_hdrc_usb2_of_match resulting in this warning:

drivers/usb/chipidea/ci_hdrc_usb2.c:41:34: warning: unused variable 'ci_hdrc_usb2_of_match' [-Wunused-const-variable]

The fix is to drop of_match_ptr() which is not necessary because DT is
always used for this driver.

Fixes: 14485de431b0 ("usb: Use device_get_match_data()")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202310131627.M43j234A-lkp@intel.com/
Signed-off-by: Rob Herring 
Acked-by: Peter Chen 
Link: https://lore.kernel.org/r/20231019183015.841460-1-robh@kernel.org
Signed-off-by: Greg Kroah-Hartman

usb: Use device_get_match_data()

2023-10-10T06:55:23+00:00

Use preferred device_get_match_data() instead of of_match_device() to
get the driver match data. With this, adjust the includes to explicitly
include the correct headers.

Signed-off-by: Rob Herring 
Link: https://lore.kernel.org/r/20231009211356.3242037-16-robh@kernel.org
Signed-off-by: Greg Kroah-Hartman

usb: chipidea/ci_hdrc_usb2: Convert to platform remove callback returning void

2023-05-28T11:36:15+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart from
emitting a warning) and this typically results in resource leaks. To improve
here there is a quest to make the remove callback return void. In the first
step of this quest all drivers are converted to .remove_new() which already
returns void. Eventually after all drivers are converted, .remove_new() is
renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20230517230239.187727-9-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: Add support for VBUS control with PHY

2022-08-31T07:07:52+00:00

Some platforms make use of VBUS control over PHY which means controller
driver has to access PHY registers to turn on/off VBUS line.This patch
adds support for such platforms in chipidea.

Flag 'CI_HDRC_PHY_VBUS_CONTROL' added to support VBus control feature.

Acked-by: Peter Chen 
Signed-off-by: Piyush Mehta 
Signed-off-by: Piyush Mehta 
Link: https://lore.kernel.org/r/20220822054051.2941282-1-piyush.mehta@amd.com
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: usb2: remove unneeded semicolon

2020-04-29T01:47:19+00:00

Fix the following coccicheck warning:

drivers/usb/chipidea/ci_hdrc_usb2.c:75:28-29: Unneeded semicolon

Fixes: c2de37b31f17 ("usb: chipidea: usb2: make clock optional")
Reviewed-by: Michał Mirosław 
Signed-off-by: Jason Yan 
Signed-off-by: Peter Chen

usb: chipidea: usb2: absorb zevio glue driver

2020-04-08T01:37:50+00:00

ZEVIO glue code is is identical to generic binding now, but doesn't
enable runtime PM. Let's squash the driver and get runtime PM for free.

Signed-off-by: Michał Mirosław 
Signed-off-by: Peter Chen

usb: chipidea: usb2: make clock optional

2020-04-08T01:37:24+00:00

Allow clock to be missing from DT (assume it's enabled then).

Signed-off-by: Michał Mirosław 
Signed-off-by: Peter Chen

usb: chipidea: usb2: fix formatting

2020-04-08T01:37:17+00:00

Add spaces before closing braces.

Signed-off-by: Michał Mirosław 
Signed-off-by: Peter Chen

usb: chipidea: usb2: constify zynq_pdata

2020-04-08T01:36:43+00:00

pdata is copied anyway to allow setting device name.
Make the source const.

Signed-off-by: Michał Mirosław 
Signed-off-by: Peter Chen