linux-toradex.git/drivers/usb/chipidea/core.c, branch v3.9.2

drivers/usb/chipidea/core.c: adjust duplicate test

2013-01-21T21:15:31+00:00

Delete successive tests to the same location.  In this case res has already
been tested for being NULL, and calling devm_request_and_ioremap will not
make it NULL.  On the other hand, devm_request_and_ioremap can return NULL
on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@s exists@
local idexpression y;
expression x,e;
@@

*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
 { ... when forall
   return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
    when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
 { ... when forall
   return ...; }
// 

Signed-off-by: Julia Lawall 
Cc: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

USB: chipidea: fix use after free bug

2012-11-26T22:59:00+00:00

The pointer to a platform_device struct must not be dereferenced after
the device has been unregistered.

This bug produces a crash when unloading the ci13xxx kernel module
compiled with CONFIG_PAGE_POISONING enabled.

Signed-off-by: Lothar Waßmann 
Cc: stable  # 3.6
Acked-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: remove use of __devexit

2012-11-21T21:27:17+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Peter Korsgaard 
Cc: Alexander Shishkin 
Acked-by: Felipe Balbi 
Cc: Li Yang 
Cc: Alan Stern 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Signed-off-by: Greg Kroah-Hartman

usb: remove use of __devinit

2012-11-21T21:27:16+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Peter Korsgaard 
Cc: Alexander Shishkin 
Acked-by: Felipe Balbi 
Cc: Li Yang 
Acked-by: Alan Stern 
Cc: Geoff Levand 
Cc: Wan ZongShun 
Cc: Olav Kongas 
Cc: Lennert Buytenhek 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Nicolas Ferre 
Signed-off-by: Greg Kroah-Hartman

usb: remove use of __devexit_p

2012-11-21T21:27:16+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Peter Korsgaard 
Cc: Alexander Shishkin 
Acked-by: Felipe Balbi 
Cc: Li Yang 
Cc: Alan Stern 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Nicolas Ferre 
Acked-by: Peter Korsgaard 
Signed-off-by: Greg Kroah-Hartman

USB: chipidea: re-order irq handling to avoid unhandled irqs

2012-09-12T18:20:38+00:00

- let role driver handle irq before ID change check; this gives the
  role driver a chance to handle disconnect;
- disable irq during switch role; no role driver to handle irq in
  the period.

Tested-by: Michael Grzeschik 
Tested-by: Marc Kleine-Budde 
Signed-off-by: Richard Zhao 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

USB: chipidea: acknowledge ID change interrupt in irq handler

2012-09-12T18:20:38+00:00

In order to avoid re-queueing of the role changing work, we need to clear
the ID change interrupt bit right in the irq handler.

Tested-by: Michael Grzeschik 
Tested-by: Marc Kleine-Budde 
Signed-off-by: Richard Zhao 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

USB: chipidea: delay 2ms before read ID status at probe time

2012-09-12T18:20:38+00:00

The ID pin needs 1ms debounce time, even at probe time. We delay 2ms
to be on the safe side.

Tested-by: Michael Grzeschik 
Tested-by: Marc Kleine-Budde 
Signed-off-by: Richard Zhao 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: permit driver bindings pass phy pointer

2012-07-09T16:59:23+00:00

Sometimes, the driver bindings may know what phy they use.
For example, when using device tree, the usb controller may have a
phandler pointing to usb phy.

Signed-off-by: Richard Zhao 
Reviewed-by: Marek Vasut 
Acked-by: Felipe Balbi 
Tested-by: Subodh Nijsure 
Signed-off-by: Greg Kroah-Hartman

USB: Chipidea: add ci13xxx device id management

2012-07-09T16:53:44+00:00

We use ida_simple_get and ida_simple_remove to manage the ids.

Signed-off-by: Richard Zhao 
Reviewed-by: Felipe Balbi 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman