linux-toradex.git/drivers/usb/chipidea/udc.c, branch v4.9-rc2

usb: chipidea: udc: Use the preferred form for passing a size of a struct

2016-09-14T02:58:13+00:00

According to Documentation/CodingStyle:

"The preferred form for passing a size of a struct is the following:

	p = kmalloc(sizeof(*p), ...);
"
, so do as suggested to improve readability.

Signed-off-by: Fabio Estevam 
Signed-off-by: Peter Chen

usb: chipidea: udc: Fit into a single line

2016-09-14T02:58:13+00:00

No need to split the dma_pool_zalloc() line into two as it can
perfectly fit into a single line.

Signed-off-by: Fabio Estevam 
Signed-off-by: Peter Chen

usb: chipidea: udc: Use dma_pool_zalloc()

2016-09-14T02:58:13+00:00

We can make the code simpler by using dma_pool_zalloc() instead
of calling dma_pool_alloc() and then a memset().

Signed-off-by: Fabio Estevam 
Signed-off-by: Peter Chen

usb: chipidea: udc: Use direction flags consequently

2016-09-14T02:58:13+00:00

This driver make assumptions about the value of the direction flags.
So better use them in comparisons to improve the readability.

Signed-off-by: Stefan Wahren 
Signed-off-by: Peter Chen

usb: chipidea: udc: Don't flush endpoint fifo twice

2016-09-14T02:58:13+00:00

The endpoint fifo is already flushed in _ep_nuke so there
is no need to flush it twice.

Signed-off-by: Stefan Wahren 
Signed-off-by: Peter Chen

usb: chipidea: udc: move write barrier into hw_ep_prime

2016-09-14T02:58:13+00:00

Since there should be a write barrier before every call of
hw_ep_prime we could move it into hw_ep_prime.

Signed-off-by: Stefan Wahren 
Signed-off-by: Peter Chen

usb: chipidea: udc: fix NULL ptr dereference in isr_setup_status_phase

2016-09-09T09:19:57+00:00

Problems with the signal integrity of the high speed USB data lines or
noise on reference ground lines can cause the i.MX6 USB controller to
violate USB specs and exhibit unexpected behavior.

It was observed that USBi_UI interrupts were triggered first and when
isr_setup_status_phase was called, ci->status was NULL, which lead to a
NULL pointer dereference kernel panic.

This patch fixes the kernel panic, emits a warning once and returns
-EPIPE to halt the device and let the host get stalled.
It also adds a comment to point people, who are experiencing this issue,
to their USB hardware design.

Cc:  #4.1+
Signed-off-by: Clemens Gruber 
Signed-off-by: Peter Chen

usb: chipidea: udc: don't touch DP when controller is in host mode

2016-08-19T01:27:07+00:00

When the controller is configured to be dual role and it's in host mode,
if bind udc and gadgt driver, those gadget operations will do gadget
disconnect and finally pull down DP line, which will break host function.

Cc:  # 4.1+
Signed-off-by: Li Jun 
Signed-off-by: Peter Chen

usb: chipidea: udc: bypass otg status selector handling to gadget driver

2016-03-04T13:14:36+00:00

Since gadget driver will handle this request, so controller driver bypass
it.

Acked-by: Peter Chen 
Signed-off-by: Li Jun 
Signed-off-by: Felipe Balbi

usb: chipidea: udc: remove unused value assignment

2016-02-29T05:37:50+00:00

retval is assigned to be -EOVERFLOW but is overwritten later before
it's used, remove this unused value assignment.

Signed-off-by: Li Jun 
Signed-off-by: Peter Chen