linux-toradex.git/drivers/usb/class, branch v2.6.27.57

USB: fix oops in cdc-wdm in case of malformed descriptors

2009-05-02T17:24:29+00:00

upstream commit: e13c594f3a1fc2c78e7a20d1a07974f71e4b448f

cdc-wdm needs to ignore extremely malformed descriptors.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Chris Wright

USB: cdc-acm: add usb id for motomagx phones

2009-03-17T00:52:47+00:00

commit 155df65ae11dfc322214c6f887185929c809df1b upstream.

The Motorola MOTOMAGX phones (Z6, E8, Zn5 so far) are providing
combined ACM/BLAN USB configuration. Since it has Vendor Specific
class, the corresponding drivers (cdc-acm, zaurus) can't find it just
by interface info. This patch adds usb id so the cdc-acm driver can
properly handle this combined device.

Signed-off-by: Dmitriy Taychenachev 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm.c: fix recursive lock in acm_start_wb error path

2008-11-20T22:54:52+00:00

commit ad0b65efd12d020b046cde8d6f474e37bb98dd73 upstream.

Fixes an obvious bug in cdc-acm by avoiding a recursive lock on
acm_start_wb()'s error path. Should apply towards 2.6.27 stable and
2.6.28.

=============================================
[ INFO: possible recursive locking detected ]
2.6.27-2-pae #109
---------------------------------------------
python/31449 is trying to acquire lock:
 (&acm->write_lock){++..}, at: [] acm_start_wb+0x5c/0x7b [cdc_acm]

but task is already holding lock:
 (&acm->write_lock){++..}, at: [] acm_tty_write+0xe1/0x167 [cdc_acm]

other info that might help us debug this:
2 locks held by python/31449:
 #0:  (&tty->atomic_write_lock){--..}, at: [] tty_write_lock+0x14/0x3b
 #1:  (&acm->write_lock){++..}, at: [] acm_tty_write+0xe1/0x167 [cdc_acm]

stack backtrace:
Pid: 31449, comm: python Not tainted 2.6.27-2-pae #109
 [] ? printk+0xf/0x18
 [] __lock_acquire+0xc7b/0x1316
 [] lock_acquire+0x70/0x97
 [] ? acm_start_wb+0x5c/0x7b [cdc_acm]
 [] _spin_lock_irqsave+0x37/0x47
 [] ? acm_start_wb+0x5c/0x7b [cdc_acm]
 [] acm_start_wb+0x5c/0x7b [cdc_acm]
 [] acm_tty_write+0x143/0x167 [cdc_acm]
 [] write_chan+0x1cd/0x297
 [] ? default_wake_function+0x0/0xd
 [] tty_write+0x149/0x1b9
 [] ? write_chan+0x0/0x297
 [] ? rw_verify_area+0x76/0x98
 [] ? tty_write+0x0/0x1b9
 [] vfs_write+0x8c/0x136
 [] sys_write+0x3b/0x60
 [] sysenter_do_call+0x12/0x3f
 =======================

Signed-off-by: Brandon Philips 
Cc: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: fix memory leak in cdc-acm

2008-10-25T21:32:38+00:00

commit a496c64f1363ec4d67ebdc1e1f619ad6372a574c upstream

This fixes a memory leak on disconnect in cdc-acm

Thanks to 施金前 for finding it.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: make module autoload work

2008-10-25T21:32:37+00:00

commit aa5380b904e7f896db0931320160bdea93e41f6a upstream

this fixes an omission that led to no alias being computed for the
cdc-wdm module.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: don't unlock acm->mutex on error path

2008-08-21T17:26:35+00:00

On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote:
> I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify"
> and the kernel oopsed:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000458
> IP: [] mutex_unlock+0x0/0xb
>  [] acm_tty_open+0x4c/0x214

Signed-off-by: Alexey Dobriyan 
Tested-by: Andrei Popa 
Cc: stable 		[2.6.25.x, 2.6.26.x]
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: quirk for Conexant CX93010 USB modem

2008-08-21T17:26:33+00:00

This patch gets my Rosewill RNX-56USB USB modem (with Conexant CX93010
chipset) up and running to the point where I can send AT commands and
retrieve caller ID data, which is all I want to do with it.

Signed-off-by: Eric Sandeen 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: drain writes on close

2008-08-14T00:32:57+00:00

Add a mechanism to let the write queue drain naturally before
closing the TTY, rather than always losing that data.  There
is a timeout, so it can't wait too long.

Provide missing locking inside acm_wb_is_avail(); it matters
more now.  Note, this presumes an earlier patch was applied,
removing a call to this routine where the lock was held.

Slightly improved diagnostics on write URB completion, so we
can tell when a write URB gets killed and, if so, how much
data it wrote first ... and so that I/O path is normally
silent (and can't much change timings).

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: stop dropping tx buffers

2008-08-14T00:32:57+00:00

The "increase cdc-acm write throughput" patch left in place two
now-obsolete mechanisms, either of which can make the cdc-acm
driver drop TX data (nasty!).  This patch removes them:

  - The write_ready flag ... if an URB and buffer were found,
    they can (and should!) always be used.

  - TX path acm_wb_is_used() ... used when the buffer was just
    allocated, so that check is pointless.

Also fix a won't-yet-matter leak of a write buffer on a disconnect path.

Signed-off-by: David Brownell 
Cc:  David Engraf 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: bugfix release()

2008-08-14T00:32:57+00:00

Bugfixes to the usb_driver_release_interface() usage;

  (a) make sure releasing *either* interface first will release
      the other, instead of insisting it be the control interface;

  (b) remove the recently-added self-deadlock.

(The "fix disconnect bug in cdc-acm" patch was incomplete and incorrect.)

Plus a small "sparse" fix:  rename a local variable so it doesn't
shadow a function parameter.

Signed-off-by: David Brownell 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman