linux-toradex.git/drivers/usb/core/devio.c, branch v2.6.27-rc4

device create: usb: convert device_create to device_create_drvdata

2008-07-22T04:54:46+00:00

device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Signed-off-by: Greg Kroah-Hartman

sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor

2008-07-22T04:54:40+00:00

Why?:
There are occasions where userspace would like to access sysfs
attributes for a device but it may not know how sysfs has named the
device or the path.  For example what is the sysfs path for
/dev/disk/by-id/ata-ST3160827AS_5MT004CK?  With this change a call to
stat(2) returns the major:minor then userspace can see that
/sys/dev/block/8:32 links to /sys/block/sdc.

What are the alternatives?:
1/ Add an ioctl to return the path: Doable, but sysfs is meant to reduce
   the need to proliferate ioctl interfaces into the kernel, so this
   seems counter productive.

2/ Use udev to create these symlinks: Also doable, but it adds a
   udev dependency to utilities that might be running in a limited
   environment like an initramfs.

3/ Do a full-tree search of sysfs.

[kay.sievers@vrfy.org: fix duplicate registrations]
[kay.sievers@vrfy.org: cleanup suggestions]

Cc: Neil Brown 
Cc: Tejun Heo 
Acked-by: Kay Sievers 
Reviewed-by: SL Baur 
Acked-by: Kay Sievers 
Acked-by: Mark Lord 
Acked-by: H. Peter Anvin 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

USB: Fix pointer/int cast in USB devio code

2008-07-21T22:16:44+00:00

Fix pointer/int cast in USB devio code, and thus avoid a compiler warning.

A void* data argument passed to bus_find_device() and thence to match_devt()
is used to carry a 32-bit datum.  However, casting directly between a u32 and
a pointer is not permitted - there must be an intermediate cast via (unsigned)
long.

This was introduced by the following patch:

	commit 94b1c9fa060ece2c8f080583beb6cc6008e41413
	Author: Alan Stern 
	Date:   Tue Jun 24 14:47:12 2008 -0400

	    usbfs: simplify the lookup-by-minor routines

	    This patch (as1105) simplifies the lookup-by-minor-number code in
	    usbfs.  Instead of passing the minor number to the callback, which
	    must then reconstruct the entire dev_t value, the patch passes the
	    dev_t value directly.

	    Signed-off-by: Alan Stern 
	    Signed-off-by: Greg Kroah-Hartman 

Signed-off-by: David Howells 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usbfs: don't store bad pointers in registration

2008-07-21T22:16:43+00:00

This patch (as1107) fixes a small bug in the usbfs registration and
unregistration code.  It avoids leaving an error value stored in the
device's usb_classdev field and it avoids trying to unregister a NULL
pointer.  (It also fixes a rather extreme overuse of whitespace.)

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usbfs: fix race between open and unregister

2008-07-21T22:16:42+00:00

This patch (as1106) fixes a race between opening and unregistering
device files in usbfs.  The current code drops its reference to the
device and then reacquires it, ignoring the possibility that the
device structure might have been removed in the meantime.  It also
doesn't check whether the device is already in the NOTATTACHED state
when the file is opened.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usbfs: simplify the lookup-by-minor routines

2008-07-21T22:16:41+00:00

This patch (as1105) simplifies the lookup-by-minor-number code in
usbfs.  Instead of passing the minor number to the callback, which
must then reconstruct the entire dev_t value, the patch passes the
dev_t value directly.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usbfs: send disconnect signals when device is unregistered

2008-07-21T22:16:40+00:00

USB device files are accessible in two ways: as files in usbfs and as
character device nodes.  The two paths are supposed to behave
identically, but they don't.  When the underlying USB device is
unplugged, disconnect signals are sent to processes with open usbfs
files (if they requested these signals) but not to processes with open
device node files.

This patch (as1104) fixes the bug by moving the disconnect-signalling
code into a common subroutine which is called from both paths.
Putting this subroutine in devio.c removes the only out-of-file
reference to struct dev_state, and so the structure's declaration can
be moved from usb.h into devio.c.

Finally, the new subroutine performs one extra action: It kills all
the outstanding async URBs.  (I'd kill the outstanding synchronous
URBs too, if there was any way to do it.)  In the past this hasn't
mattered much, because devices were unregistered from usbfs only
when they were disconnected.  But now the unregistration can also
occur whenever devices are unbound from the usb_generic driver.  At
any rate, killing URBs when a device is unregistered from usbfs seems
like a good thing to do.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: fix usb_reset_device and usb_reset_composite_device(take 3)

2008-07-21T22:16:33+00:00

This patch renames the existing usb_reset_device in hub.c to
usb_reset_and_verify_device and renames the existing
usb_reset_composite_device to usb_reset_device. Also the new
usb_reset_and_verify_device does't need to be EXPORTED .

The idea of the patch is that external interface driver
should warn the other interfaces' driver of the same
device before and after reseting the usb device. One interface
driver shoud call _old_ usb_reset_composite_device instead of
_old_ usb_reset_device since it can't assume the device contains
only one interface. The _old_ usb_reset_composite_device
is safe for single interface device also. we rename the two
functions to make the change easily.

This patch is under guideline from Alan Stern.

Signed-off-by: Ming Lei

USB: remove interface parameter of usb_reset_composite_device

2008-07-21T22:16:32+00:00

From the current implementation of usb_reset_composite_device
function, the iface parameter is no longer useful. This function
doesn't do something special for the iface usb_interface,compared
with other interfaces in the usb_device. So remove the parameter
and fix the related caller.

Signed-off-by: Ming Lei 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: remove CVS keywords

2008-07-21T22:15:55+00:00

This patch removes CVS keywords that weren't updated for a long time
from comments.

Signed-off-by: Adrian Bunk 
Signed-off-by: Greg Kroah-Hartman