linux-toradex.git/drivers/usb/core/usb.c, branch v6.4

USB: core: Add routines for endpoint checks in old drivers

2023-04-20T09:43:22+00:00

Many of the older USB drivers in the Linux USB stack were written
based simply on a vendor's device specification.  They use the
endpoint information in the spec and assume these endpoints will
always be present, with the properties listed, in any device matching
the given vendor and product IDs.

While that may have been true back then, with spoofing and fuzzing it
is not true any more.  More and more we are finding that those old
drivers need to perform at least a minimum of checking before they try
to use any endpoint other than ep0.

To make this checking as simple as possible, we now add a couple of
utility routines to the USB core.  usb_check_bulk_endpoints() and
usb_check_int_endpoints() take an interface pointer together with a
list of endpoint addresses (numbers and directions).  They check that
the interface's current alternate setting includes endpoints with
those addresses and that each of these endpoints has the right type:
bulk or interrupt, respectively.

Although we already have usb_find_common_endpoints() and related
routines meant for a similar purpose, they are not well suited for
this kind of checking.  Those routines find endpoints of various
kinds, but only one (either the first or the last) of each kind, and
they don't verify that the endpoints' addresses agree with what the
caller expects.

In theory the new routines could be more general: They could take a
particular altsetting as their argument instead of always using the
interface's current altsetting.  In practice I think this won't matter
too much; multiple altsettings tend to be used for transferring media
(audio or visual) over isochronous endpoints, not bulk or interrupt.
Drivers for such devices will generally require more sophisticated
checking than these simplistic routines provide.

Signed-off-by: Alan Stern 
Link: https://lore.kernel.org/r/dd2c8e8c-2c87-44ea-ba17-c64b97e201c9@rowland.harvard.edu
Signed-off-by: Greg Kroah-Hartman

Merge tag 'driver-core-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core

2023-02-24T20:58:55+00:00

Pull driver core updates from Greg KH:
 "Here is the large set of driver core changes for 6.3-rc1.

  There's a lot of changes this development cycle, most of the work
  falls into two different categories:

   - fw_devlink fixes and updates. This has gone through numerous review
     cycles and lots of review and testing by lots of different devices.
     Hopefully all should be good now, and Saravana will be keeping a
     watch for any potential regression on odd embedded systems.

   - driver core changes to work to make struct bus_type able to be
     moved into read-only memory (i.e. const) The recent work with Rust
     has pointed out a number of areas in the driver core where we are
     passing around and working with structures that really do not have
     to be dynamic at all, and they should be able to be read-only
     making things safer overall. This is the contuation of that work
     (started last release with kobject changes) in moving struct
     bus_type to be constant. We didn't quite make it for this release,
     but the remaining patches will be finished up for the release after
     this one, but the groundwork has been laid for this effort.

  Other than that we have in here:

   - debugfs memory leak fixes in some subsystems

   - error path cleanups and fixes for some never-able-to-be-hit
     codepaths.

   - cacheinfo rework and fixes

   - Other tiny fixes, full details are in the shortlog

  All of these have been in linux-next for a while with no reported
  problems"

[ Geert Uytterhoeven points out that that last sentence isn't true, and
  that there's a pending report that has a fix that is queued up - Linus ]

* tag 'driver-core-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (124 commits)
  debugfs: drop inline constant formatting for ERR_PTR(-ERROR)
  OPP: fix error checking in opp_migrate_dentry()
  debugfs: update comment of debugfs_rename()
  i3c: fix device.h kernel-doc warnings
  dma-mapping: no need to pass a bus_type into get_arch_dma_ops()
  driver core: class: move EXPORT_SYMBOL_GPL() lines to the correct place
  Revert "driver core: add error handling for devtmpfs_create_node()"
  Revert "devtmpfs: add debug info to handle()"
  Revert "devtmpfs: remove return value of devtmpfs_delete_node()"
  driver core: cpu: don't hand-override the uevent bus_type callback.
  devtmpfs: remove return value of devtmpfs_delete_node()
  devtmpfs: add debug info to handle()
  driver core: add error handling for devtmpfs_create_node()
  driver core: bus: update my copyright notice
  driver core: bus: add bus_get_dev_root() function
  driver core: bus: constify bus_unregister()
  driver core: bus: constify some internal functions
  driver core: bus: constify bus_get_kset()
  driver core: bus: constify bus_register/unregister_notifier()
  driver core: remove private pointer from struct bus_type
  ...

driver core: make struct device_type.devnode() take a const *

2023-01-27T12:45:38+00:00

The devnode() callback in struct device_type should not be modifying the
device that is passed into it, so mark it as a const * and propagate the
function signature changes out into all relevant subsystems that use
this callback.

Cc: Jens Axboe 
Cc: Alison Schofield 
Cc: Vishal Verma 
Cc: Ira Weiny 
Cc: Ben Widawsky 
Cc: Jeremy Kerr 
Cc: Joel Stanley 
Cc: Alistar Popple 
Cc: Eddie James 
Cc: Jonathan Cameron 
Cc: Jilin Yuan 
Cc: Heikki Krogerus 
Cc: Alan Stern 
Cc: Andy Shevchenko 
Cc: Thomas Gleixner 
Cc: Jason Gunthorpe 
Cc: "Rafael J. Wysocki" 
Cc: Won Chung 
Acked-by: Dan Williams 
Acked-by: Alexander Shishkin 
Acked-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230111113018.459199-7-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

driver core: make struct device_type.uevent() take a const *

2023-01-27T12:45:36+00:00

The uevent() callback in struct device_type should not be modifying the
device that is passed into it, so mark it as a const * and propagate the
function signature changes out into all relevant subsystems that use
this callback.

Cc: Alan Stern 
Cc: Andreas Noever 
Cc: Andy Shevchenko 
Cc: Bard Liao 
Cc: Chaitanya Kulkarni 
Cc: Dan Williams 
Cc: Dmitry Torokhov 
Cc: Frank Rowand 
Cc: Ira Weiny 
Cc: Jason Gunthorpe 
Cc: Jens Axboe 
Cc: Jilin Yuan 
Cc: Jiri Slaby 
Cc: Len Brown 
Cc: Mark Gross 
Cc: "Martin K. Petersen" 
Cc: "Matthew Wilcox (Oracle)" 
Cc: Maximilian Luz 
Cc: Michael Jamet 
Cc: Ming Lei 
Cc: Pierre-Louis Bossart 
Cc: Rob Herring 
Cc: Sakari Ailus 
Cc: Sanyog Kale 
Cc: Sean Young 
Cc: Stefan Richter 
Cc: Thomas Gleixner 
Cc: Won Chung 
Cc: Yehezkel Bernat 
Acked-by: Rafael J. Wysocki 
Acked-by: Mika Westerberg  # for Thunderbolt
Acked-by: Mauro Carvalho Chehab 
Acked-by: Alexandre Belloni 
Acked-by: Heikki Krogerus 
Acked-by: Wolfram Sang 
Acked-by: Vinod Koul 
Acked-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230111113018.459199-6-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

USB: fix memory leak with using debugfs_lookup()

2023-01-17T16:23:31+00:00

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic at
once.

Cc: Alan Stern 
Cc: Jilin Yuan 
Link: https://lore.kernel.org/r/20230106152828.3790902-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

usb/core: fix repeated words in comments

2022-07-27T12:32:29+00:00

 Delete the redundant word 'the'.

Signed-off-by: Jilin Yuan 
Link: https://lore.kernel.org/r/20220716132403.35270-1-yuanjilin@cdjrlc.com
Signed-off-by: Greg Kroah-Hartman

USB: core: Update kerneldoc for usb_get_dev() and usb_get_intf()

2022-02-25T15:53:41+00:00

The kerneldoc for usb_get_dev() and usb_get_intf() says that drivers
should always refcount the references they hold for the usb_device or
usb_interface structure, respectively.  But this is an overstatement:
In many cases drivers do not access these references after they have
been unbound, and in such cases refcounting is unnecessary.

This patch updates the kerneldoc for the two routines, explaining when
a driver does not need to increment and decrement the refcount.  This
should help dispel misconceptions which might otherwise afflict
programmers new to the USB subsystem.

Signed-off-by: Alan Stern 
Link: https://lore.kernel.org/r/Yhjp4Rp9Alipmwtq@rowland.harvard.edu
Signed-off-by: Greg Kroah-Hartman

usb: Remove usb_for_each_port()

2021-12-30T11:13:04+00:00

There are no more users for the function.

Reviewed-by: Andy Shevchenko 
Acked-by: Rafael J. Wysocki 
Signed-off-by: Heikki Krogerus 
Link: https://lore.kernel.org/r/20211223082432.45653-1-heikki.krogerus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

usb: Iterator for ports

2021-04-09T14:00:00+00:00

Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.

Acked-by: Alan Stern 
Signed-off-by: Heikki Krogerus 
Link: https://lore.kernel.org/r/20210407065555.88110-4-heikki.krogerus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

Merge 5.12-rc3 into usb-next

2021-03-15T07:45:20+00:00

We want the USB fixes in here as well.

Signed-off-by: Greg Kroah-Hartman