linux-toradex.git/drivers/usb/dwc3, branch v4.20

Revert "usb: dwc3: gadget: skip Set/Clear Halt when invalid"

2018-11-26T07:05:27+00:00

This reverts commit ffb80fc672c3a7b6afd0cefcb1524fb99917b2f3.

Turns out that commit is wrong. Host controllers are allowed to use
Clear Feature HALT as means to sync data toggle between host and
periperal.

Cc: 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: fix ISOC TRB type on unaligned transfers

2018-11-14T10:43:52+00:00

When chaining ISOC TRBs together, only the first ISOC TRB should be of
type ISOC_FIRST, all others should be of type ISOC. This patch fixes
that.

Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc:  # v4.11+
Signed-off-by: Felipe Balbi

usb: dwc3: Fix NULL pointer exception in dwc3_pci_remove()

2018-11-14T08:37:19+00:00

In dwc3_pci_quirks() function, gpiod lookup table is only registered for
baytrail SOC. But in dwc3_pci_remove(), we try to unregistered it
without any checks. This leads to NULL pointer de-reference exception in
gpiod_remove_lookup_table() when unloading the module for non baytrail
SOCs. This patch fixes this issue.

Fixes: 5741022cbdf3 ("usb: dwc3: pci: Add GPIO lookup table on platforms
without ACPI GPIO resources")
Cc: 
Signed-off-by: Kuppuswamy Sathyanarayanan 
Reviewed-by: Heikki Krogerus 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: Properly check last unaligned/zero chain TRB

2018-11-06T06:40:47+00:00

Current check for the last extra TRB for zero and unaligned transfers
does not account for isoc OUT. The last TRB of the Buffer Descriptor for
isoc OUT transfers will be retired with HWO=0. As a result, we won't
return early. The req->remaining will be updated to include the BUFSIZ
count of the extra TRB, and the actual number of transferred bytes
calculation will be wrong.

To fix this, check whether it's a short or zero packet and the last TRB
chain bit to return early.

Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: 
Signed-off-by: Thinh Nguyen 
Signed-off-by: Felipe Balbi

usb: dwc3: core: Clean up ULPI device

2018-11-06T06:40:47+00:00

If dwc3_core_init_mode() fails with deferred probe,
next probe fails on sysfs with

sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/dwc3.0.auto/dwc3.0.auto.ulpi'

To avoid this failure, clean up ULPI device.

Cc: 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Felipe Balbi

usb: dwc3: Fix spelling of 'optimizations'

2018-10-02T07:43:51+00:00

'optimizations' was misspelled as 'optmizations'. Fixed it. It is a
coding style change which should have no impact on runtime execution of code.

Signed-off-by: Faisal Mehmood 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: Check ENBLSLPM before sending ep command

2018-10-02T07:38:19+00:00

When operating in USB 2.0 speeds (HS/FS), if GUSB2PHYCFG.ENBLSLPM or
GUSB2PHYCFG.SUSPHY is set, it must be cleared before issuing an endpoint
command.

Current implementation only save and restore GUSB2PHYCFG.SUSPHY
configuration. We must save and clear both GUSB2PHYCFG.ENBLSLPM and
GUSB2PHYCFG.SUSPHY settings. Restore them after the command is
completed.

DWC_usb3 3.30a and DWC_usb31 1.90a programming guide section 3.2.2

Signed-off-by: Thinh Nguyen 
Signed-off-by: Felipe Balbi

usb: dwc3: add EXTCON dependency for qcom

2018-10-02T07:33:43+00:00

Like the omap back-end, we get a link error with CONFIG_EXTCON=m
when building the qcom back-end into the kernel:

drivers/usb/dwc3/dwc3-qcom.o: In function `dwc3_qcom_probe':
dwc3-qcom.c:(.text+0x13dc): undefined reference to `extcon_get_edev_by_phandle'
dwc3-qcom.c:(.text+0x1b18): undefined reference to `devm_extcon_register_notifier'
dwc3-qcom.c:(.text+0x1b9c): undefined reference to `extcon_get_state'

Do the same thing as OMAP and add an explicit dependency on
EXTCON.

Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Felipe Balbi

usb: dwc3: exynos: Add support for Exynos5433 variant with all clocks

2018-10-02T07:33:01+00:00

DWC3 variant found in Exynos5433 SoCs requires keeping all DRD30/UHOST30
clocks enabled all the time the driver does any access to DWC3 registers,
otherwise external abort happens. So far DWC3 hardware module worked with
samsung,exynos5250-dwusb3 compatible only by luck when built into kernel:
all DRD30 clocks were left enabled by bootloader and later kept enabled
by the DRD PHY driver. However, if one tried to use Exnos DWC3 driver as
a module or performed system suspend/resume cycle, external abort
happened. This patch finally fixes this issue.

Signed-off-by: Marek Szyprowski 
Signed-off-by: Felipe Balbi

usb: dwc3: exynos: Rework clock handling and prepare for new variants

2018-10-02T07:31:43+00:00

Add per-variant list of clocks and manage them all together in
the single array. This is a preparation for adding new variants
of Exynos SoCs. No functional changes for existing Exynos SoCs.

Signed-off-by: Marek Szyprowski 
Signed-off-by: Felipe Balbi