linux-toradex.git/drivers/usb/gadget/file_storage.c, branch v3.0.7

usb: gadget: Remove the LUN checks which are always true

2011-05-10T21:14:59+00:00

Comparing an unsigned integer with greater than or equal to zero is
always true.  So, it is safe to remove similar checks from
'f_mass_storage.c' and 'file_storage.c'

Signed-off-by: Maxin B. John 
Acked-by: Michal Nazarewicz 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

Revert "usb: usb_storage: do not align length of request for CBW to maxp size"

2011-04-14T20:42:46+00:00

This reverts commit 806e8f8fcc27e1753947bd9f059ba2316cf8f92a.

To quote Alan Stern:
	The necessity for this patch has been under discussion.

	It turns out the UDC that Mian has been working on and Felipe's
	UDC have contradictory requirements.  Mian's UDC driver wants a
	bulk-OUT transfer length to be shorter than the maxpacket size
	if a short packet is expected, whereas Felipe's UDC hardware
	always needs bulk-OUT transfer lengths to be evenly divisible by
	the maxpacket size.

	Mian has agreed to go back over the driver to resolve this
	conflict.  This means we probably will not want this patch after
	all.  (In fact, we may ultimately decide to change the gadget
	framework to require that bulk-OUT transfer lengths _always_ be
	divisible by the maxpacket size -- only the g_file_storage and
	g_mass_storage gadgets would need to be changed.)

Cc: Mian Yousaf Kaukab 
Cc: Michal Nazarewicz 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: g_file_storage: don't send padding when stall=n

2011-04-13T23:24:06+00:00

This patch (as1455) removes the extra padding sent by g_file_storage
and g_mass_storage when the gadget wants to send less data than
requested by the host and isn't allowed to halt the bulk-IN endpoint.

Although the Bulk-Only Transport specification requires the padding to
be present, it isn't truly needed since the transfer will be terminated
by a short packet anyway.  Furthermore, many existing devices don't
bother to send any padding.

Signed-off-by: Alan Stern 
Acked-By: Michal Nazarewicz 
CC: Roger Quadros 
Signed-off-by: Greg Kroah-Hartman

usb: usb_storage: do not align length of request for CBW to maxp size

2011-04-13T23:24:04+00:00

Mass-storage and file-storage gadgets align the length to maximum-packet-size
when preparing the request to receive CBW. This is unnecessary and prevents the
controller driver from knowing that a short-packet is expected.

It is incorrect to set short_not_ok when preparing the request to receive CBW.
CBW will be a short-packet so short_not_ok must not be set.

This makes bh->bulk_out_intended_length unnecessary so it is also removed.

Signed-off-by: Mian Yousaf Kaukab 
Acked-by: Michal Nazarewicz 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: gadget: file_storage: put_device() in error recovery

2010-11-11T13:58:48+00:00

This commit fixes some issues with File-backed Storage Gadget
error recovery when registering LUN's devices.

First of all, when device_register() fails the device still
needs to be put.  However, because lun_release() decreases
fsg->ref reference counter the counter must be incremented
beforehand.

Second of all, after any of the device_create_file()s fails,
device_unregister() is called which in turn (indirectly) calls
lun_release() which decrements fsg->ref.  So, again, the
reference counter must be incremented beforehand.

Lastly, if the first or the second device_create_file()
succeeds, the files are never removed.  To fix it,
device_remove_file() needs to be called.  This is done by
simply marking LUN as registered prior to creating files so
that fsg_unbind() can handle removing files.

Signed-off-by: Michal Nazarewicz 
Reported-by: Rahul Ruikar 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: gadget: storage: reuse definitions from scsi.h header file

2010-10-22T17:22:07+00:00

This commit changes storage_common.h, file_storage.c and
f_mass_storage.c to use definitions of SCSI commands from
scsi/scsi.h file instead of redefining the commands in
storage_common.c.

scsi/scsi.h header file was missing READ_FORMAT_CAPACITIES and
READ_HEADER so this commit also add those to the header.

Signed-off-by: Michal Nazarewicz 
Cc: Alan Stern 
Cc: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

USB: g_file_storage: don't generate automatic serial string

2010-10-22T17:21:28+00:00

This patch (as1413) changes g_file_storage to avoid generating a bogus
automatic serial-number string descriptor.  If the user doesn't provide
a valid serial number via a module parameter then a warning is logged
and the gadget won't have any serial string descriptor at all.

Signed-off-by: Alan Stern 
Acked-by: David Brownell 
CC: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

usb gadget: don't save bind callback in struct usb_gadget_driver

2010-10-22T17:21:25+00:00

To accomplish this the function to register a gadget driver takes the bind
function as a second argument.  To make things clearer rename the function
to resemble platform_driver_probe.

This fixes many section mismatches like

	WARNING: drivers/usb/gadget/g_printer.o(.data+0xc): Section mismatch in
	reference from the variable printer_driver to the function
	.init.text:printer_bind()
	The variable printer_driver references
	the function __init printer_bind()

All callers are fixed.

Signed-off-by: Uwe Kleine-König 
[m.nazarewicz@samsung.com: added dbgp]
Signed-off-by: Michał Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

USB: Revert "USB: gadget: section mismatch warning fixed"

2010-10-22T17:21:24+00:00

This reverts a commit which proposed an invalid solution
for a section mismatch.  Next 3 commits will fix it correctly.

Conflicts:

	drivers/usb/gadget/mass_storage.c

Signed-off-by: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

usb: gadget: storage: remove nofua file when unbinding

2010-10-22T17:21:22+00:00

The dev_attr_nofua file was created during fsg_bind() but
was never removed.  Made it a bit more symmetrical and added
code to remove the file in fsg_unbind().

Signed-off-by: Michal Nazarewicz 
Acked-by: Andy Shevchenko 
Signed-off-by: Greg Kroah-Hartman