linux-toradex.git/drivers/usb/gadget/storage_common.c, branch v3.0.99

usb: gadget: storage_common: use kstrto*() [bug fix]

2011-04-30T00:24:36+00:00

This commit fixes an embarrassing bug in the "storage_common:
use kstrto*()" patch which caused fsg_store_ro() to return
zero instead of the length of the consumed buffer.

Signed-off-by: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

Revert "usb: usb_storage: do not align length of request for CBW to maxp size"

2011-04-14T20:42:46+00:00

This reverts commit 806e8f8fcc27e1753947bd9f059ba2316cf8f92a.

To quote Alan Stern:
	The necessity for this patch has been under discussion.

	It turns out the UDC that Mian has been working on and Felipe's
	UDC have contradictory requirements.  Mian's UDC driver wants a
	bulk-OUT transfer length to be shorter than the maxpacket size
	if a short packet is expected, whereas Felipe's UDC hardware
	always needs bulk-OUT transfer lengths to be evenly divisible by
	the maxpacket size.

	Mian has agreed to go back over the driver to resolve this
	conflict.  This means we probably will not want this patch after
	all.  (In fact, we may ultimately decide to change the gadget
	framework to require that bulk-OUT transfer lengths _always_ be
	divisible by the maxpacket size -- only the g_file_storage and
	g_mass_storage gadgets would need to be changed.)

Cc: Mian Yousaf Kaukab 
Cc: Michal Nazarewicz 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: gadget: storage_common: use kstrto*()

2011-04-14T00:02:11+00:00

This commit replaces the usage of strict_strtoul() (which
became deprecated after commit 33ee3b2e) with kstrtouint().

Signed-off-by: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

usb: usb_storage: do not align length of request for CBW to maxp size

2011-04-13T23:24:04+00:00

Mass-storage and file-storage gadgets align the length to maximum-packet-size
when preparing the request to receive CBW. This is unnecessary and prevents the
controller driver from knowing that a short-packet is expected.

It is incorrect to set short_not_ok when preparing the request to receive CBW.
CBW will be a short-packet so short_not_ok must not be set.

This makes bh->bulk_out_intended_length unnecessary so it is also removed.

Signed-off-by: Mian Yousaf Kaukab 
Acked-by: Michal Nazarewicz 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

block: check bdev_read_only() from blkdev_get()

2010-11-13T10:55:17+00:00

bdev read-only status can be queried using bdev_read_only() and may
change while the device is being opened.  Enforce it by checking it
from blkdev_get() after open succeeds.

This makes bdev_read_only() check in open_bdev_exclusive() and
fsg_lun_open() unnecessary.  Drop them.

Signed-off-by: Tejun Heo 
Cc: David Brownell 
Cc: linux-usb@vger.kernel.org

USB: gadget: storage: reuse definitions from scsi.h header file

2010-10-22T17:22:07+00:00

This commit changes storage_common.h, file_storage.c and
f_mass_storage.c to use definitions of SCSI commands from
scsi/scsi.h file instead of redefining the commands in
storage_common.c.

scsi/scsi.h header file was missing READ_FORMAT_CAPACITIES and
READ_HEADER so this commit also add those to the header.

Signed-off-by: Michal Nazarewicz 
Cc: Alan Stern 
Cc: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

USB: gadget: file_storage: reuse definitions from a header file

2010-10-22T17:21:50+00:00

This commit changes storage_common.c and file_storage.c to
reuse definitions from linux/usb/storage.h header file.

Signed-off-by: Michal Nazarewicz 
Cc: Alan Stern 
Cc: Matthew Wilcox 
Signed-off-by: Greg Kroah-Hartman

USB: g_file_storage: don't generate automatic serial string

2010-10-22T17:21:28+00:00

This patch (as1413) changes g_file_storage to avoid generating a bogus
automatic serial-number string descriptor.  If the user doesn't provide
a valid serial number via a module parameter then a warning is logged
and the gadget won't have any serial string descriptor at all.

Signed-off-by: Alan Stern 
Acked-by: David Brownell 
CC: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

USB: gadget: storage: optional SCSI WRITE FUA bit

2010-08-10T21:35:42+00:00

MS Windows mounts removable storage in "Removal optimized mode" by
default. All the writes to the media are synchronous which is achieved
by setting FUA (Force Unit Access) bit in SCSI WRITE(10,12) commands.
This prevents I/O requests aggregation in block layer dramatically
decreasing performance.

This patch brings an option to accept or ignore mentioned bit
 a) via specifying module parameter "nofua", or
 b) through sysfs entry
	/sys/devices/platform/_UDC_/gadget/gadget-lunX/nofua
	(_UDC_ is the name of the USB Device Controller driver)

Patch is based on the work that was done by Denis Karpov for Maemo 5
platform.

Signed-off-by: Andy Shevchenko 
Acked-by: Alan Stern 
Cc: Denis Karpov 
Cc: Adrian Hunter 
Cc: David Brownell 
Signed-off-by: Greg Kroah-Hartman

usb: gadget: storage: strict coversion of 'ro' parameter

2010-08-10T21:35:42+00:00

Bring a strict way to get the 'ro' parameter from the user.

The patch followed by this one adds another boolean parameter. To be consistent
Michał Nazarewicz proposed to use simple_strtol() in both cases (correspondend
discussion in LKML [1]). Due to simple_strtol() doesn't return error in a good
way and we have a boolean parameter the strict_strtoul() is used.

[1] http://lkml.org/lkml/2010/7/14/169

Signed-off-by: Andy Shevchenko 
Acked-by: Alan Stern 
Cc: David Brownell 
Signed-off-by: Greg Kroah-Hartman