linux-toradex.git/drivers/usb/gadget/zero.c, branch v3.9.2

usb: gadget: fix two sparse warnings

2013-01-21T18:52:49+00:00

drivers/usb/gadget/u_serial.c:1291:5: sparse: symbol \
	'userial_init' was not declared. Should it be static?
drivers/usb/gadget/zero.c:66:25: sparse: symbol \
	'gzero_options' was not declared. Should it be static?

Reported-by: Fengguang Wu 
Signed-off-by: Felipe Balbi

usb: gadget: convert source sink and loopback to new function interface

2013-01-21T18:52:40+00:00

This patch converts the f_sourcesink and f_loopback file to the USB-function
module. Both functions shares a few common utility functions which are
currently implemented in g_zero.c itself. This patch moves the common
code into the sourcesink file and creates one module out of the the two
functions (source sink and loop back).
The g_zero gadget is function specific to source sink and loop back to
set a few options. This Symbol dependency enforces a modul load right
now.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: move loopback's config descriptor out of f_loopback

2013-01-21T18:52:39+00:00

f_loopback should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: move source sink's config descriptor out of f_sourcesink

2013-01-21T18:52:38+00:00

f_sourcesink should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: remove usb_gadget_controller_number()

2012-09-10T13:43:24+00:00

The bcdDevice field is defined as
|Device release number in binary-coded decimal
in the USB 2.0 specification. We use this field to distinguish the UDCs
from each other. In theory this could be used on the host side to apply
certain quirks if the "special" UDC in combination with this gadget is
used. This hasn't been done as far as I am aware. In practice it would
be better to fix the UDC driver before shipping since a later release
might not need this quirk anymore.

There are some driver in tree (on the host side) which use the bcdDevice
field to figure out special workarounds for a given firmware revision.
This seems to make sense. Therefore this patch converts all gadgets
(except a few) to use the kernel version instead a random 2 or 3 plus
the UDC number. The few that don't report kernel's version are:
- webcam
  This one reports always a version 0x10 so allow it to do so in future.
- nokia
  This one reports always 0x211. The comment says that this gadget works
  only if the UDC supports altsettings so I added a check for this.
- serial
  This one reports 0x2400 + UDC number. Since the gadget version is 2.4
  this could make sense. Therefore bcdDevice is 0x2400 here.

I also remove various gadget_is_ macros which are unused. The
remaining few macros should be moved to feature / bug bitfield.

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: libcomposite: move composite.c into libcomposite

2012-09-10T13:13:03+00:00

This moves composite.c into libcomposite and updates all gadgets.
Finally!

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: Provide a default implementation of default manufacturer string

2012-09-10T13:13:02+00:00

Some gadgets provide custom entry here. Some may override it with an
etntry that is also created by composite if there was no value sumbitted
at all.
This patch removes all "custom manufacturer" strings which are the same
as these which are created by composite. Then it moves the creation of
the default manufacturer string to usb_composite_overwrite_options() in
case no command line argument has been used and the entry is still an
empty string.
By doing this we get rid of the global variable "composite_manufacturer"
in composite.

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: make sure each gadget is using same index for Product, Serial,…

2012-09-10T13:13:00+00:00

The index in usb_string array is defined by the gadget. The gadget can
choose which index entry it assigns for the serial number and which the
product name. The gadget has just to ensure that the descriptor contains
the proper string id which is assigned by composite.
If the composite layer knows the index of the "default" information
which will be overwritten by module parameters, it can be used later to
overwrite it.

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: push VID/PID/USB BCD module option into gadgets

2012-09-10T13:12:59+00:00

This patch moves the module options idVendor, idProduct and bcdDevice
from composite.c into each gadgets. This ensures compatibility with
current gadgets and removes the global variable which brings me step
closer towards composite.c in libcomposite

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: use usb_string_ids_tab instead multiple usb_string_id()

2012-09-10T13:06:48+00:00

Using usb_string_ids_tab() instead multiple calls of usb_string_id()
seems to be handy. It also allows to add string without many checks.

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi