linux-toradex.git/drivers/usb/host/ehci-hcd.c, branch v2.6.26.7

USB: ehci shutdown refactored

2008-04-25T04:16:49+00:00

This patch refactors some shutdown code so it can be shared between
ehci_stop() and ehci_shutdown().

This also fixes a couple potential bugs:
 - ehci_shutdown() was not locking ehci->lock before halting the HC.
 - ehci_shutdown() didn't disable the watchdog and IAA timers.
 - ehci_stop() was resetting the host controller when it may have been
   running, which the EHCI spec says "may result in undefined behavior".

ehci_stop() was calling port_power() to turn off the ports, which waited
20ms after applying the port change.  The msleep was for the case where
the HC might take 20ms to turn the ports on; since we're shutting them
off, we can avoid the msleep and just use ehci_turn_off_ports().

ehci_stop() doesn't need to clear the intr_enable register or revert
ownership of the companion controllers to the BIOS, because the host
controller reset should have done that.  There might be a buggy host
controller that doesn't follow the reset rules, but for now we assume
it's redundant code and remove it.

[ A subsequent patch will cancel the timers later ... this version
carries forward existing bugs where timers could get re-armed
after they're canceled. ]

Signed-off-by: Sarah Sharp 
Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: ehci: paranoia, reject large control transfers

2008-04-25T04:16:41+00:00

Some EHCI fault paths with large control transfers aren't coded.  Avoid
problems by rejecting transfers that may need two qTDs (16+ KB).  This is
mostly paranoia; even 4 KB transfers are rare, and most HCDs use lower
limits (so it's unlikely anyone would ever try such a thing).

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: ehci: remove obsolete workaround for bogus IRQs

2008-04-25T04:16:40+00:00

It was pointed out that we found and fixed the cause of the "bogus"
fatal IRQ reports some time ago ... this patch removes the code
which was working around that bug ("status" got clobbered), and a
comment which needlessly confused folk reading this code.

This also includes a minor cleanup to the code which fixed that bug.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: EHCI: Refactor "if (handshake()) state = HC_STATE_HALT"

2008-04-25T04:16:35+00:00

Refactor the EHCI "if (handshake()) state = HC_STATE_HALT" idiom,
which appears 4 times, by replacing it with calls to a new function
called handshake_on_error_set_halt().  Saves a few bytes too.

Signed-off-by: Karsten Wiese 
Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: ehci: minor cleanups

2008-04-25T04:16:34+00:00

Minor cleanups to the EHCI code:  revision history is what source
code repositories should have.  Switch to a more standard way to
kick in verbose debugging -- don't be EHCI-specific.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

plat-orion: make ehci-orion available for all Orion families

2008-03-27T18:51:40+00:00

Signed-off-by: Lennert Buytenhek 
Reviewed-by: Tzachi Perelstein 
Acked-by: Russell King 
Signed-off-by: Nicolas Pitre

USB: fix ehci unlink regressions

2008-03-10T23:42:27+00:00

The recent EHCI driver update to split the IAA watchdog timer out from
the other timers made several things work better, but not everything;
and it created a couple new issues in bugzilla.  Ergo this patch:

  - Handle a should-be-rare SMP race between the watchdog firing
    and (very late) IAA interrupts;

  - Remove a shouldn't-have-been-added WARN_ON() test;

  - Guard against one observed OOPS;

  - If this watchdog fires during clean HC shutdown, it should act
    as a NOP instead of interfering with the shutdown sequence;

  - Guard against silicon errata hypothesized by some vendors:
      * IAA status latch broken, but IAAD cleared OK;
      * IAAD wasn't cleared when IAA status got reported;

The WARN_ON is in bugzilla as 10168; the OOPS as 10078; these are
both regressions.

Signed-off-by: David Brownell 
Tested-by: Gordon Farquharson 
Signed-off-by: Greg Kroah-Hartman

USB: POWERPC: ehci: fix ppc build

2008-02-21T23:38:56+00:00

Currently, this setup:
CONFIG_USB_ARCH_HAS_EHCI=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_HCD_PPC_OF=y

Will fail to build:
  CC      drivers/usb/host/ehci-hcd.o
drivers/usb/host/ehci-hcd.c:1018:2: error: #error "missing bus glue for ehci-hcd"
make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1

ehci-hcd.c actually contains OF_PLATFORM_DRIVER glue, so error is bogus.

Signed-off-by: Anton Vorontsov 
Acked-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: fix previous sparse fix which was incorrect

2008-02-21T23:38:51+00:00

The previous fix for a "sparse" warning in ehci_urb_dequeue() was
incorrect.  After rescheduling interrupt transfers it returned the
URB's completion status, not status for the dequeue operation itself.

This patch resolves that issue, cleans up the code in the reschedule
path, and shrinks the object code by a dozen bytes.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: add ehci-ixp bus glue

2008-02-01T22:35:02+00:00

EHCI Glue driver for Intel IXP4XX EHCI USB controller

Signed-off-by: Vladimir Barinov 
Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman