linux-toradex.git/drivers/usb/host/isp1760-if.c, branch v3.11

USB: host: use platform_{get,set}_drvdata()

2013-05-30T12:32:54+00:00

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Jingoo Han 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: isp1760-if: fix memleak when platform_get_resource fail

2013-05-17T00:35:13+00:00

When platform_get_resource fail, we should release_mem_region

Signed-off-by: Libo Chen 
Signed-off-by: Greg Kroah-Hartman

usb: remove use of __devexit

2012-11-21T21:27:17+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Peter Korsgaard 
Cc: Alexander Shishkin 
Acked-by: Felipe Balbi 
Cc: Li Yang 
Cc: Alan Stern 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Signed-off-by: Greg Kroah-Hartman

usb: remove use of __devinit

2012-11-21T21:27:16+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Peter Korsgaard 
Cc: Alexander Shishkin 
Acked-by: Felipe Balbi 
Cc: Li Yang 
Acked-by: Alan Stern 
Cc: Geoff Levand 
Cc: Wan ZongShun 
Cc: Olav Kongas 
Cc: Lennert Buytenhek 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Nicolas Ferre 
Signed-off-by: Greg Kroah-Hartman

usb: remove use of __devexit_p

2012-11-21T21:27:16+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Peter Korsgaard 
Cc: Alexander Shishkin 
Acked-by: Felipe Balbi 
Cc: Li Yang 
Cc: Alan Stern 
Cc: Wan ZongShun 
Cc: Ben Dooks 
Cc: Kukjin Kim 
Acked-by: Nicolas Ferre 
Acked-by: Peter Korsgaard 
Signed-off-by: Greg Kroah-Hartman

USB: isp1760-if: Change to use irq_of_parse_and_map

2012-10-25T18:51:52+00:00

This uses irq_of_parse_and_map instead of of_irq_map_one and
irq_create_of_mapping.

Signed-off-by: Nobuhiro Iwamatsu 
Signed-off-by: Greg Kroah-Hartman

isp1760-if: make module unloads correctly

2012-04-18T20:50:44+00:00

Without this patch, the prepared disable routines
will not be called on module unloading.

Signed-off-by: Michael Grzeschik 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb

2012-01-09T20:09:47+00:00

* 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (232 commits)
  USB: Add USB-ID for Multiplex RC serial adapter to cp210x.c
  xhci: Clean up 32-bit build warnings.
  USB: update documentation for usbmon
  usb: usb-storage doesn't support dynamic id currently, the patch disables the feature to fix an oops
  drivers/usb/class/cdc-acm.c: clear dangling pointer
  drivers/usb/dwc3/dwc3-pci.c: introduce missing kfree
  drivers/usb/host/isp1760-if.c: introduce missing kfree
  usb: option: add ZD Incorporated HSPA modem
  usb: ch9: fix up MaxStreams helper
  USB: usb-skeleton.c: cleanup open_count
  USB: usb-skeleton.c: fix open/disconnect race
  xhci: Properly handle COMP_2ND_BW_ERR
  USB: remove dead code from suspend/resume path
  USB: add quirk for another camera
  drivers: usb: wusbcore: Fix dependency for USB_WUSB
  xhci: Better debugging for critical host errors.
  xhci: Be less verbose during URB cancellation.
  xhci: Remove debugging about ring structure allocation.
  xhci: Remove debugging about toggling cycle bits.
  xhci: Remove debugging for individual transfers.
  ...

drivers/usb/host/isp1760-if.c: introduce missing kfree

2012-01-04T23:52:42+00:00

drvdata needds to be freed before leaving the function in an error case.

A simplified version of the semantic match that finds the problem is as
follows: (http://coccinelle.lip6.fr)

// 
@r exists@
local idexpression x;
statement S;
identifier f1;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
x->f1
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

USB: Fix usb/isp1760 build on sparc

2011-12-21T22:41:04+00:00

This commit:

commit 8f5d621543cb064d2989fc223d3c2bc61a43981e
Author: Joachim Foerster 
Date:   Mon Oct 10 18:06:54 2011 +0200

    usb/isp1760: Let OF bindings depend on general CONFIG_OF instead of PPC_OF .

    To be able to use the driver on other OF-aware architectures, too.
    And add necessary OF related #includes to fix compilation error.

    Signed-off-by: Joachim Foerster 
    Signed-off-by: Greg Kroah-Hartman 

enabled the build on all CONFIG_OF architectures, but it cannot do
this.

This driver depends upon CONFIG_OF_IRQ but not all CONFIG_OF platforms
support that infrastructure, in particular Sparc does not so the
build fails.

Please push a patch like the following to Linus so that this code only
gets built where it actually should.

--------------------
usb/isp1760: Add missing CONFIG_OF_IRQ dependency on OF code.

Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman