linux-toradex.git/drivers/usb/misc/usbtest.c, branch v2.6.34.8

USB: usbtest: avoid to free coherent buffer in atomic context

2010-08-13T20:27:28+00:00

commit e10e1bec8e6654de4591ef45ddd6a6d1e5b2591c upstream.

This patch fixes the warning below:
[30753.755998] ------------[ cut here ]------------
[30753.755998] WARNING: at /home/tom/git/linux-2.6/linux-2.6-next/arch/x86/include/asm/dma-mapping.h:155 hcd_buffer_free+0xb1/0xd4 [usbcore]()
[30753.755998] Hardware name: 6475EK2
[30753.755998] Modules linked in: uvcvideo ehci_hcd usbtest cdc_ether usbnet vfat fat usb_storage nfsd lockd nfs_acl auth_rpcgss exportfs mii tun videodev v4l1_compat v4l2_compat_ioctl32 fuse bridge stp llc sunrpc ipv6 cpufreq_ondemand acpi_cpufreq freq_table mperf kvm_intel kvm arc4 ecb ath5k usbhid mac80211 snd_hda_codec_conexant ch341 usbserial ath cfg80211 thinkpad_acpi snd_hda_intel pcspkr wmi hwmon yenta_socket iTCO_wdt iTCO_vendor_support i2c_i801 e1000e snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore snd_page_alloc pata_acpi uhci_hcd ohci_hcd usbcore i915 drm_kms_helper drm i2c_algo_bit i2c_core video output [last unloaded: uvcvideo]
[30753.755998] Pid: 0, comm: swapper Tainted: G        W   2.6.35-rc6-gkh-wl+ #49
[30753.755998] Call Trace:
[30753.755998]    [] warn_slowpath_common+0x80/0x98
[30753.755998]  [] warn_slowpath_null+0x15/0x17
[30753.755998]  [] hcd_buffer_free+0xb1/0xd4 [usbcore]
[30753.755998]  [] usb_free_coherent+0x1c/0x1e [usbcore]
[30753.755998]  [] simple_free_urb+0x23/0x2f [usbtest]
[30753.755998]  [] iso_callback+0xbb/0x10f [usbtest]
[30753.755998]  [] usb_hcd_giveback_urb+0x8c/0xc0 [usbcore]
[30753.755998]  [] ehci_urb_done+0x84/0x95 [ehci_hcd]
[30753.755998]  [] ehci_work+0x41a/0x7dd [ehci_hcd]
[30753.755998]  [] ehci_irq+0x33b/0x370 [ehci_hcd]
[30753.755998]  [] ? sched_clock+0x9/0xd
[30753.755998]  [] ? sched_clock_local+0x1c/0x82
[30753.755998]  [] ? sched_clock_cpu+0xc3/0xce
[30753.755998]  [] ? trace_hardirqs_off+0xd/0xf
[30753.755998]  [] ? cpu_clock+0x43/0x5e
[30753.755998]  [] usb_hcd_irq+0x45/0xa1 [usbcore]
[30753.755998]  [] handle_IRQ_event+0x20/0xa5
[30753.755998]  [] handle_fasteoi_irq+0x92/0xd2
[30753.755998]  [] handle_irq+0x1f/0x2a
[30753.755998]  [] do_IRQ+0x57/0xbe
[30753.755998]  [] ret_from_intr+0x0/0x16
[30753.755998]    [] ? acpi_idle_enter_bm+0x231/0x269
[30753.755998]  [] ? acpi_idle_enter_bm+0x22a/0x269
[30753.755998]  [] cpuidle_idle_call+0x99/0xce
[30753.755998]  [] cpu_idle+0x61/0xaa
[30753.755998]  [] start_secondary+0x1c2/0x1c6
[30753.755998] ---[ end trace 904cfaf7ab4cb1a2 ]---

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

USB misc: make USB device id constant

2010-03-02T22:54:17+00:00

The id_table field of the struct usb_device_id is constant in 
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// 
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// 

Signed-off-by: Németh Márton 
Cc: Julia Lawall 
Cc: cocci@diku.dk
Signed-off-by: Greg Kroah-Hartman

USB: convert to the runtime PM framework

2010-03-02T22:54:12+00:00

This patch (as1329) converts the USB stack over to the PM core's
runtime PM framework.  This involves numerous changes throughout
usbcore, especially to hub.c and driver.c.  Perhaps the most notable
change is that CONFIG_USB_SUSPEND now depends on CONFIG_PM_RUNTIME
instead of CONFIG_PM.

Several fields in the usb_device and usb_interface structures are no
longer needed.  Some code which used to depend on CONFIG_USB_PM now
depends on CONFIG_USB_SUSPEND (requiring some rearrangement of header
files).

The only visible change in behavior should be that following a system
sleep (resume from RAM or resume from hibernation), autosuspended USB
devices will be resumed just like everything else.  They won't remain
suspended.  But if they aren't in use then they will naturally
autosuspend again in a few seconds.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usbtest: make module param pattern writeable

2009-12-11T19:55:22+00:00

Allow module_param to be writeable. This allows us to change
the parameter if usbtest is built-in in the kernel.

Signed-off-by: Vikram Pandita 
Signed-off-by: Anand Gadiyar 
Cc: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: usbtest fix endless loop in unlink tests.

2009-06-16T04:44:48+00:00

In tests 11 and 12 if the URB completes with an error status (eg babble)
the asynchrous unlink entered an endless loop trying to unlink
a non resubmitted URB.

Signed-off-by: Martin Fuzzey 
Acked-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: clean up redundant tests on unsigned

2009-01-07T17:59:49+00:00

temp, bytes and param->{length,sglen,vary} are unsigned so
these tests do nothing.

Signed-off-by: Roel Kluin 
Signed-off-by: Greg Kroah-Hartman

USB: usbtest.c: length, sglen and vary are unsigned, so cannot be negative

2008-10-22T17:05:28+00:00

length, sglen and vary are unsigned, so cannot be negative

see
vi drivers/usb/misc/usbtest.c +18
struct usbtest_param {
...
        unsigned                iterations;
        unsigned                length;
        unsigned                vary;
        unsigned                sglen;
...
};

Signed-off-by: Roel Kluin 
Signed-off-by: Greg Kroah-Hartman

Rename WARN() to WARNING() to clear the namespace

2008-07-25T17:53:29+00:00

We want to use WARN() as a variant of WARN_ON(), however a few drivers are
using WARN() internally.  This patch renames these to WARNING() to avoid the
namespace clash.  A few cases were defining but not using the thing, for those
cases I just deleted the definition.

Signed-off-by: Arjan van de Ven 
Acked-by: Greg KH 
Cc: Karsten Keil 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

usbtest: comment on why this code "expects" negative and positive errnos

2008-05-14T17:00:29+00:00

On Mon, May 12, 2008 at 01:02:22AM -0700, David Brownell wrote:
> On Sunday 11 May 2008, Marcin Slusarz wrote:
> > 
> > test_ctrl_queue expects (?) positive and negative errnos.
> > what is going on here?
> 
> The sign is just a way to flag something:
> 
>                 /* some faults are allowed, not required */
> 
> The negative ones are required.  Positive codes are optional,
> in the sense that, depending on how the peripheral happens
> to be implemented, they won't necessarily be triggered.
> 
> For example, the test to fetch a device qualifier desriptor
> must succeed if the device is running at high speed.  So that
> test is marked as negative.  But when it's full speed, it
> could legitimately fail; marked as positive.  And so on for
> other tests.
> 
> Look at how the codes are *interpreted* to see it work.

Lets document it.

Based on comment from David Brownell .

Signed-off-by: Marcin Slusarz 
Cc: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: usbtest displays diagnostics again

2008-05-02T17:25:52+00:00

Minor cleanup to the "usbtest" driver, mostly to resolve a regression:
all the important diagnostics were at KERN_DEBUG, so that when the
"#define DEBUG" was removed from the top of that file it stopped
providing diagnostics.  Fix by using KERN_ERROR.  Also:

 - Stop using the legacy dbg() calls
 - Simplify the internal debug macros
 - Correct some test descriptions:
	* Test #10 subcase 7 should *always* stall
	* Test #10 subcase 8 *may* stall
 - Diagnostic about control queue test failures is more informative
 - Fix some whitespace "bugs"

And add a warning about the rude interaction between usbfs ioctl()
and khubd during device disconnect ... don't unplug a device under
test, that will wedge.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman