linux-toradex.git/drivers/usb/phy, branch v5.6-rc6

usb: phy: tegra: Add clarifying comments about the shared registers

2020-02-10T19:12:15+00:00

Tools like Coccinelle may erroneously recommend to use the
devm_platform_ioremap_resource() API for the registers mapping because
these tools are not aware about the implementation details of the driver.
Let's add a clarifying comments to the code, which should help to stop
future attempts to break the driver.

Signed-off-by: Dmitry Osipenko 
Acked-by: Thierry Reding 
Link: https://lore.kernel.org/r/20200202224259.29187-1-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: show USB charger type for user

2020-01-24T08:41:27+00:00

Current USB charger framework only shows charger state for user, but the
user may also need charger type for further use, add support for it.

Signed-off-by: Peter Chen 
Link: https://lore.kernel.org/r/1579145333-1657-1-git-send-email-peter.chen@nxp.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors

2020-01-23T18:20:57+00:00

Instead of using the legacy GPIO API and keeping track on
polarity inversion semantics in the driver, switch to use
GPIO descriptors for this driver and change all consumers
in the process.

This makes it possible to retire platform data completely:
the only remaining platform data member was "wakeup" which
was intended to make the vbus interrupt wakeup capable,
but was not set by any users and thus remained unused. VBUS
was not waking any devices up. Leave a comment about it so
later developers using the platform can consider setting it
to always enabled so plugging in USB wakes up the platform.

Cc: Daniel Mack 
Cc: Haojian Zhuang 
Acked-by: Robert Jarzmik 
Acked-by: Felipe Balbi 
Acked-by: Sylwester Nawrocki 
Acked-by: Philipp Zabel 
Signed-off-by: Linus Walleij 
Link: https://lore.kernel.org/r/20200123155013.93249-1-linus.walleij@linaro.org
Signed-off-by: Greg Kroah-Hartman

usb: phy-generic: Delete unused platform data

2020-01-15T09:39:20+00:00

The last user of the phy generic platform data was
deleted in commit 1e041b6f313aaa966612a7e415cfc09c90d6b829
("usb: dwc3: exynos: Remove dead code"). So get rid of
the platform data, which rids us of another consumer of
the legacy GPIO API at the same time. Make sure we
only inlcude  which is all we use.

Alter the usb_phy_gen_create_phy() function prototype to
not pass any platform data as this is just hardcoded to
NULL at all locations calling it in the kernel.

Move the devm_gpiod_get* calls out of the if (of_node)
parenthesis, as these calls are generic and do not depend
on device tree, they are used by any hardware description.

Cc: Marek Szyprowski 
Cc: Felipe Balbi 
Signed-off-by: Linus Walleij 
Signed-off-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: phy: tegra: Keep CPU interrupts enabled

2020-01-09T15:21:58+00:00

There is no good reason for disabling of CPU interrupts in order to
protect the utmip_pad_count modification.

Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20200106013416.9604-17-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: tegra: Move utmip_pad_count checking under lock

2020-01-09T15:21:58+00:00

It's unlikely that two drivers could manage PHY's state simultaneously in
practice, nevertheless the utmip_pad_count checking should be under lock,
for consistency.

Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20200106013416.9604-16-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: tegra: Disable VBUS regulator on tegra_usb_phy_init failure

2020-01-09T15:21:58+00:00

VBUS regulator should be turned off in a case of error.

Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20200106013416.9604-15-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: tegra: Use device-tree notion of reset-GPIO's active-state

2020-01-09T15:21:58+00:00

It is much more intuitive if reset is treated as asserted when GPIO value
is set to 1. All NVIDIA Tegra device-trees are properly specifying active
state of the reset-GPIO since 2013, let's clean up that part of the code.

Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20200106013416.9604-14-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: tegra: Use u32 for hardware register variables

2020-01-09T15:21:58+00:00

There is a mix of u32/ULONG usage in the driver's code. Let's switch to
u32 uniformly, for consistency.

Suggested-by: Thierry Reding 
Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20200106013416.9604-13-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: phy: tegra: Use devm_otg_ulpi_create()

2020-01-09T15:21:58+00:00

The resource-managed variant removes the necessity for the driver to care
about freeing ULPI resources.

Suggested-by: Thierry Reding 
Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20200106013416.9604-12-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman