linux-toradex.git/drivers/usb/serial/mos7720.c, branch v4.4.87

USB: serial: mos7720: fix parallel probe

2017-01-12T10:22:46+00:00

commit fde1faf872ed86d88e245191bc15a8e57368cd1c upstream.

A static usb-serial-driver structure that is used to initialise the
interrupt URB was modified during probe depending on the currently
probed device type, something which could break a parallel probe of a
device of a different type.

Fix this up by overriding the default completion callback for MCS7715
devices in attach() instead. We may want to use two usb-serial driver
instances for the two types later.

Fixes: fb088e335d78 ("USB: serial: add support for serial port on the moschip 7715")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: mos7720: fix parport use-after-free on probe errors

2017-01-12T10:22:46+00:00

commit 75dd211e773afcbc264677b0749d1cf7d937ab2d upstream.

Do not submit the interrupt URB until after the parport has been
successfully registered to avoid another use-after-free in the
completion handler when accessing the freed parport private data in case
of a racing completion.

Fixes: b69578df7e98 ("USB: usbserial: mos7720: add support for parallel port on moschip 7715")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: mos7720: fix use-after-free on probe errors

2017-01-12T10:22:46+00:00

commit 91a1ff4d53c5184d383d0baeeaeab6f9736f2ff3 upstream.

The interrupt URB was submitted on probe but never stopped on probe
errors. This can lead to use-after-free issues in the completion
handler when accessing the freed usb-serial struct:

Unable to handle kernel paging request at virtual address 6b6b6be7
...
[] (mos7715_interrupt_callback [mos7720]) from [] (__usb_hcd_giveback_urb+0x80/0x140)
[] (__usb_hcd_giveback_urb) from [] (usb_hcd_giveback_urb+0x50/0x138)
[] (usb_hcd_giveback_urb) from [] (musb_giveback+0xc8/0x1cc)

Fixes: b69578df7e98 ("USB: usbserial: mos7720: add support for parallel port on moschip 7715")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: mos7720: fix NULL-deref at open

2017-01-12T10:22:46+00:00

commit b05aebc25fdc5aeeac3ee29f0dc9f58dd07c13cc upstream.

Fix NULL-pointer dereference at port open if a device lacks the expected
bulk in and out endpoints.

Unable to handle kernel NULL pointer dereference at virtual address 00000030
...
[] (mos7720_open [mos7720]) from [] (serial_port_activate+0x68/0x98 [usbserial])
[] (serial_port_activate [usbserial]) from [] (tty_port_open+0x9c/0xe8)
[] (tty_port_open) from [] (serial_open+0x48/0x6c [usbserial])
[] (serial_open [usbserial]) from [] (tty_open+0xcc/0x5cc)

Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: mos7720: fix non-atomic allocation in write path

2016-09-07T06:32:44+00:00

commit 5a5a1d614287a647b36dff3f40c2b0ceabbc83ec upstream.

There is an allocation with GFP_KERNEL flag in mos7720_write(),
while it may be called from interrupt context.

Follow-up for commit 191252837626 ("USB: kobil_sct: fix non-atomic
allocation in write path")

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: mos7720: delete parport

2016-07-11T16:31:13+00:00

commit dcb21ad4385731b7fc3ef39d255685f2f63c8c5d upstream.

parport subsystem has introduced parport_del_port() to delete a port
when it is going away. Without parport_del_port() the registered port
will not be unregistered.
To reproduce and verify the error:
Command to be used is : ls /sys/bus/parport/devices
1) without the device attached there is no output as there is no
registered parport.
2) Attach the device, and the command will show "parport0".
3) Remove the device and the command still shows "parport0".
4) Attach the device again and we get "parport1".

With the patch applied:
1) without the device attached there is no output as there is no
registered parport.
2) Attach the device, and the command will show "parport0".
3) Remove the device and there is no output as "parport0" is now
removed.
4) Attach device again to get "parport0" again.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

USB: mos7720: rename registers

2015-07-06T10:15:02+00:00

Some of the register names defined here are matching with registers
defined in other places. Like DCR is defined here and DCR is also
a register in mn10300 architecture. So when we are building this with
mn10300, build fails.
To avoid we rename all the registers.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Johan Hovold

USB: mos7720: delete some unneeded code

2014-12-03T00:15:02+00:00

The "status" is uninitialized so this creates a static checker warning.
But it's harmless, we can just delete it.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

USB: mos7720: replace unnecessary atomic allocations

2014-11-03T08:15:17+00:00

Use GFP_KERNEL instead of GFP_ATOMIC for allocations in set_termios and
port-setting helper which both may and do sleep.

Signed-off-by: Johan Hovold

USB: serial: add missing newlines to dev_ messages.

2014-03-12T19:44:50+00:00

Add missing newlines to dev_ messages.

Also make some messages less verbose where appropriate.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman