linux-toradex.git/drivers/usb/serial/oti6858.c, branch v4.5-rc2 Linux kernel for Apalis and Colibri modules usb: delete non-required instances of include <linux/init.h> 2014-01-08T23:01:39+00:00 Paul Gortmaker paul.gortmaker@windriver.com 2014-01-08T16:08:26+00:00 803a536243b3a1ed2289f41897b11b72bd083309 None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
None of these files are actually using any __init type directives
and hence don't need to include <linux/init.h>.  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: oti6858: switch to generic TIOCMIWAIT implementation 2014-01-03T20:42:24+00:00 Johan Hovold jhovold@gmail.com 2014-01-02T21:49:35+00:00 bd6383c81d5f33e01688a87c50a8d3a878aa43d5 Switch to the generic TIOCMIWAIT implementation. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Switch to the generic TIOCMIWAIT implementation.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: oti6858: only wake up MSR queue on changes 2014-01-03T20:42:24+00:00 Johan Hovold jhovold@gmail.com 2014-01-02T21:49:34+00:00 1acc36e9c8dcd44f0978c9270e24daa83f343f85 Only wake up MSR wait queue on actual modem-status changes. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Only wake up MSR wait queue on actual modem-status changes.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: serial: remove redundant OOM messages 2014-01-03T20:31:46+00:00 Johan Hovold jhovold@gmail.com 2013-12-29T18:22:56+00:00 10c642d0772ac1391ae4f9fdeb13217ab019117a Remove redundant error messages on allocation failures, which have already been logged. Cc: Joe Perches <joe@perches.com> Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Remove redundant error messages on allocation failures, which have
already been logged.

Cc: Joe Perches <joe@perches.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: oti6858: do not call set_termios with uninitialised data 2013-07-23T23:24:33+00:00 Johan Hovold jhovold@gmail.com 2013-06-26T14:47:31+00:00 dc43ff924d0d29e53e3f4d26db2c4265b1aa5a2a Make sure set_termios is not called with uninitialised data at open. The old termios struct is currently not used, but pass NULL instead to avoid future problems (e.g. stack data leak). Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Make sure set_termios is not called with uninitialised data at open. The
old termios struct is currently not used, but pass NULL instead to avoid
future problems (e.g. stack data leak).

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: serial: set drain delay at port probe 2013-07-23T23:21:50+00:00 Johan Hovold jhovold@gmail.com 2013-06-26T14:47:23+00:00 d7be62211125c85fa1dd796e92aadce84961a502 The port drain delay is constant and should be set at port probe rather than open. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The port drain delay is constant and should be set at port probe rather
than open.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: serial: remove defensive test from set_termios 2013-07-23T23:21:50+00:00 Johan Hovold jhovold@gmail.com 2013-06-26T14:47:20+00:00 a0b9281e29fb8942baddf2ce4067eb611f4f9c01 Remove defensive test from set_termios which is never called with a NULL tty. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Remove defensive test from set_termios which is never called with a NULL
tty.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: oti6858: fix TIOCMIWAIT and disconnect 2013-03-25T20:52:25+00:00 Johan Hovold jhovold@gmail.com 2013-03-21T11:37:19+00:00 215f6f04668e80543995300c9528ac0143fcda7f Use tty-port modem-status-change wait queue on which processes are woken up at hangup and disconnect. Currently a process waiting on modem-status changes will not be woken on device disconnect. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use tty-port modem-status-change wait queue on which processes are woken
up at hangup and disconnect.

Currently a process waiting on modem-status changes will not be woken on
device disconnect.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: oti6858: replace custom ioctl operation with tiocmiwait 2013-03-25T20:52:25+00:00 Johan Hovold jhovold@gmail.com 2013-03-21T11:37:18+00:00 1c9f995363d4a80de72da15af3d66a3dc2f56952 Replace custom ioctl operation with tiocmiwait. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Replace custom ioctl operation with tiocmiwait.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
USB: oti6858: fix use-after-free in TIOCMIWAIT 2013-03-21T22:59:04+00:00 Johan Hovold jhovold@gmail.com 2013-03-19T08:21:21+00:00 8edfdab37157d2683e51b8be5d3d5697f66a9f7b Use the port wait queue and make sure to check the serial disconnected flag before accessing private port data after waking up. This is is needed as the private port data (including the wait queue itself) can be gone when waking up after a disconnect. Cc: stable <stable@vger.kernel.org> Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use the port wait queue and make sure to check the serial disconnected
flag before accessing private port data after waking up.

This is is needed as the private port data (including the wait queue
itself) can be gone when waking up after a disconnect.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>