linux-toradex.git/drivers/usb/serial/quatech2.c, branch v5.5

USB: serial: quatech2: handle unbound ports

2020-01-17T15:22:59+00:00

Check for NULL port data in the modem- and line-status handlers to avoid
dereferencing a NULL pointer in the unlikely case where a port device
isn't bound to a driver (e.g. after an allocation failure on port
probe).

Note that the other (stubbed) event handlers qt2_process_xmit_empty()
and qt2_process_flush() would need similar sanity checks in case they
are ever implemented.

Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Cc: stable      # 3.5
Reviewed-by: Greg Kroah-Hartman 
Signed-off-by: Johan Hovold

USB: serial: quatech2: remove set but not used variable 'port_priv'

2018-11-12T09:08:10+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
drivers/usb/serial/quatech2.c:503:27: warning:
 variable 'port_priv' set but not used [-Wunused-but-set-variable]

It not used any more after commit 2be818a116b2 ('Revert "USB: quatech2:
only write to the tty if the port is open."')

Signed-off-by: YueHaibing 
Signed-off-by: Johan Hovold

quatech2: switch to ->get_serial()

2018-10-13T04:50:40+00:00

Reviewed-by: Johan Hovold 
Signed-off-by: Al Viro

USB: serial: quatech2: use irqsave() in USB's complete callback

2018-06-26T12:52:15+00:00

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: John Ogness 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Johan Hovold

USB: serial: cast sizeof() to int when comparing with error code

2018-06-25T08:34:31+00:00

Negative error code will be larger than sizeof().

Note that none of these bugs prevent errors from being detected, even if
the ir-usb one would cause a less precise debug message to printed.

Signed-off-by: Chengguang Xu 
[ johan: add comment about implications ]
Signed-off-by: Johan Hovold

USB: serial: fix module-license macros

2017-11-04T10:58:00+00:00

Several GPL-2.0 drivers used "GPL" rather than "GPL v2" in their
MODULE_LICENSE macros; fix the macros to match the licenses.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: Remove redundant license text

2017-11-04T10:55:38+00:00

Now that the SPDX tag is in all USB files, that identifies the license
in a specific and legally-defined manner.  So the extra GPL text wording
can be removed as it is no longer needed at all.

This is done on a quest to remove the 700+ different ways that files in
the kernel describe the GPL license text.  And there's unneeded stuff
like the address (sometimes incorrect) for the FSF which is never
needed.

No copyright headers or other non-license-description text was removed.

Signed-off-by: Greg Kroah-Hartman 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-04T10:48:02+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Update the drivers/usb/ and include/linux/usb* files with the correct
SPDX license identifier based on the license text in the file itself.
The SPDX identifier is a legally binding shorthand, which can be used
instead of the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Signed-off-by: Greg Kroah-Hartman 
Acked-by: Felipe Balbi 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: quatech2: drop redundant tty_buffer_request_room

2017-04-10T07:42:00+00:00

Drop redundant calls to tty_buffer_request_room and use the more
efficient tty_insert_flip_char when inserting single characters.

Signed-off-by: Johan Hovold

USB: serial: allow subdrivers to modify port-endpoint mapping

2017-03-28T08:54:39+00:00

Allow subdrivers to modify the port-endpoint mapping by passing the
endpoint descriptors to calc_num_ports.

The callback can now also be used to verify that the required endpoints
exists and abort probing otherwise.

This will allow us to get rid of a few hacks in subdrivers that are
already modifying the port-endpoint mapping (or aborting probe due to
missing endpoints), but only after the port structures have been setup.

Signed-off-by: Johan Hovold