linux-toradex.git/drivers/usb/serial/ssu100.c, branch v3.4.72

USB: serial: fix null-pointer dereferences on disconnect

2013-02-28T14:58:59+00:00

commit b2ca699076573c94fee9a73cb0d8645383b602a0 upstream.

Make sure serial-driver dtr_rts is called with disc_mutex held after
checking the disconnected flag.

Due to a bug in the tty layer, dtr_rts may get called after a device has
been disconnected and the tty-device unregistered. Some drivers have had
individual checks for disconnect to make sure the disconnected interface
was not accessed, but this should really be handled in usb-serial core
(at least until the long-standing tty-bug has been fixed).

Note that the problem has been made more acute with commit 0998d0631001
("device-core: Ensure drvdata = NULL when no driver is bound") as the
port data is now also NULL when dtr_rts is called resulting in further
oopses.

Reported-by: Chris Ruehl 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: ssu100.c: use module_usb_serial_driver

2012-02-28T21:12:36+00:00

This converts the ssu100.c driver to use the module_usb_serial_driver() call
instead of having to have a module_init/module_exit function, saving a lot
of duplicated code.

CC: Rusty Russell 
CC: Alan Stern 
CC: Mauro Carvalho Chehab 
Signed-off-by: Greg Kroah-Hartman

usb-serial: use new registration API in [q-s]* drivers

2012-02-24T20:39:20+00:00

This patch (as1528) modifies the following usb-serial drivers to
utilize the new usb_serial_{de}register_drivers() routines:

	qcaux, qcserial, safe_serial, siemens_mpi, sierra,
	spcp8x5, ssu100, and symbolserial.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

module_param: make bool parameters really bool (drivers & misc)

2012-01-12T23:02:20+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Acked-by: Mauro Carvalho Chehab 
Signed-off-by: Rusty Russell

tty: remove filp from the USB tty ioctls

2011-02-17T19:59:14+00:00

We don't use it so we can trim it from here as we try and stamp the file
object dependencies out of the serial code.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tiocmset: kill the file pointer argument

2011-02-17T19:52:43+00:00

Doing tiocmget was such fun we should do tiocmset as well for the same
reasons

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tiocmget: kill off the passing of the struct file

2011-02-17T19:47:33+00:00

We don't actually need this and it causes problems for internal use of
this functionality. Currently there is a single use of the FILE * pointer.
That is the serial core which uses it to check tty_hung_up_p. However if
that is true then IO_ERROR is also already set so the check may be removed.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

USB: ssu100: remove max_packet_size calculation

2010-11-11T13:51:15+00:00

The max_packet_size logic is taken from ftdi_sio, but it's not needed
for this device.  This also makes proces_read_urb simpler.

Signed-off-by: Bill Pemberton 
Signed-off-by: Greg Kroah-Hartman

tty: Fix warning left over from TIOCGICOUNT changes

2010-10-22T17:20:05+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tty: Convert the USB drivers to the new icount interface

2010-10-22T17:20:04+00:00

Simple pasting job using the new ops function. Also fix a couple of devices
directly returning the internal struct (which happens at this point to match
for the fields that matter but isn't correct or futureproof)

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman