linux-toradex.git/drivers/usb/storage/uas.c, branch v3.15-rc1

uas: Remove comment about registering a uas scsi controller for each usb bus

2014-03-04T23:38:27+00:00

Although an interesting concept, I don't think that this is a good idea:

-This will result in lots of "virtual" scsi controllers confusing users
-If we get a scsi-bus-reset we will now need to do a usb-device-reset of all
 uas devices on the same usb bus, which is something to avoid if possible

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Add Hans de Goede as uas maintainer

2014-03-04T23:38:27+00:00

At the kernel-summit Sarah Sharp asked me if I was willing to become the
uas maintainer. I said yes, and here is a patch to make this official.

Also remove Matthew Wilcox and Sarah Sharp as maintainers at their request.

I've also added myself to the module's author tag, so that if people look there
rather then in maintainers they will know they should bug me about uas too.

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Make sure sg elements are properly aligned

2014-03-04T23:38:26+00:00

Copy the sg alignment trick from the usb-storage driver, without this I'm
seeing intermittent errors when using uas devices with an ehci controller.

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Add some data in/out ready iu sanity checks

2014-03-04T23:38:26+00:00

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Improve error reporting

2014-03-04T23:38:25+00:00

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Use the right error codes for different kinds of errors

2014-03-04T23:38:25+00:00

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Clear cmdinfo on command queue-ing

2014-03-04T23:38:24+00:00

The scsi error handling path re-uses previously queued up (and errored-out)
cmds. If such a re-used cmd had a data-phase then cmdinfo will have
data_in_urb / data_out_urb still set to the free-ed urbs from the errored-out
cmd, and they will get free-ed a second time when the error handling cmd
completes, corrupting the kernel heap.

Clearing cmdinfo on command queue-ing fixes this, and seems like a good idea
in general.

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Fix memory management

2014-03-04T23:38:24+00:00

The scsi-host structure is refcounted, scsi_remove_host tears down the
scsi-host but does not decrement the refcount, so we need to call
scsi_put_host on disconnect to get the underlying memory to be freed.

After calling scsi_remove_host, the scsi-core may still hold a reference to
the scsi-host, iow we may still get called after uas_disconnect, but we
do our own life cycle management of uas_devinfo, freeing it on disconnect,
and thus may end up using devinfo after it has been freed. Switch to letting
scsi_host_alloc allocate and manage the memory for us.

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: Fix command / task mgmt submission racing with disconnect

2014-03-04T23:38:23+00:00

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp

uas: cmdinfo: use only one list head

2014-03-04T23:38:23+00:00

cmds are either on the inflight list or on the dead list, never both, so
we only need one list head.

Signed-off-by: Hans de Goede 
Signed-off-by: Sarah Sharp