linux-toradex.git/drivers/vfio/platform/vfio_platform_common.c, branch v4.4.73

vfio: fix ioctl error handling

2016-03-09T23:34:50+00:00

commit 8160c4e455820d5008a1116d2dca35f0363bb062 upstream.

Calling return copy_to_user(...) in an ioctl will not
do the right thing if there's a pagefault:
copy_to_user returns the number of bytes not copied
in this case.

Fix up vfio to do
	return copy_to_user(...)) ?
		-EFAULT : 0;

everywhere.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Alex Williamson 
Signed-off-by: Greg Kroah-Hartman

vfio: platform: remove needless stack usage

2015-11-20T16:00:10+00:00

request_module already takes format strings, so no need to duplicate
the effort.

Signed-off-by: Kees Cook 
Signed-off-by: Alex Williamson

vfio: platform: add dev_info on device reset

2015-11-03T19:55:05+00:00

It might be helpful for the end-user to check the device reset
function was found by the vfio platform reset framework.

Lets store a pointer to the struct device in vfio_platform_device
and trace when the reset function is called or not found.

Signed-off-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio: platform: use list of registered reset function

2015-11-03T19:55:03+00:00

Remove the static lookup table and use the dynamic list of registered
reset functions instead. Also load the reset module through its alias.
The reset struct module pointer is stored in vfio_platform_device.

We also remove the useless struct device pointer parameter in
vfio_platform_get_reset.

This patch fixes the issue related to the usage of __symbol_get, which
besides from being moot, prevented compilation with CONFIG_MODULES
disabled.

Also usage of MODULE_ALIAS makes possible to add a new reset module
without needing to update the framework. This was suggested by Arnd.

Signed-off-by: Eric Auger 
Reported-by: Arnd Bergmann 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Alex Williamson

vfio: platform: add compat in vfio_platform_device

2015-11-03T19:55:02+00:00

Let's retrieve the compatibility string on probe and store it
in the vfio_platform_device struct

Signed-off-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio: platform: add capability to register a reset function

2015-11-03T19:54:57+00:00

In preparation for subsequent changes in reset function lookup,
lets introduce a dynamic list of reset combos (compat string,
reset module, reset function). The list can be populated/voided with
vfio_platform_register/unregister_reset. Those are not yet used in
this patch.

Signed-off-by: Eric Auger 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Alex Williamson

vfio: platform: introduce vfio-platform-base module

2015-11-03T19:54:56+00:00

To prepare for vfio platform reset rework let's build
vfio_platform_common.c and vfio_platform_irq.c in a separate
module from vfio-platform and vfio-amba. This makes possible
to have separate module inits and works around a race between
platform driver init and vfio reset module init: that way we
make sure symbols exported by base are available when vfio-platform
driver gets probed.

The open/release being implemented in the base module, the ref
count is applied to the parent module instead.

Signed-off-by: Eric Auger 
Suggested-by: Arnd Bergmann 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Alex Williamson

vfio/platform: store mapped memory in region, instead of an on-stack copy

2015-11-03T19:54:00+00:00

vfio_platform_{read,write}_mmio() call ioremap_nocache() to map
a region of io memory, which they store in struct vfio_platform_region to
be eventually re-used, or unmapped by vfio_platform_regions_cleanup().

These functions receive a copy of their struct vfio_platform_region
argument on the stack - so these mapped areas are always allocated, and
always leaked.

Pass this argument as a pointer instead.

Fixes: 6e3f26456009 "vfio/platform: read and write support for the device fd"
Signed-off-by: James Morse 
Acked-by: Baptiste Reynal 
Tested-by: Baptiste Reynal 
Signed-off-by: Alex Williamson

VFIO: platform: Calxeda xgmac reset module

2015-06-22T15:35:38+00:00

This patch introduces a module that registers and implements a basic
reset function for the Calxeda xgmac device. This latter basically disables
interrupts and stops DMA transfers.

The reset function code is inherited from the native calxeda xgmac driver.

Signed-off-by: Eric Auger 
Acked-by: Baptiste Reynal 
Tested-by: Baptiste Reynal 
Signed-off-by: Alex Williamson

VFIO: platform: populate the reset function on probe

2015-06-22T15:35:30+00:00

The reset function lookup happens on vfio-platform probe. The reset
module load is requested  and a reference to the function symbol is
hold. The reference is released on vfio-platform remove.

Signed-off-by: Eric Auger 
Acked-by: Baptiste Reynal 
Tested-by: Baptiste Reynal 
Signed-off-by: Alex Williamson