linux-toradex.git/drivers/vfio/platform, branch v4.6-rc7

vfio: fix ioctl error handling

2016-02-28T14:38:52+00:00

Calling return copy_to_user(...) in an ioctl will not
do the right thing if there's a pagefault:
copy_to_user returns the number of bytes not copied
in this case.

Fix up vfio to do
	return copy_to_user(...)) ?
		-EFAULT : 0;

everywhere.

Cc: stable@vger.kernel.org
Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Alex Williamson

VFIO: platform: reset: fix a warning message condition

2015-12-21T22:28:11+00:00

This loop ends with count set to -1 and not zero so the warning message
isn't printed when it should be.  I've fixed this by change the postop
to a preop.

Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module')
Signed-off-by: Dan Carpenter 
Reviewed-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio: platform: remove needless stack usage

2015-11-20T16:00:10+00:00

request_module already takes format strings, so no need to duplicate
the effort.

Signed-off-by: Kees Cook 
Signed-off-by: Alex Williamson

vfio: Drop owner assignment from platform_driver

2015-11-19T22:52:08+00:00

platform_driver does not need to set an owner because
platform_driver_register() will set it.

Signed-off-by: Krzysztof Kozlowski 
Acked-by: Baptiste Reynal 
Signed-off-by: Alex Williamson

VFIO: platform: reset: AMD xgbe reset module

2015-11-03T19:55:21+00:00

This patch introduces a module that registers and implements a low-level
reset function for the AMD XGBE device.

it performs the following actions:
- reset the PHY
- disable auto-negotiation
- disable & clear auto-negotiation IRQ
- soft-reset the MAC

Those tiny pieces of code are inherited from the native xgbe driver.

Signed-off-by: Eric Auger 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Alex Williamson

vfio: platform: reset: calxedaxgmac: fix ioaddr leak

2015-11-03T19:55:06+00:00

In the current code the vfio_platform_region is copied on the stack.
As a consequence the ioaddr address is not iounmapped in the vfio
platform driver (vfio_platform_regions_cleanup). The patch uses the
pointer to the region instead.

Signed-off-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio: platform: add dev_info on device reset

2015-11-03T19:55:05+00:00

It might be helpful for the end-user to check the device reset
function was found by the vfio platform reset framework.

Lets store a pointer to the struct device in vfio_platform_device
and trace when the reset function is called or not found.

Signed-off-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio: platform: use list of registered reset function

2015-11-03T19:55:03+00:00

Remove the static lookup table and use the dynamic list of registered
reset functions instead. Also load the reset module through its alias.
The reset struct module pointer is stored in vfio_platform_device.

We also remove the useless struct device pointer parameter in
vfio_platform_get_reset.

This patch fixes the issue related to the usage of __symbol_get, which
besides from being moot, prevented compilation with CONFIG_MODULES
disabled.

Also usage of MODULE_ALIAS makes possible to add a new reset module
without needing to update the framework. This was suggested by Arnd.

Signed-off-by: Eric Auger 
Reported-by: Arnd Bergmann 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Alex Williamson

vfio: platform: add compat in vfio_platform_device

2015-11-03T19:55:02+00:00

Let's retrieve the compatibility string on probe and store it
in the vfio_platform_device struct

Signed-off-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio: platform: reset: calxedaxgmac: add reset function registration

2015-11-03T19:55:00+00:00

This patch adds the reset function registration/unregistration.
This is handled through the module_vfio_reset_handler macro. This
latter also defines a MODULE_ALIAS which simplifies the load from
vfio-platform.

Signed-off-by: Eric Auger 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Alex Williamson