linux-toradex.git/drivers/vfio, branch v3.7-rc2

vfio: Fix PCI INTx disable consistency

2012-10-10T15:10:32+00:00

The virq_disabled flag tracks the userspace view of INTx masking
across interrupt mode changes, but we're not consistently applying
this to the interrupt and masking handler notion of the device.
Currently if the user sets DisINTx while in MSI or MSIX mode, then
returns to INTx mode (ex. rebooting a qemu guest), the hardware has
DisINTx+, but the management of INTx thinks it's enabled, making it
impossible to actually clear DisINTx.  Fix this by updating the
handler state when INTx is re-enabled.

Cc: stable@vger.kernel.org
Signed-off-by: Alex Williamson

vfio: Move PCI INTx eventfd setting earlier

2012-10-10T15:10:32+00:00

We need to be ready to recieve an interrupt as soon as we call
request_irq, so our eventfd context setting needs to be moved
earlier.  Without this, an interrupt from our device or one
sharing the interrupt line can pass a NULL into eventfd_signal
and oops.

Cc: stable@vger.kernel.org
Signed-off-by: Alex Williamson

vfio: Fix PCI mmap after b3b9c293

2012-10-10T15:10:31+00:00

Our mmap path mistakely relied on vma->vm_pgoff to get set in
remap_pfn_range.  After b3b9c293, that path only applies to
copy-on-write mappings.  Set it in our own code.

Signed-off-by: Alex Williamson

Fix staging driver use of VM_RESERVED

2012-10-09T12:06:41+00:00

The VM_RESERVED flag was killed off in commit 314e51b9851b ("mm: kill
vma flag VM_RESERVED and mm->reserved_vm counter"), and replaced by the
proper semantic flags (eg "don't core-dump" etc).  But there was a new
use of VM_RESERVED that got missed by the merge.

Fix the remaining use of VM_RESERVED in the vfio_pci driver, replacing
the VM_RESERVED flag with VM_DONTEXPAND | VM_DONTDUMP.

Signed-off-by: Linus Torvalds

switch simple cases of fget_light to fdget

2012-09-27T02:20:08+00:00

Signed-off-by: Al Viro

switch vfio_group_set_container() to fget_light()

2012-09-27T01:10:09+00:00

Signed-off-by: Al Viro

vfio: Fix virqfd release race

2012-09-21T16:48:28+00:00

vfoi-pci supports a mechanism like KVM's irqfd for unmasking an
interrupt through an eventfd.  There are two ways to shutdown this
interface: 1) close the eventfd, 2) ioctl (such as disabling the
interrupt).  Both of these do the release through a workqueue,
which can result in a segfault if two jobs get queued for the same
virqfd.

Fix this by protecting the pointer to these virqfds by a spinlock.
The vfio pci device will therefore no longer have a reference to it
once the release job is queued under lock.  On the ioctl side, we
still flush the workqueue to ensure that any outstanding releases
are completed.

Signed-off-by: Alex Williamson

vfio: grab vfio_device reference before exposing the sucker via fd_install()

2012-08-22T14:26:42+00:00

It's not critical (anymore) since another thread closing the file will block
on ->device_lock before it gets to dropping the final reference, but it's
definitely cleaner that way...

Acked-by: Alex Williamson 
Signed-off-by: Al Viro

vfio: get rid of vfio_device_put()/vfio_group_get_device* races

2012-08-22T14:26:13+00:00

we really need to make sure that dropping the last reference happens
under the group->device_lock; otherwise a loop (under device_lock)
might find vfio_device instance that is being freed right now, has
already dropped the last reference and waits on device_lock to exclude
the sucker from the list.

Acked-by: Alex Williamson 
Signed-off-by: Al Viro

vfio: get rid of open-coding kref_put_mutex

2012-08-22T14:25:19+00:00

Acked-by: Alex Williamson 
Signed-off-by: Al Viro