linux-toradex.git/drivers/vhost, branch v4.9.71

fix a page leak in vhost_scsi_iov_to_sgl() error recovery

2017-11-30T08:39:05+00:00

commit 11d49e9d089ccec81be87c2386dfdd010d7f7f6e upstream.

we are advancing sg as we go, so the pages we need to drop in
case of error are *before* the current sg.

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

vhost_net: correctly check tx avail during rx busy polling

2017-09-20T06:19:56+00:00

[ Upstream commit 8b949bef9172ca69d918e93509a4ecb03d0355e0 ]

We check tx avail through vhost_enable_notify() in the past which is
wrong since it only checks whether or not guest has filled more
available buffer since last avail idx synchronization which was just
done by vhost_vq_avail_empty() before. What we really want is checking
pending buffers in the avail ring. Fix this by calling
vhost_vq_avail_empty() instead.

This issue could be noticed by doing netperf TCP_RR benchmark as
client from guest (but not host). With this fix, TCP_RR from guest to
localhost restores from 1375.91 trans per sec to 55235.28 trans per
sec on my laptop (Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz).

Fixes: 030881372460 ("vhost_net: basic polling support")
Signed-off-by: Jason Wang 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

vhost/vsock: handle vhost_vq_init_access() error

2017-06-17T04:41:57+00:00

[ Upstream commit 0516ffd88fa0d006ee80389ce14a9ca5ae45e845 ]

Propagate the error when vhost_vq_init_access() fails and set
vq->private_data to NULL.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

vhost: fix initialization for vq->is_le

2017-02-09T07:08:28+00:00

commit cda8bba0f99d25d2061c531113c14fa41effc3ae upstream.

Currently, under certain circumstances vhost_init_is_le does just a part
of the initialization job, and depends on vhost_reset_is_le being called
too. For this reason vhost_vq_init_access used to call vhost_reset_is_le
when vq->private_data is NULL. This is not only counter intuitive, but
also real a problem because it breaks vhost_net. The bug was introduced to
vhost_net with commit 2751c9882b94 ("vhost: cross-endian support for
legacy devices"). The symptom is corruption of the vq's used.idx field
(virtio) after VHOST_NET_SET_BACKEND was issued as a part of the vhost
shutdown on a vq with pending descriptors.

Let us make sure the outcome of vhost_init_is_le never depend on the state
it is actually supposed to initialize, and fix virtio_net by removing the
reset from vhost_vq_init_access.

With the above, there is no reason for vhost_reset_is_le to do just half
of the job. Let us make vhost_reset_is_le reinitialize is_le.

Signed-off-by: Halil Pasic 
Reported-by: Michael A. Tebolt 
Reported-by: Dr. David Alan Gilbert 
Fixes: commit 2751c9882b94 ("vhost: cross-endian support for legacy devices")
Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Greg Kurz 
Tested-by: Michael A. Tebolt 
Signed-off-by: Greg Kroah-Hartman

vhost-vsock: fix orphan connection reset

2016-12-09T02:24:30+00:00

local_addr.svm_cid is host cid. We should check guest cid instead,
which is remote_addr.svm_cid. Otherwise we end up resetting all
connections to all guests.

Cc: stable@vger.kernel.org [4.8+]
Reviewed-by: Stefan Hajnoczi 
Signed-off-by: Peng Tao 
Signed-off-by: David S. Miller

Merge 4.8-rc5 into char-misc-next

2016-09-05T06:04:07+00:00

We want the fixes in here for merging and testing.

Signed-off-by: Greg Kroah-Hartman

miscdevice: Add helper macro for misc device boilerplate

2016-08-31T12:12:35+00:00

Many modules call misc_register and misc_deregister in its module init
and exit methods without any additional code. This ends up being
boilerplate. This patch adds helper macro module_misc_device(), that
replaces module_init()/ module_exit() with template functions.

This patch also converts drivers to use new macro.

Change since v1:
Add device.h include in miscdevice.h as module_driver macro was not
available from other include files in some architectures.

Signed-off-by: PrasannaKumar Muralidharan 
Signed-off-by: Greg Kroah-Hartman

vhost/scsi: fix reuse of &vq->iov[out] in response

2016-08-23T14:16:57+00:00

The address of the iovec &vq->iov[out] is not guaranteed to contain the scsi
command's response iovec throughout the lifetime of the command.  Rather, it
is more likely to contain an iovec from an immediately following command
after looping back around to vhost_get_vq_desc().  Pass along the iovec
entirely instead.

Fixes: 79c14141a487 ("vhost/scsi: Convert completion path to use copy_to_iter")
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Coddington 
Signed-off-by: Michael S. Tsirkin

vhost/test: fix after swiotlb changes

2016-08-15T02:05:51+00:00

Signed-off-by: Michael S. Tsirkin

vhost/vsock: fix vhost virtio_vsock_pkt use-after-free

2016-08-09T10:42:37+00:00

Stash the packet length in a local variable before handing over
ownership of the packet to virtio_transport_recv_pkt() or
virtio_transport_free_pkt().

This patch solves the use-after-free since pkt is no longer guaranteed
to be alive.

Reported-by: Dan Carpenter 
Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Michael S. Tsirkin