linux-toradex.git/drivers/video/fbdev/amba-clcd.c, branch v4.15-rc2

video: ARM CLCD: constify amba_id

2017-09-04T14:00:49+00:00

amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav 
Cc: Russell King 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ARM CLCD: fix dma allocation size

2017-04-07T15:03:24+00:00

This patch forces the frambuffer size to be aligned on kernel pages.

During the board startup, the splash screed did appear;
the "ts_test" program or our application were not able to start.

The following error message was reported:
error: failed to map framebuffer device to memory.
LinuxFB: driver cannot connect

The issue was discovered, on the LPC32xx platform, during the migration
of the LCD definition from the board file to the device tree.

Signed-off-by: Liam Beguin 
Signed-off-by: Sylvain Lemieux 
Cc: Vladimir Zapolskiy 
Cc: Russell King 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ARM CLCD: use panel device node for getting backlight and mode

2017-01-30T16:39:48+00:00

Having obtained panel device node in clcdfb_of_init_display() it allows to
generalize and simplify two more helper functions clcdfb_of_get_backlight()
and clcdfb_of_get_mode().

Cc: Tomi Valkeinen 
Cc: Russell King 
Cc: Linus Walleij 
Cc: Arnd Bergmann 
Signed-off-by: Vladimir Zapolskiy 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ARM CLCD: use panel device node for panel initialization

2017-01-30T16:39:48+00:00

There is no necessity to pass an endpoint device node to custom panel
initialization functions, because a child panel device node should be
sufficient, note that the existing init_panel() callback declaration from
linux/amba/clcd.h already prompts to use the panel device node here.

Cc: Tomi Valkeinen 
Cc: Russell King 
Cc: Linus Walleij 
Cc: Arnd Bergmann 
Signed-off-by: Vladimir Zapolskiy 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ARM CLCD: sort included headers out alphabetically

2017-01-30T16:39:48+00:00

To simplify the task of looking through the list of included headers sort
them out alphabetically, some of the truly redundant headers are removed
from the list.

Cc: Tomi Valkeinen 
Cc: Russell King 
Cc: Linus Walleij 
Cc: Arnd Bergmann 
Signed-off-by: Vladimir Zapolskiy 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ARM CLCD: fix endpoint lookup logic

2016-08-30T08:31:22+00:00

The addition of the Nomadik support in this driver introduced
a bug in clcdfb_of_init_display(), which now calls init_panel
with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized"
warns:

drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display':
drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This reverts the broken part of the function to what it was before
the patch, which is the best guess I have to what it should be.
I assume this was left over from an attempted rework of the
code that was partially backed out.

Signed-off-by: Arnd Bergmann 
Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant")
Cc: Linus Walleij 
Reviewed-by: Linus Walleij 
Reported-by: Colin Ian King 
Signed-off-by: Tomi Valkeinen

video: ARM CLCD: add special panel hook for Versatiles

2016-08-11T14:54:54+00:00

This adds a special panel init hook for the ARM reference designs
Integrator (IM-PD1), Versatile and RealView, so we can configure
a DPI panel from device tree and have it working without
boardfiles for these machines.

Basically this is the same code as from the board files, just
moved over to look up the syscon DT node and manipulate the
special CLCD register from their regmap.

Tested on RealView PB11MPcore.

Cc: Pawel Moll 
Cc: Rob Herring 
Cc: Russell King 
Signed-off-by: Linus Walleij 
Signed-off-by: Tomi Valkeinen

video: ARM CLCD: add special board and panel hooks for Nomadik

2016-08-11T14:54:54+00:00

In the .board_init() callback will set up a mux register in
the Nomadik system controller. It so happens that the platform
has two display output engines, and we have to poke a bit in
a special register to make sure the right engine is muxed in
as they are mutually exclusive.

The Nomadik CLCD variant is instantiated on a platform where
it is combined with a 800x480 TPO WVGA display. In the
.panel_init() hook we will detect this display from the
compatible string and set it up. We also add .enable() and
.disable() callbacks for it as the sleep state is software
controlled.

The display is connected with a special 3-wire serial bus
(this is sadly neither I2C or SPI) using three GPIO lines that
we bitbang to detect the display and enable/disable sleep
state.

Cc: Pawel Moll 
Cc: Rob Herring 
Cc: Russell King 
Signed-off-by: Linus Walleij 
Signed-off-by: Tomi Valkeinen

video: ARM CLCD: support Nomadik variant

2016-08-11T14:54:53+00:00

The Nomadik variant has a few special quirks that need to be respected
to make the driver work:

- The block need to be clocked during writing of the TIMn registers
  or the bus will stall.
- Special bits in the control register select how many of the output
  display lines get activated.
- Special bits in the control register select how to manage the
  different 565 and 5551 modes.
- There is a packed 24bit graphics mode, i.e 888 pixels can be stored
  in memory is three consecutive bytes, not evenly aligned to a 32bit
  word.

This patch uses the vendor data pointer from the AMBA matching mechanism
to track the quirks for this variant, and adds two hooks that variants
can use to initialize boards and panels during start-up. These will
later be used to adopt a Nomadik board profile.

Cc: Pawel Moll 
Cc: Rob Herring 
Cc: Russell King 
Signed-off-by: Linus Walleij 
Signed-off-by: Tomi Valkeinen

video: ARM CLCD: support pads connected in reverse order

2016-08-11T14:54:53+00:00

There are CLCDs connected with the pads in BGR rather than RGB
order. It really doesn't matter since the CLCD has a flag and
a bit to switch the position of the RGB and BGR components.
This is needed to put something logical into the
arm,pl11x,tft-r0g0b0-pads property of the device tree on the
Nomadik which will then be <16 8 0>.

Cc: Pawel Moll 
Cc: Rob Herring 
Cc: Russell King 
Signed-off-by: Linus Walleij 
Signed-off-by: Tomi Valkeinen