linux-toradex.git/drivers/video/fbdev/sa1100fb.c, branch v5.4 Linux kernel for Apalis and Colibri modules video: sa1100fb: Remove cpufreq policy notifier 2019-08-26T08:02:02+00:00 Viresh Kumar viresh.kumar@linaro.org 2019-07-23T06:14:07+00:00 eb58a4fad3432be6e9dc2e35b78ae99f4a40ce5f The cpufreq policy notifier's CPUFREQ_ADJUST notification is going to get removed soon. The notifier callback sa1100fb_freq_policy() isn't doing anything apart from printing a debug message on CPUFREQ_ADJUST notification. There is no point in keeping an otherwise empty callback and registering the notifier. Remove it. Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 
The cpufreq policy notifier's CPUFREQ_ADJUST notification is going to
get removed soon.

The notifier callback sa1100fb_freq_policy() isn't doing anything apart
from printing a debug message on CPUFREQ_ADJUST notification. There is
no point in keeping an otherwise empty callback and registering the
notifier.

Remove it.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
fbdev/sa1100fb: Remove dead code 2019-06-12T18:27:18+00:00 Daniel Vetter daniel.vetter@ffwll.ch 2019-05-28T09:02:36+00:00 390e5de11284a1615662a2773c73b71884310dbe Motivated because it contains a struct display, which is a fbcon internal data structure that I want to rename. It seems to have been formerly used in drivers, but that's very long time ago. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20190528090304.9388-6-daniel.vetter@ffwll.ch 
Motivated because it contains a struct display, which is a fbcon
internal data structure that I want to rename. It seems to have been
formerly used in drivers, but that's very long time ago.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190528090304.9388-6-daniel.vetter@ffwll.ch
video: sa1100fb: move pseudo palette into sa1100fb_info structure 2017-10-17T14:01:13+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:13+00:00 cb6bc3ff59e3ff7a6fba8ca6ee649d532b4e17f2 Move the pseudo palette inside the driver private data structure so we don't have to play tricks to cater for it. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Move the pseudo palette inside the driver private data structure so we
don't have to play tricks to cater for it.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: fix video memory allocation leak 2017-10-17T14:01:13+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:13+00:00 0ab76581a9fee0413c54907076fcd79fcc271843 Don't leak the video memory allocation if register_framebuffer() fails. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Don't leak the video memory allocation if register_framebuffer() fails.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: clean up failure path 2017-10-17T14:01:12+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:12+00:00 c244f8e48c9f1875101201eaa0ecd2bfb17a5405 We merely return from the failed path, so remove all the gotos and use return statements instead. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
We merely return from the failed path, so remove all the gotos and use
return statements instead.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: use devm_gpio_request_one() 2017-10-17T14:01:12+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:12+00:00 5634cbab489e8428f352f257b631c128b8dc869d Switch to using devm_gpio_request_one() to request the shannon gpio and move the request before the video memory allocation, so we request all device managed resources before this large allocation attempt. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Switch to using devm_gpio_request_one() to request the shannon gpio
and move the request before the video memory allocation, so we request
all device managed resources before this large allocation attempt.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: use devm_request_irq() 2017-10-17T14:01:12+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:12+00:00 f6fc8c9dbdc976e4933c5edc13764eafe9897313 Use devm_request_irq() to request the interrupt (a little earlier too) so we can avoid having to manually clean this up. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Use devm_request_irq() to request the interrupt (a little earlier too)
so we can avoid having to manually clean this up.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: use devm_ioremap_resource() 2017-10-17T14:01:12+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:12+00:00 df6b228768db032608edbc58f87bc77d23f94952 Use devm_ioremap_resource() to map the LCD controller memory region, and remove the unnecessary cleanup for this. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Use devm_ioremap_resource() to map the LCD controller memory region,
and remove the unnecessary cleanup for this.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: use devm_clk_get() 2017-10-17T14:01:12+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:12+00:00 e43064ccd4b47fcb25c7f6806da1e7368312edfe Use devm_clk_get() to get the clock for the LCD. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Use devm_clk_get() to get the clock for the LCD.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
video: sa1100fb: use devm_kzalloc() 2017-10-17T14:01:12+00:00 Russell King rmk+kernel@armlinux.org.uk 2017-10-17T14:01:12+00:00 ba1d36ba09becdc7f65e0140f13b31762ac31941 Use devm_kzalloc() when allocating the private data for the framebuffer device. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Use devm_kzalloc() when allocating the private data for the framebuffer
device.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>