linux-toradex.git/drivers/video/fbdev/udlfb.c, branch v5.11-rc2

video: fbdev: udlfb: fix kobj_to_dev.cocci warnings

2020-09-08T11:33:27+00:00

 Use kobj_to_dev() instead of container_of()

Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Cc: Denis Efremov 
Signed-off-by: kernel test robot 
Signed-off-by: Julia Lawall 
Cc: Bernie Thompson 
[b.zolnierkie: minor patch summary fixup]
[b.zolnierkie: removed "Fixes:" tag (not in upstream tree)]
Signed-off-by: Bartlomiej Zolnierkiewicz 
Link: https://patchwork.freedesktop.org/patch/msgid/alpine.DEB.2.22.394.2008262252270.2522@hadrien

video: udlfb: use true,false for bool variables

2020-05-06T17:30:25+00:00

Fix the following coccicheck warning:

drivers/video/fbdev/udlfb.c:67:12-19: WARNING: Assignment of 0/1 to bool
variable
drivers/video/fbdev/udlfb.c:68:12-20: WARNING: Assignment of 0/1 to bool
variable
drivers/video/fbdev/udlfb.c:69:12-18: WARNING: Assignment of 0/1 to bool
variable

Signed-off-by: Jason Yan 
Signed-off-by: Sam Ravnborg 
Link: https://patchwork.freedesktop.org/patch/msgid/20200422071836.49123-1-yanaijie@huawei.com

video: udlfb: don't restore fb_mmap after deferred IO cleanup

2019-12-03T09:11:16+00:00

Deferred IO now preserves the fb_ops.

Cc: Bernie Thompson 
Cc: linux-fbdev@vger.kernel.org
Reviewed-by: Daniel Vetter 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/0f12bb51a6f2a656571cd21230b7e9d5be320db4.1575022735.git.jani.nikula@intel.com

udlfb: Make dlfb_ops constant

2019-08-19T13:52:29+00:00

Static structure dlfb_ops, of type fb_ops, is not used except to be
copied into another variable. Hence make dlfb_ops constant to protect it
from unintended modification.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta 
Cc: Bernie Thompson 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Link: https://patchwork.freedesktop.org/patch/msgid/20190819075236.1051-1-nishkadg.linux@gmail.com

video: fbdev: don't print error message on framebuffer_alloc() failure

2019-06-28T10:30:08+00:00

framebuffer_alloc() can fail only on kzalloc() memory allocation
failure and since kzalloc() will print error message in such case
we can omit printing extra error message in drivers (which BTW is
what the majority of framebuffer_alloc() users is doing already).

Cc: "Bruno Prémont" 
Cc: Jiri Kosina 
Cc: Benjamin Tissoires 
Signed-off-by: Bartlomiej Zolnierkiewicz

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 262

2019-06-05T15:30:28+00:00

Based on 1 normalized pattern(s):

  this file is subject to the terms and conditions of the gnu general
  public license v2 see the file copying in the main directory of this
  archive for more details

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 11 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Alexios Zavras 
Reviewed-by: Allison Randal 
Reviewed-by: Richard Fontana 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190529141333.582369016@linutronix.de
Signed-off-by: Greg Kroah-Hartman

udlfb: introduce a rendering mutex

2019-04-01T15:46:57+00:00

Rendering calls may be done simultaneously from the workqueue,
dlfb_ops_write, dlfb_ops_ioctl, dlfb_ops_set_par and dlfb_dpy_deferred_io.
The code is robust enough so that it won't crash on concurrent rendering.

However, concurrent rendering may cause display corruption if the same
pixel is simultaneously being rendered. In order to avoid this corruption,
this patch adds a mutex around the rendering calls.

Signed-off-by: Mikulas Patocka 
Cc: Bernie Thompson 
Cc: Ladislav Michl 
Cc: 
[b.zolnierkie: replace "dlfb:" with "uldfb:" in the patch summary]
Signed-off-by: Bartlomiej Zolnierkiewicz

udlfb: fix sleeping inside spinlock

2019-04-01T15:46:56+00:00

If a framebuffer device is used as a console, the rendering calls
(copyarea, fillrect, imageblit) may be done with the console spinlock
held. On udlfb, these function call dlfb_handle_damage that takes a
blocking semaphore before acquiring an URB.

In order to fix the bug, this patch changes the calls copyarea, fillrect
and imageblit to offload USB work to a workqueue.

A side effect of this patch is 3x improvement in console scrolling speed
because the device doesn't have to be updated after each copyarea call.

Signed-off-by: Mikulas Patocka 
Cc: Bernie Thompson 
Cc: Ladislav Michl 
Cc: 
Signed-off-by: Bartlomiej Zolnierkiewicz

udlfb: delete the unused parameter for dlfb_handle_damage

2019-04-01T15:46:56+00:00

Remove the unused parameter "data" and unused variable "ret".

Signed-off-by: Mikulas Patocka 
Cc: Bernie Thompson 
Cc: Ladislav Michl 
Cc: 
Signed-off-by: Bartlomiej Zolnierkiewicz

udlfb: fix some inconsistent NULL checking

2018-12-20T18:13:07+00:00

In the current kernel, then kzalloc() can't fail for small allocations,
but if it did fail then we would have a NULL dereference in the error
handling.  Also in dlfb_usb_disconnect() if "info" were NULL then it
would cause an Oops inside the unregister_framebuffer() function but it
can't be NULL so let's remove that check.

Fixes: 68a958a915ca ("udlfb: handle unplug properly")
Signed-off-by: Dan Carpenter 
Cc: Bernie Thompson 
Cc: Mikulas Patocka 
Cc: Alexey Khoroshilov 
Cc: Colin Ian King 
Cc: Wen Yang 
[b.zolnierkie: added "Fixes:" tag]
Signed-off-by: Bartlomiej Zolnierkiewicz