linux-toradex.git/drivers/video/neofb.c, branch PD13.0.0alpha

neofb: fix sparse warnings

2009-01-06T23:59:27+00:00

Fix this sparse warnings:

  drivers/video/neofb.c:1456:4: warning: returning void-valued expression
  drivers/video/neofb.c:1464:3: warning: returning void-valued expression

Signed-off-by: Hannes Eder 
Cc: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: remove open_lock mutex

2008-10-16T18:21:42+00:00

Remove mutex from the fb_open/fb_release functions as these operations are
mutexed at fb layer.

Signed-off-by: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: kill some redundant code

2008-10-16T18:21:42+00:00

Move common code outside if/else or switch/case clauses.

Drop checks done twice inside the neofb_check_var().

Signed-off-by: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: reduce panning function

2008-10-16T18:21:41+00:00

Reduce panning function by deleting checks done by higher layer and
folding remaining function into the called one.

Signed-off-by: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: drop the xtimings structure

2008-07-24T17:47:41+00:00

Remove the xtimings structure which only stored some values to be used
later (mostly once).  Calculate and use these values in places they are
needed.

Signed-off-by: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: drop redundant code

2008-07-24T17:47:41+00:00

Drop structure which is only set but never read.  Drop variables which are
only set and never read.  Convert one long switch into two shorter ones.

Add cpu_relax() in busy waiting loop.

Signed-off-by: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: simplify clock calculation

2008-07-24T17:47:41+00:00

There is nothing to gain by converting value in kHz to fixed point MHz.
Just calculate everything in kHz.

A reorder of the loop allows reducing number of iterations (check if
frequency is not too high already).

Signed-off-by: Krzysztof Helt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: avoid overwriting fb_info fields

2008-02-06T18:41:16+00:00

Fix bug identified by Marcio Buss in
http://bugzilla.kernel.org/show_bug.cgi?id=9565 - neofb can overwrite a field
in the fb_info struct.

This fix will result in truncated device identification strings - perhaps
fb_innfo.fix.id can be made larger?

Cc: Marcio Buss 
Cc: "Antonino A. Daplas" 
Cc: Christian Trefzer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fbdev: change asm/uaccess.h to linux/uaccess.h

2007-10-16T16:43:17+00:00

This patch replaces  with  after the
checkpatch.pl hint.  The include of  is removed if the driver
does not use it.

Signed-off-by: Krzysztof Helt 
Signed-off-by: Antonino Daplas 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

neofb: Fix pseudo_palette array overrun in neofb_setcolreg

2007-05-31T14:48:27+00:00

The pseudo_palette has room for 16 entries only, but in truecolor mode, it
attempts to write 256.

Signed-off-by: Antonino Daplas 
Acked-by: Tero Roponen 
Signed-off-by: Linus Torvalds