linux-toradex.git/drivers/video/sm501fb.c, branch v2.6.32.2

sm501fb: fix regression with uninitalized fb_info->mm_lock mutex

2009-07-10T03:44:44+00:00

Remove call to the fb_set_par() before the register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex
introduced by the commit 537a1bf059f " fbdev: add mutex for fb_mmap
locking"

Signed-off-by: Krzysztof Helt 
Signed-off-by: Linus Torvalds

Revert "fb: Initialize fb_info mutexes in framebuffer_alloc()"

2009-07-08T16:20:11+00:00

This reverts commit 4148df9b0f38bdd362dd91d52076926c11cbe5a9.

Let's hope that the mm_lock initialization is now correct with all
drivers, following Krzysztof's patches.

Requested-by: Krzysztof Helt 
Signed-off-by: Linus Torvalds

fb: Initialize fb_info mutexes in framebuffer_alloc()

2009-07-06T21:02:50+00:00

This way they'll be properly initialized early enough for users that may
touch them before the framebuffer has been registered.

Drivers that allocate their fb_info structure some other way (like
matrocfb's broken static allocation) need to be fixed up appropriately.

Signed-off-by: Paul Mundt 
Signed-off-by: Linus Torvalds

video: sm501fb: Early initialization of mm_lock mutex.

2009-07-04T17:39:06+00:00

Commit 537a1bf059fa312355696fa6db80726e655e7f17 (fbdev: add mutex for
fb_mmap locking) introduces a ->mm_lock mutex for protecting smem
assignments. Unfortunately in the case of sm501fb these happen quite
early in the initialization code, well before the mutex_init() that takes
place in register_framebuffer(), leading to:

   Badness at kernel/mutex.c:207

   Pid : 1, Comm:          swapper
   CPU : 0                 Not tainted  (2.6.31-rc1-00284-g529ba0d-dirty #2273)

   PC is at __mutex_lock_slowpath+0x72/0x1bc
   PR is at __mutex_lock_slowpath+0x66/0x1bc
   ...

matroxfb appears to have the same issue and has solved it with an early
mutex_init(), so we do the same for sm501fb.

Signed-off-by: Paul Mundt 
Cc: Krzysztof Helt 
Signed-off-by: Linus Torvalds

fbdev: add mutex for fb_mmap locking

2009-07-01T01:56:00+00:00

Add a mutex to avoid a circular locking problem between the mm layer
semaphore and fbdev ioctl mutex through the fb_mmap() call.

Also, add mutex to all places where smem_start and smem_len fields change
so the mutex inside the fb_mmap() is actually used.  Changing of these
fields before calling the framebuffer_register() are not mutexed.

This is 2.6.31 material.  It removes one lockdep (fb_mmap() and
register_framebuffer()) but there is still another one (fb_release() and
register_framebuffer()).  It also cleans up handling of the smem_start and
smem_len fields used by mutexed section of the fb_mmap().

Signed-off-by: Krzysztof Helt 
Cc: Peter Zijlstra 
Cc: "Rafael J. Wysocki" 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sm501fb: check fb_alloc_cmap return value and handle failure properly

2009-04-01T15:59:30+00:00

Signed-off-by: Andres Salomon 
Acked-by: Krzysztof Helt 
Cc: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sm501: unsigned ptr cannot be negative

2009-01-06T23:59:27+00:00

unsigned ptr cannot be negative

Signed-off-by: Roel Kluin 
Cc: Krzysztof Helt 
Cc: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sm501: fixup allocation code to be 64bit resource compliant

2008-07-24T17:47:40+00:00

As pointed out by Andrew Morton, we have a problem when setting the 64bit
resources option.  Alter the allocation routines to remove the need to use
the start and end fields, use the proper HEAD_PANEL/HEAD_CRT and update
the comments.

Note, we also fix the bug where we failed to check the size of the
CRT memory allocation.

[akpm@linux-foundation.org: cleanup]
Signed-off-by: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sm501: restructure init to allow only 1 fb on an SM501

2008-07-24T17:47:40+00:00

Add the ability to register only one of the two possible main framebuffer
devices on the SM501 by passing platform data for only the framebuffer
that you are interested in having.

As a side note, we update the init sequence to commonise the code that is
executed twice, and fix a pair of missing frees that we didn't do on
framebuffer exit, such as freeing the fb's cmap.

Signed-off-by: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sm501: add inversion controls for VBIASEN and FPEN

2008-07-24T17:47:40+00:00

Add flags to allow the driver to invert the sense of both VBIASEN and FPEN
signals comming from the SM501.

Signed-off-by: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds