linux-toradex.git/drivers/video, branch v3.2.32

OMAPFB: fix framebuffer console colors

2012-09-19T14:04:31+00:00

commit c1c52848cef52e157468b8879fc3cae23b6f3a99 upstream.

omapfb does not currently set pseudo palette correctly for color depths
above 16bpp, making red text invisible, command like
  echo -e '\e[0;31mRED' > /dev/tty1
will display nothing on framebuffer console in 24bpp mode.
This is because temporary variable is declared incorrectly, fix it.

Signed-off-by: Grazvydas Ignotas 
Signed-off-by: Tomi Valkeinen 
Signed-off-by: Florian Tobias Schandinat 
Signed-off-by: Ben Hutchings

fbcon: fix race condition between console lock and cursor timer (v1.1)

2012-09-12T02:37:24+00:00

commit d8636a2717bb3da2a7ce2154bf08de90bb8c87b0 upstream.

So we've had a fair few reports of fbcon handover breakage between
efi/vesafb and i915 surface recently, so I dedicated a couple of
days to finding the problem.

Essentially the last thing we saw was the conflicting framebuffer
message and that was all.

So after much tracing with direct netconsole writes (printks
under console_lock not so useful), I think I found the race.

Thread A (driver load)    Thread B (timer thread)
  unbind_con_driver ->              |
  bind_con_driver ->                |
  vc->vc_sw->con_deinit ->          |
  fbcon_deinit ->                   |
  console_lock()                    |
      |                             |
      |                       fbcon_flashcursor timer fires
      |                       console_lock() <- blocked for A
      |
      |
fbcon_del_cursor_timer ->
  del_timer_sync
  (BOOM)

Of course because all of this is under the console lock,
we never see anything, also since we also just unbound the active
console guess what we never see anything.

Hopefully this fixes the problem for anyone seeing vesafb->kms
driver handoff.

v1.1: add comment suggestion from Alan.

Signed-off-by: Dave Airlie 
Signed-off-by: Ben Hutchings

video/smscufx: fix line counting in fb_write

2012-08-09T23:24:51+00:00

commit 2fe2d9f47cfe1a3e66e7d087368b3d7155b04c15 upstream.

Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display
was never overwritten by writes to /dev/fbN.

The origin of this bug seems to have been udlfb.

Signed-off-by: Alexander Holler 
Signed-off-by: Florian Tobias Schandinat 
Signed-off-by: Ben Hutchings

OMAPDSS: VENC: fix NULL pointer dereference in DSS2 VENC sysfs debug attr on OMAP4

2012-05-30T23:43:55+00:00

commit cc1d3e032df53d83d0ca4d537d8eb67eb5b3e808 upstream.

Commit ba02fa37de80bea10d706f39f076dd848348320a disabled the
venc driver registration on OMAP4. Since the driver never gets
probed/initialised your get a dereferenceed NULL pointer if you
try to get info from /sys/kernel/debug/omapdss/venc

Return info message about disabled venc if venc_dump_regs() gets called.

Signed-off-by: Danny Kukawka 
Signed-off-by: Tomi Valkeinen 
Signed-off-by: Ben Hutchings

video:uvesafb: Fix oops that uvesafb try to execute NX-protected page

2012-04-22T22:31:01+00:00

commit b78f29ca0516266431688c5eb42d39ce42ec039a upstream.

This patch fix the oops below that catched in my machine

[   81.560602] uvesafb: NVIDIA Corporation, GT216 Board - 0696a290, Chip Rev   , OEM: NVIDIA, VBE v3.0
[   81.609384] uvesafb: protected mode interface info at c000:d350
[   81.609388] uvesafb: pmi: set display start = c00cd3b3, set palette = c00cd40e
[   81.609390] uvesafb: pmi: ports = 3b4 3b5 3ba 3c0 3c1 3c4 3c5 3c6 3c7 3c8 3c9 3cc 3ce 3cf 3d0 3d1 3d2 3d3 3d4 3d5 3da
[   81.614558] uvesafb: VBIOS/hardware doesn't support DDC transfers
[   81.614562] uvesafb: no monitor limits have been set, default refresh rate will be used
[   81.614994] uvesafb: scrolling: ypan using protected mode interface, yres_virtual=4915
[   81.744147] kernel tried to execute NX-protected page - exploit attempt? (uid: 0)
[   81.744153] BUG: unable to handle kernel paging request at c00cd3b3
[   81.744159] IP: [] 0xc00cd3b2
[   81.744167] *pdpt = 00000000016d6001 *pde = 0000000001c7b067 *pte = 80000000000cd163
[   81.744171] Oops: 0011 [#1] SMP
[   81.744174] Modules linked in: uvesafb(+) cfbcopyarea cfbimgblt cfbfillrect
[   81.744178]
[   81.744181] Pid: 3497, comm: modprobe Not tainted 3.3.0-rc4NX+ #71 Acer            Aspire 4741                    /Aspire 4741
[   81.744185] EIP: 0060:[] EFLAGS: 00010246 CPU: 0
[   81.744187] EIP is at 0xc00cd3b3
[   81.744189] EAX: 00004f07 EBX: 00000000 ECX: 00000000 EDX: 00000000
[   81.744191] ESI: f763f000 EDI: f763f6e8 EBP: f57f3a0c ESP: f57f3a00
[   81.744192]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
[   81.744195] Process modprobe (pid: 3497, ti=f57f2000 task=f748c600 task.ti=f57f2000)
[   81.744196] Stack:
[   81.744197]  f82512c5 f759341c 00000000 f57f3a30 c124a9bc 00000001 00000001 000001e0
[   81.744202]  f8251280 f763f000 f7593400 00000000 f57f3a40 c12598dd f5c0c000 00000000
[   81.744206]  f57f3b10 c1255efe c125a21a 00000006 f763f09c 00000000 c1c6cb60 f7593400
[   81.744210] Call Trace:
[   81.744215]  [] ? uvesafb_pan_display+0x45/0x60 [uvesafb]
[   81.744222]  [] fb_pan_display+0x10c/0x160
[   81.744226]  [] ? uvesafb_vbe_find_mode+0x180/0x180 [uvesafb]
[   81.744230]  [] bit_update_start+0x1d/0x50
[   81.744232]  [] fbcon_switch+0x39e/0x550
[   81.744235]  [] ? bit_cursor+0x4ea/0x560
[   81.744240]  [] redraw_screen+0x12b/0x220
[   81.744245]  [] ? tty_do_resize+0x3b/0xc0
[   81.744247]  [] vc_do_resize+0x3d2/0x3e0
[   81.744250]  [] vc_resize+0x14/0x20
[   81.744253]  [] fbcon_init+0x29d/0x500
[   81.744255]  [] ? set_inverse_trans_unicode+0xe4/0x110
[   81.744258]  [] visual_init+0xb8/0x150
[   81.744261]  [] bind_con_driver+0x16c/0x360
[   81.744264]  [] ? register_con_driver+0x6e/0x190
[   81.744267]  [] take_over_console+0x41/0x50
[   81.744269]  [] fbcon_takeover+0x6a/0xd0
[   81.744272]  [] fbcon_event_notify+0x758/0x790
[   81.744277]  [] notifier_call_chain+0x42/0xb0
[   81.744280]  [] __blocking_notifier_call_chain+0x60/0x90
[   81.744283]  [] blocking_notifier_call_chain+0x1a/0x20
[   81.744285]  [] fb_notifier_call_chain+0x11/0x20
[   81.744288]  [] register_framebuffer+0x1d9/0x2b0
[   81.744293]  [] ? ioremap_wc+0x33/0x40
[   81.744298]  [] uvesafb_probe+0xaba/0xc40 [uvesafb]
[   81.744302]  [] platform_drv_probe+0xf/0x20
[   81.744306]  [] driver_probe_device+0x68/0x170
[   81.744309]  [] __device_attach+0x41/0x50
[   81.744313]  [] bus_for_each_drv+0x48/0x70
[   81.744316]  [] device_attach+0x83/0xa0
[   81.744319]  [] ? __driver_attach+0x90/0x90
[   81.744321]  [] bus_probe_device+0x6f/0x90
[   81.744324]  [] device_add+0x5e5/0x680
[   81.744329]  [] ? kvasprintf+0x43/0x60
[   81.744332]  [] ? kobject_set_name_vargs+0x64/0x70
[   81.744335]  [] ? kobject_set_name_vargs+0x64/0x70
[   81.744339]  [] platform_device_add+0xff/0x1b0
[   81.744343]  [] uvesafb_init+0x50/0x9b [uvesafb]
[   81.744346]  [] do_one_initcall+0x2f/0x170
[   81.744350]  [] ? uvesafb_is_valid_mode+0x66/0x66 [uvesafb]
[   81.744355]  [] sys_init_module+0xf4/0x1410
[   81.744359]  [] ? vfsmount_lock_local_unlock_cpu+0x30/0x30
[   81.744363]  [] sysenter_do_call+0x12/0x36
[   81.744365] Code: f5 00 00 00 32 f6 66 8b da 66 d1 e3 66 ba d4 03 8a e3 b0 1c 66 ef b0 1e 66 ef 8a e7 b0 1d 66 ef b0 1f 66 ef e8 fa 00 00 00 61 c3 <60> e8 c8 00 00 00 66 8b f3 66 8b da 66 ba d4 03 b0 0c 8a e5 66
[   81.744388] EIP: [] 0xc00cd3b3 SS:ESP 0068:f57f3a00
[   81.744391] CR2: 00000000c00cd3b3
[   81.744393] ---[ end trace 18b2c87c925b54d6 ]---

Signed-off-by: Wang YanQing 
Cc: Michal Januszewski 
Cc: Alan Cox 
Signed-off-by: Florian Tobias Schandinat 
Signed-off-by: Greg Kroah-Hartman

backlight: fix typo in tosa_lcd.c

2012-04-02T16:53:06+00:00

commit 8da00edc1069f01c34510fa405dc15d96c090a3f upstream.

Fix typo in drivers/video/backlight/tosa_lcd.c
"tosa_lcd_reume" should be "tosa_lcd_resume".

Signed-off-by: Masanari Iida 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

udlfb: remove sysfs framebuffer device with USB .disconnect()

2012-04-02T16:52:45+00:00

commit ce880cb860f36694d2cdebfac9e6ae18176fe4c4 upstream.

The USB graphics card driver delays the unregistering of the framebuffer
device to a workqueue, which breaks the userspace visible remove uevent
sequence. Recent userspace tools started to support USB graphics card
hotplug out-of-the-box and rely on proper events sent by the kernel.

The framebuffer device is a direct child of the USB interface which is
removed immediately after the USB .disconnect() callback. But the fb device
in /sys stays around until its final cleanup, at a time where all the parent
devices have been removed already.

To work around that, we remove the sysfs fb device directly in the USB
.disconnect() callback and leave only the cleanup of the internal fb
data to the delayed work.

Before:
 add      /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2 (usb)
 add      /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0 (usb)
 add      /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/graphics/fb0 (graphics)
 remove   /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0 (usb)
 remove   /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2 (usb)
 remove   /2-1.2:1.0/graphics/fb0 (graphics)

After:
 add      /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2 (usb)
 add      /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0 (usb)
 add      /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/graphics/fb1 (graphics)
 remove   /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/graphics/fb1 (graphics)
 remove   /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0 (usb)
 remove   /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2 (usb)

Tested-by: Bernie Thompson 
Acked-by: Bernie Thompson 
Signed-off-by: Kay Sievers 
Signed-off-by: Florian Tobias Schandinat 
Signed-off-by: Greg Kroah-Hartman

OMAPDSS: HDMI: hot plug detect fix

2012-03-12T19:31:38+00:00

commit ca888a7958b3d808e4efd08ceff88913f4212c69 upstream.

The "OMAPDSS: HDMI: PHY burnout fix" commit switched the HDMI driver
over to using a GPIO for plug detect.  Unfortunately the ->detect()
method was not also updated, causing HDMI to no longer work for the
omapdrm driver (because it would actually check if a connection was
detected before attempting to enable display).

Signed-off-by: Rob Clark 
Signed-off-by: Tomi Valkeinen 
Signed-off-by: Greg Kroah-Hartman

OMAPDSS: HDMI: PHY burnout fix

2012-03-12T19:31:38+00:00

commit c49d005b6cc8491fad5b24f82805be2d6bcbd3dd upstream.

A hardware bug in the OMAP4 HDMI PHY causes physical damage to the board
if the HDMI PHY is kept powered on when the cable is not connected.

This patch solves the problem by adding hot-plug-detection into the HDMI
IP driver. This is not a real HPD support in the sense that nobody else
than the IP driver gets to know about the HPD events, but is only meant
to fix the HW bug.

The strategy is simple: If the display device is turned off by the user,
the PHY power is set to OFF. When the display device is turned on by the
user, the PHY power is set either to LDOON or TXON, depending on whether
the HDMI cable is connected.

The reason to avoid PHY OFF when the display device is on, but the cable
is disconnected, is that when the PHY is turned OFF, the HDMI IP is not
"ticking" and thus the DISPC does not receive pixel clock from the HDMI
IP. This would, for example, prevent any VSYNCs from happening, and
would thus affect the users of omapdss. By using LDOON when the cable is
disconnected we'll avoid the HW bug, but keep the HDMI working as usual
from the user's point of view.

Signed-off-by: Tomi Valkeinen 
Signed-off-by: Greg Kroah-Hartman

viafb: fix IGA1 modesetting on VX900

2012-03-12T19:31:35+00:00

commit e29206381a1436e0f47c0f5b9a23159a03c57715 upstream.

Even if the documentation calls this bit "Reserved" it has to be set
to 0 for correct modesetting on IGA1.

Signed-off-by: Florian Tobias Schandinat 
Signed-off-by: Greg Kroah-Hartman