linux-toradex.git/drivers/virtio/virtio_mmio.c, branch v3.18.14

virtio: unify config_changed handling

2014-10-14T23:54:54+00:00

Replace duplicated code in all transports with a single wrapper in
virtio.c.

The only functional change is in virtio_mmio.c: if a buggy device sends
us an interrupt before driver is set, we previously returned IRQ_NONE,
now we return IRQ_HANDLED.

As this must not happen in practice, this does not look like a big deal.

See also commit 3fff0179e33cd7d0a688dab65700c46ad089e934
	virtio-pci: do not oops on config change if driver not loaded.
for the original motivation behind the driver check.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Signed-off-by: Rusty Russell

virtio: mmio: fix signature checking for BE guests

2013-11-07T01:43:04+00:00

As virtio-mmio config registers are specified to be little-endian,
using readl() to read the magic value and then memcmp() to check it
fails on BE (as readl() has an implicit swab).

Fix it by encoding the magic value as an integer instead of a string.

Cc: Michael S. Tsirkin 
Signed-off-by: Marc Zyngier 
Acked-by: Pawel Moll 
Signed-off-by: Rusty Russell

virtio_ring: change host notification API

2013-10-29T00:58:11+00:00

Currently a host kick error is silently ignored and not reflected in
the virtqueue of a particular virtio device.

Changing the notify API for guest->host notification seems to be one
prerequisite in order to be able to handle such errors in the context
where the kick is triggered.

This patch changes the notify API. The notify function must return a
bool return value. It returns false if the host notification failed.

Signed-off-by: Heinz Graalfs 
Signed-off-by: Rusty Russell

virtio: make config_ops const

2013-02-11T05:02:17+00:00

It is just a table of function pointers, make it const for cleanliness and security
reasons.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Rusty Russell

virtio-mmio: fix wrong comment about register offset

2013-02-04T00:07:01+00:00

The register offset of InterruptACK is 0x064, not 0x060.
Fix it.

Signed-off-by: Ryota Ozaki 
Reviewed-by: Wanlong Gao 
Acked-by: Pawel Moll 
CC: Jiri Kosina 
Signed-off-by: Rusty Russell

Drivers: virtio: remove __dev* attributes.

2013-01-03T23:57:01+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, and __devexit
from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Signed-off-by: Greg Kroah-Hartman

virtio-mmio: Fix irq parsing in command line parameter

2012-12-18T04:50:41+00:00

When the resource_size_t is 64-bit long, the sscanf() on
the virtio device command line paramter string may return
wrong value because its format was defined as "%u". Fixed
by using an intermediate local value of a known length.

Also added cleaned up the resource creation and added extra
comments to make the parameters parsing easier to follow.

Reported-by: Lee Jones 
Signed-off-by: Pawel Moll 
Signed-off-by: Rusty Russell

virtio: move queue_index and num_free fields into core struct virtqueue.

2012-12-18T04:50:31+00:00

They're generic concepts, so hoist them.  This also avoids accessor
functions (though kept around for merge with DaveM's net tree).

This goes even further than Jason Wang's 17bb6d4088 patch
("virtio-ring: move queue_index to vring_virtqueue") which moved the
queue_index from the specific transport.

Acked-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell

virtio_mmio: Don't attempt to create empty virtqueues

2012-09-28T05:35:16+00:00

If a virtio device reports a QueueNumMax of 0, vring_new_virtqueue()
doesn't check this, and thanks to an unsigned (i < num - 1) loop
guard, scribbles over memory when initialising the free list.

Avoid by not trying to create zero-descriptor queues, as there's no
way to do any I/O with one.

Signed-off-by: Brian Foley 
Signed-off-by: Pawel Moll 
Signed-off-by: Rusty Russell

virtio_mmio: fix off by one error allocating queue

2012-09-28T05:35:16+00:00

vm_setup_vq fails to allow VirtQueues needing only 2 pages of
storage, as it should. Found with a kernel using 64kB pages, but
can be provoked if a virtio device reports QueueNumMax where the
descriptor table and available ring fit in one page, and the used
ring on the second (<= 227 descriptors with 4kB pages and <= 3640
with 64kB pages.)

Signed-off-by: Brian Foley 
Signed-off-by: Pawel Moll 
Signed-off-by: Rusty Russell