linux-toradex.git/drivers/virtio/virtio_pci.c, branch v3.14.50

virtio_pci: fix virtio spec compliance on restore

2014-11-14T16:59:50+00:00

commit 6fbc198cf623944ab60a1db6d306a4d55cdd820d upstream.

On restore, virtio pci does the following:
+ set features
+ init vqs etc - device can be used at this point!
+ set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits

This is in violation of the virtio spec, which
requires the following order:
- ACKNOWLEDGE
- DRIVER
- init vqs
- DRIVER_OK

This behaviour will break with hypervisors that assume spec compliant
behaviour.  It seems like a good idea to have this patch applied to
stable branches to reduce the support butden for the hypervisors.

Cc: Amit Shah 
Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell 
Signed-off-by: Greg Kroah-Hartman

virtio: pci: remove unnecessary pci_set_drvdata()

2013-12-04T03:50:26+00:00

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han 
Signed-off-by: Rusty Russell

virtio_ring: change host notification API

2013-10-29T00:58:11+00:00

Currently a host kick error is silently ignored and not reflected in
the virtqueue of a particular virtio device.

Changing the notify API for guest->host notification seems to be one
prerequisite in order to be able to handle such errors in the context
where the kick is triggered.

This patch changes the notify API. The notify function must return a
bool return value. It returns false if the host notification failed.

Signed-off-by: Heinz Graalfs 
Signed-off-by: Rusty Russell

virtio_pci: pm: Use CONFIG_PM_SLEEP instead of CONFIG_PM

2013-09-09T00:32:53+00:00

The virtio_pci_freeze/restore are defined under CONFIG_PM but is used
by SET_SYSTEM_SLEEP_PM_OPS macro, which is defined under
CONFIG_PM_SLEEP. So if CONFIG_PM_SLEEP is not cofigured but
CONFIG_PM_RUNTIME is, the following warning message appeared:

drivers/virtio/virtio_pci.c:770:12: warning: ‘virtio_pci_freeze’ defined but not used [-Wunused-function]
 static int virtio_pci_freeze(struct device *dev)
            ^
drivers/virtio/virtio_pci.c:790:12: warning: ‘virtio_pci_restore’ defined but not used [-Wunused-function]
 static int virtio_pci_restore(struct device *dev)
            ^
Fix it by changing CONFIG_PM to CONFIG_PM_SLEEP.

Signed-off-by: Aaron Lu 
Reviewed-by: Amit Shah 
Signed-off-by: Rusty Russell

virtio-pci: fix leaks of msix_affinity_masks

2013-07-02T06:12:02+00:00

vp_dev->msix_vectors should be initialized before allocating
msix_affinity_masks, otherwise vp_free_vectors will not free these
objects.

unreferenced object 0xffff88010f969d88 (size 512):
  comm "systemd-udevd", pid 158, jiffies 4294673645 (age 80.545s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [] kmemleak_alloc+0x5e/0xc0
    [] kmem_cache_alloc_node_trace+0x141/0x2c0
    [] alloc_cpumask_var_node+0x23/0x80
    [] alloc_cpumask_var+0xe/0x10
    [] vp_try_to_find_vqs+0x25d/0x810
    [] vp_find_vqs+0x81/0xb0
    [] init_vqs+0x85/0x120 [virtio_balloon]
    [] virtballoon_probe+0xf9/0x1a0 [virtio_balloon]
    [] virtio_dev_probe+0xde/0x140
    [] driver_probe_device+0x98/0x3a0
    [] __driver_attach+0xab/0xb0
    [] bus_for_each_dev+0x94/0xb0
    [] driver_attach+0x1e/0x20
    [] bus_add_driver+0x200/0x280
    [] driver_register+0x74/0x160
    [] register_virtio_driver+0x20/0x40

v2: change msix_vectors uncoditionaly in vp_free_vectors

Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Cc: Jason Wang 
Signed-off-by: Andrew Vagin 
Acked-by: Michael S. Tsirkin 
Acked-by: Jason Wang 
Signed-off-by: Rusty Russell

virtio: make pci_device_id const

2013-02-11T05:02:18+00:00

Use DEVICE_TABLE macro which also makes table const.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Rusty Russell

virtio: make config_ops const

2013-02-11T05:02:17+00:00

It is just a table of function pointers, make it const for cleanliness and security
reasons.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Rusty Russell

Drivers: virtio: remove __dev* attributes.

2013-01-03T23:57:01+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, and __devexit
from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Signed-off-by: Greg Kroah-Hartman

virtio: move queue_index and num_free fields into core struct virtqueue.

2012-12-18T04:50:31+00:00

They're generic concepts, so hoist them.  This also avoids accessor
functions (though kept around for merge with DaveM's net tree).

This goes even further than Jason Wang's 17bb6d4088 patch
("virtio-ring: move queue_index to vring_virtqueue") which moved the
queue_index from the specific transport.

Acked-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell

virtio-pci: use module_pci_driver to simplify the code

2012-12-18T04:50:30+00:00

Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun 
Signed-off-by: Rusty Russell