linux-toradex.git/drivers/virtio/virtio_pci_common.c, branch v4.1.26

virtio_pci: fix use after free on release

2016-02-15T20:45:22+00:00

[ Upstream commit 2989be09a8a9d62a785137586ad941f916e08f83 ]

KASan detected a use-after-free error in virtio-pci remove code. In
virtio_pci_remove(), vp_dev is still used after being freed in
unregister_virtio_device() (in virtio_pci_release_dev() more
precisely).

To fix, keep a reference until cleanup is done.

Fixes: 63bd62a08ca4 ("virtio_pci: defer kfree until release callback")
Reported-by: Jerome Marchand 
Cc: stable@vger.kernel.org
Cc: Sasha Levin 
Signed-off-by: Michael S. Tsirkin 
Tested-by: Jerome Marchand 
Signed-off-by: Sasha Levin

virtio_pci: Clear stale cpumask when setting irq affinity

2015-06-04T12:47:49+00:00

The cpumask vp_dev->msix_affinity_masks[info->msix_vector] may contain
staled information when vp_set_vq_affinity() gets called, so clear it
before setting the new cpu bit mask.

Cc: stable@vger.kernel.org
Signed-off-by: Jiang Liu 
Signed-off-by: Michael S. Tsirkin

virtio_pci: add module param to force legacy mode

2015-01-21T05:59:01+00:00

If set, try legacy interface first, modern one if that fails.  Useful to
work around device/driver bugs, and for compatibility testing.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell

virtio_pci: modern driver

2015-01-21T05:58:53+00:00

Lightly tested against qemu.

One thing *not* implemented here is separate mappings
for descriptor/avail/used rings. That's nice to have,
will be done later after we have core support.

This also exposes the PCI layout to userspace, and
adds macros for PCI layout offsets:

QEMU wants it, so why not?  Trust, but verify.

Signed-off-by: Rusty Russell 
Signed-off-by: Michael S. Tsirkin

virtio_pci: move probe/remove code to common

2015-01-21T05:58:51+00:00

Most of initialization is device-independent.
Let's move it to common.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell

virtio_pci: device-specific release callback

2015-01-06T14:35:36+00:00

It turns out we need to add device-specific code
in release callback. Move it to virtio_pci_legacy.c.

Signed-off-by: Michael S. Tsirkin

virtio: make del_vqs idempotent

2015-01-06T14:35:35+00:00

Our code calls del_vqs multiple times, assuming
it's idempotent.

commit 3ec7a77bb3089bb01032fdbd958eb5c29da58b49
    virtio_pci: free up vq->priv
broke this assumption, by adding kfree there,
so multiple calls cause double free.

Fix it up.

Fixes: 3ec7a77bb3089bb01032fdbd958eb5c29da58b49
Reported-by: Sasha Levin 
Signed-off-by: Michael S. Tsirkin

virtio_pci: restore module attributes

2014-12-16T22:59:40+00:00

When the virtio_pci driver was moved into virtio_pci_legacy.c the module
licence and other attributes went AWOL.  This patch restores them.

Signed-off-by: Herbert Xu 
Signed-off-by: Michael S. Tsirkin

virtio_pci: move probe to common file

2014-12-14T13:10:30+00:00

It turns out this make everything easier.

Signed-off-by: Michael S. Tsirkin

virtio_pci: rename virtio_pci -> virtio_pci_common

2014-12-09T19:42:05+00:00

kbuild does not seem to like it when we name source
files same as the module.
Let's rename virtio_pci -> virtio_pci_common,
and get rid of #include-ing c files.

Signed-off-by: Michael S. Tsirkin