linux-toradex.git/drivers/w1/masters/ds2490.c, branch v4.14

w1: ds2490: constify usb_device_id and fix space before '[' error

2017-08-28T15:18:19+00:00

usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by  work with
const usb_device_id. So mark the non-const structs as const.

Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.

Signed-off-by: Arvind Yadav 
Signed-off-by: Greg Kroah-Hartman

w1: Add subsystem kernel public interface

2017-06-09T09:54:54+00:00

Like other subsystems we should be able to define slave devices outside
of the w1 directory. To do this we move public facing interface
definitions to include/linux/w1.h and rename the internal definition
file to w1_internal.h.

As w1_family.h and w1_int.h contained almost entirely public
driver interface definitions we simply removed these files and
moved the remaining definitions into w1_internal.h.

With this we can now start to move slave devices out of w1/slaves and
into the subsystem based on the function they implement, again like
other drivers.

Signed-off-by: Andrew F. Davis 
Reviewed-by: Sebastian Reichel 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: Organize driver source to natural/common order

2017-05-25T16:23:03+00:00

Structures and functions should be ordered such that forward declaration
use is minimized.

MODULE_* macros should immediately follow the structures and functions
upon which they act.

Remaining MODULE_* macros should be at the end of the file in
alphabetical order.

Signed-off-by: Andrew F. Davis 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: ds2490: use kmemdup rather than duplicating its implementation

2017-02-10T14:32:53+00:00

Use kmemdup rather than duplicating its implementation.

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: Wei Yongjun 
Acked-by: Maciej S. Szmigiero 
Signed-off-by: Greg Kroah-Hartman

w1: ds2490: USB transfer buffers need to be DMAable

2017-01-25T10:46:42+00:00

ds2490 driver was doing USB transfers from / to buffers on a stack.
This is not permitted and made the driver non-working with vmapped stacks.

Since all these transfers are done under the same bus_mutex lock we can
simply use shared buffers in a device private structure for two most common
of them.

While we are at it, let's also fix a comparison between int and size_t in
ds9490r_search() which made the driver spin in this function if state
register get requests were failing.

Signed-off-by: Maciej S. Szmigiero 
Cc: stable 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

W1: ds2490: Increase timeout when waiting for status

2014-11-07T19:24:01+00:00

Adjust the bulk message timeout to the other ones (1000ms). Otherwise the
following dmesg errors can be seen on a Raspberry Pi:
[   31.492386] Failed to read 1-wire data from 0x81: err=-110.
[   31.504168] 0x81: count=-110, status:
[   31.613404] Failed to read 1-wire data from 0x81: err=-110.
[   31.621915] 0x81: count=-110, status:
[   43.260968] Failed to read 1-wire data from 0x81: err=-110.
[   43.270998] 0x81: count=-110, status:
[   43.379959] Failed to read 1-wire data from 0x81: err=-110.
[   43.388854] 0x81: count=-110, status:

Signed-off-by: Alexander Stein 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1/masters: use pr_* instead of printk

2014-06-20T00:46:51+00:00

This patch replaces all calls to the "printk" function within the "masters"
subdirectory by calls to the appropriate "pr_*" function thus addressing
the following warning generated by the checkpatch script:

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
        then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Fjodor Schelichow 
Signed-off-by: Roman Sommer 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: hold bus_mutex in netlink and search

2014-02-07T23:40:18+00:00

The bus_mutex needs to be taken to serialize access to a specific bus.
netlink wasn't updated when bus_mutex was added and was calling
without that lock held, and not all of the masters were holding the
bus_mutex in a search.  This was causing the ds2490 hardware to stop
responding when both netlink and /sys slaves were executing bus
commands at the same time.

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: ds2490 fix and enable hardware search

2014-02-07T23:40:18+00:00

The hardware search was failing without the COMM_RST flag.  Enabled
the flag and rewrote the function to handle more than one buffer of
results and to continuing where the search left off.  Remove hardware
search note from the limitations now that it works.  The "w1: ds2490
USB setup fixes" change went from 23.16 seconds to about 3 seconds,
this takes the time for the search down to .307346 seconds.

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: ds2490 USB setup fixes

2014-02-07T23:40:18+00:00

Calling usb_reset_configuration after usb_set_interface resets the
interface that was just selected, so call reset first.
Using alternative 3 greatly speeds the one wire search.
alt 0 or 1, 10ms int, 23.16 seconds
alt 2 or 3,  1ms int, 2.99 to 3.05 seconds

Use usb_interrupt_msg not usb_bulk_msg as it is an interrupt pipe
(bulk worked, it was just technically the wrong call).

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman