linux-toradex.git/drivers/w1/slaves, branch v6.6-rc1

w1: therm: constify pointers to hwmon_channel_info

2023-05-08T10:16:38+00:00

Statically allocated array of pointed to hwmon_channel_info can be made
const for safety.

Link: https://lore.kernel.org/r/20230407150121.79887-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski

w1: ds2438: remove redundant initialization of variable crc

2023-05-08T06:14:51+00:00

Variable crc is being initialized with a value that is never read,
it is being re-assigned later on. The initialization is redundant
and can be removed.

Cleans up clang scan build warning:
warning: Value stored to 'crc' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20220522194622.13277-1-colin.i.king@gmail.com
Signed-off-by: Krzysztof Kozlowski

w1: w1_therm: fix typo in comment

2023-05-08T06:14:51+00:00

Spelling mistake (triple letters) in comment.
Detected with the help of Coccinelle.

Signed-off-by: Julia Lawall 
Link: https://lore.kernel.org/r/20220521111145.81697-6-Julia.Lawall@inria.fr
Signed-off-by: Krzysztof Kozlowski

w1: w1_therm: Use max() instead of doing it manually

2023-05-08T06:14:51+00:00

Fix following coccicheck warning:
drivers/w1/slaves/w1_therm.c:1452:18-19: WARNING opportunity for max()

Signed-off-by: Haowen Bai 
Link: https://lore.kernel.org/r/1646908169-8050-1-git-send-email-baihaowen@meizu.com
Signed-off-by: Krzysztof Kozlowski

w1: Fix Kconfig indentation

2023-05-08T06:14:50+00:00

Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
	$ sed -e 's/^        /\t/' -i */Kconfig

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20191120133826.12964-1-krzk@kernel.org
Signed-off-by: Krzysztof Kozlowski

w1: w1_therm: fix locking behavior in convert_t

2023-05-08T06:13:35+00:00

The commit 67b392f7b8ed ("w1_therm: optimizing temperature read timings")
accidentially inverted the logic for lock handling of the bus mutex.

Before:
  pullup -> release lock before sleep
  no pullup -> release lock after sleep

After:
  pullup -> release lock after sleep
  no pullup -> release lock before sleep

This cause spurious measurements of 85 degree (powerup value) on the
Tarragon board with connected 1-w temperature sensor
(w1_therm.w1_strong_pull=0).

In the meantime a new feature for polling the conversion
completion has been integrated in these branches with
commit 021da53e65fd ("w1: w1_therm: Add sysfs entries to control
conversion time and driver features"). But this feature isn't
available for parasite power mode, so handle this separately.

Link: https://lore.kernel.org/regressions/2023042645-attentive-amends-7b0b@gregkh/T/
Fixes: 67b392f7b8ed ("w1_therm: optimizing temperature read timings")
Signed-off-by: Stefan Wahren 
Link: https://lore.kernel.org/r/20230427112152.12313-1-stefan.wahren@i2se.com
Signed-off-by: Krzysztof Kozlowski

w1: ds2433: do not use assignment in if condition

2023-04-20T12:15:06+00:00

Assignments in if condition are less readable and error-prone.  Fixes
also checkpatch warning:

  ERROR: do not use assignment in if condition

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20230415104304.104134-7-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman

w1: use octal for file permissions

2023-04-20T12:15:06+00:00

Improve code readability and checkpatch warnings:

  WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20230415104304.104134-6-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman

w1: minor white-space and code style fixes

2023-04-20T12:15:06+00:00

Correct several coding convention violations around white-spaces:

  ERROR: spaces required around that '=' (ctx:VxV)
  WARNING: Missing a blank line after declarations
  ERROR: "foo* bar" should be "foo *bar"
  ERROR: "(foo*)" should be "(foo *)"
  WARNING: Block comments use * on subsequent lines
  WARNING: Block comments use a trailing */ on a separate line
  WARNING: please, no space before tabs
  WARNING: Missing a blank line after declarations
  ERROR: open brace '{' following struct go on the same line
  ERROR: that open brace { should be on the previous line

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20230415104304.104134-4-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman

w1: ds28e04: correct kerneldoc annotation

2023-04-20T12:15:06+00:00

Correct kerneldoc comments (or drop annotation) to fix:

  w1_ds28e04.c:57: warning: This comment starts with '/**', but isn't a kernel-doc comment.
  w1_ds28e04.c:149: warning: This comment starts with '/**', but isn't a kernel-doc comment.

Reviewed-by: Randy Dunlap 
Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20230415104304.104134-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman